diff mbox

[dpdk-dev,2/4] Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y

Message ID 1412265386-26291-3-git-send-email-sergio.gonzalez.monroy@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Sergio Gonzalez Monroy Oct. 2, 2014, 3:56 p.m. UTC 
  When RTE_BUILD_COMBINE_LIBS=y is configured, there won't be individual shared
libraries to copy over.

Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
 mk/rte.lib.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Matthew Hall Oct. 2, 2014, 8 p.m. UTC | #1 
On Thu, Oct 02, 2014 at 04:56:24PM +0100, Sergio Gonzalez Monroy wrote:
> When RTE_BUILD_COMBINE_LIBS=y is configured, there won't be individual shared
> libraries to copy over.

As a user of RTE_BUILD_COMBINE_LIBS, disabling the ability to use the 
individual libs after the option is enabled is not helpful. It would be more 
helpful if all libs are kept available, so when working with multiple DPDK 
apps which might prefer combined or uncombined, everything will still work.

Thanks,
Matthew.
diff mbox

Patch

diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index f458258..d594692 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -158,9 +158,11 @@  endif
 # install lib in $(RTE_OUTPUT)/lib
 #
 $(RTE_OUTPUT)/lib/$(LIB): $(LIB)
+ifneq ($(RTE_BUILD_COMBINE_LIBS),y)
 	@echo "  INSTALL-LIB $(LIB)"
 	@[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib
 	$(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib
+endif
 
 #
 # Clean all generated files