[dpdk-dev] l3fwd-acl: fix possible memory leak.
Commit Message
At error app_acl_init() can return without freeing dynamically allocated memory.
Not really a big problem, as if app_acl_init() fails,
then application would terminate immediately anyway.
Though it is a good coding practise to make a function to cleanup after itself.
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
examples/l3fwd-acl/main.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
> At error app_acl_init() can return without freeing dynamically allocated memory.
> Not really a big problem, as if app_acl_init() fails,
> then application would terminate immediately anyway.
> Though it is a good coding practise to make a function to cleanup after itself.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied
Thanks
@@ -1247,6 +1247,10 @@ app_acl_init(void)
acl_log("Socket %d of lcore %u is out "
"of range %d\n",
socketid, lcore_id, NB_SOCKETS);
+ free(route_base_ipv4);
+ free(route_base_ipv6);
+ free(acl_base_ipv4);
+ free(acl_base_ipv6);
return -1;
}