[dpdk-dev] fix bug can not build example application for missing link library

Message ID

1418808044-18540-1-git-send-email-yong.liu@intel.com (mailing list archive)

State

Accepted, archived

Headers

From: Marvin Liu <yong.liu@intel.com>
To: dev@dpdk.org
Date: Wed, 17 Dec 2014 17:20:44 +0800
Message-Id: <1418808044-18540-1-git-send-email-yong.liu@intel.com>
Subject: [dpdk-dev] [PATCH] fix bug can not build example application for
	missing link library
Precedence: list
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Commit Message

Marvin Liu Dec. 17, 2014, 9:20 a.m. UTC

  From: Yong Liu <yong.liu@intel.com>

main.o: In function `rte_pktmbuf_free':
main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id'

Signed-off-by: Marvin liu <yong.liu@intel.com>
---
 mk/rte.app.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Bruce Richardson Dec. 17, 2014, 10:47 a.m. UTC | #1

On Wed, Dec 17, 2014 at 05:20:44PM +0800, Marvin Liu wrote:
> From: Yong Liu <yong.liu@intel.com>
> 
> main.o: In function `rte_pktmbuf_free':
> main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id'
> 
> Signed-off-by: Marvin liu <yong.liu@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  mk/rte.app.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 5fc3118..b51d814 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -61,7 +61,7 @@ ifeq ($(NO_AUTOLIBS),)
>  
>  LDLIBS += --whole-archive
>  
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>  
>  ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
>  LDLIBS += -lrte_distributor
> @@ -129,7 +129,7 @@ endif
>  
>  LDLIBS += --start-group
>  
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>  
>  ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y)
>  LDLIBS += -lrte_kvargs
> @@ -251,7 +251,7 @@ build: _postbuild
>  
>  exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
>  
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
>  LDLIBS += -l$(RTE_LIBNAME)
>  endif
>  
> -- 
> 1.9.3
>

Thomas Monjalon Dec. 17, 2014, 11 a.m. UTC | #2

2014-12-17 10:47, Bruce Richardson:
> On Wed, Dec 17, 2014 at 05:20:44PM +0800, Marvin Liu wrote:
> > From: Yong Liu <yong.liu@intel.com>
> > 
> > main.o: In function `rte_pktmbuf_free':
> > main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id'
> > 
> > Signed-off-by: Marvin liu <yong.liu@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks for the quick fix

Patch

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 5fc3118..b51d814 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -61,7 +61,7 @@  ifeq ($(NO_AUTOLIBS),)
 
 LDLIBS += --whole-archive
 
-ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
 
 ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
 LDLIBS += -lrte_distributor
@@ -129,7 +129,7 @@  endif
 
 LDLIBS += --start-group
 
-ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
 
 ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y)
 LDLIBS += -lrte_kvargs
@@ -251,7 +251,7 @@  build: _postbuild
 
 exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
 
-ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
 LDLIBS += -l$(RTE_LIBNAME)
 endif