[dpdk-dev] i40e: compile fix on ICC 13.0.0

  Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.

Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
                       ^

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Compile warnings on ICC and clang can be found, and treated as errors.
Disabling those warnings forcedly can fix them.

v2 changes:
Added the fix for the compile error on clang.

Helin Zhang (2):
  i40e: compile fix on ICC 13.0.0
  i40e: compile fix on clang 3.3

 lib/librte_pmd_i40e/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Compile warnings on ICC and clang can be found, and treated as errors.
Disabling those warnings forcedly can fix them.

v2 changes:
Added the fix for the compile error on clang.

v3 changes:
Reworded the commit titles.

Helin Zhang (2):
  i40e: compile fix on ICC 13.0.0
  i40e: compile fix on clang 3.3

 lib/librte_pmd_i40e/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> Compile warnings on ICC and clang can be found, and treated as errors.
> Disabling those warnings forcedly can fix them.
> 
> v2 changes:
> Added the fix for the compile error on clang.
> 
> v3 changes:
> Reworded the commit titles.
> 
> Helin Zhang (2):
>   i40e: compile fix on ICC 13.0.0
>   i40e: compile fix on clang 3.3
> 
>  lib/librte_pmd_i40e/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> -- 
> 1.8.1.4
> 
Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  

On 2015/05/19 0:03, Helin Zhang wrote:
> Compile warnings on ICC and clang can be found, and treated as errors.
> Disabling those warnings forcedly can fix them.
>
> v2 changes:
> Added the fix for the compile error on clang.
>
> Helin Zhang (2):
>   i40e: compile fix on ICC 13.0.0
>   i40e: compile fix on clang 3.3
>
>  lib/librte_pmd_i40e/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
  

2015-05-18 16:43, Bruce Richardson:
> On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > Compile warnings on ICC and clang can be found, and treated as errors.
> > Disabling those warnings forcedly can fix them.
> > 
> > v2 changes:
> > Added the fix for the compile error on clang.
> > 
> > v3 changes:
> > Reworded the commit titles.
> 
> Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
I reworded the commit message and added reference to the breaking commit:
	http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf
Please consider giving this kind of explanation when fixing things,
especially for special handling of base drivers.
  

Thomas, thank you!

- Helin

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, May 19, 2015 6:33 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang
> 
> 2015-05-18 16:43, Bruce Richardson:
> > On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > > Compile warnings on ICC and clang can be found, and treated as
> errors.
> > > Disabling those warnings forcedly can fix them.
> > >
> > > v2 changes:
> > > Added the fix for the compile error on clang.
> > >
> > > v3 changes:
> > > Reworded the commit titles.
> >
> > Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Applied, thanks
> I reworded the commit message and added reference to the breaking
> commit:
> 	http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf
> Please consider giving this kind of explanation when fixing things,
> especially for special handling of base drivers.