[dpdk-dev] config:enlarge the default value of RTE_MAX_QUEUES_PER_PORT to 1024

Message ID 1432776978-24998-1-git-send-email-jijiang.liu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jijiang Liu May 28, 2015, 1:36 a.m. UTC
  The default value of RTE_MAX_QUEUES_PER_PORT is 256, which is too small for some configurations for i40e. There will return an error when configured queue number is larger than 256 in 

rte_eth_dev_configure().

For example, in vHost sample, PF queue number: 64, configured vmdq pool number: 63, each vmdq pool has 4 queues, there will be required 316 queues in a port.


Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
 config/common_bsdapp   |    2 +-
 config/common_linuxapp |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Zhang, Helin June 1, 2015, 1 a.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Thursday, May 28, 2015 9:36 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] config:enlarge the default value of
> RTE_MAX_QUEUES_PER_PORT to 1024
> 
> The default value of RTE_MAX_QUEUES_PER_PORT is 256, which is too small for
> some configurations for i40e. There will return an error when configured queue
> number is larger than 256 in
> 
> rte_eth_dev_configure().
> 
> For example, in vHost sample, PF queue number: 64, configured vmdq pool
> number: 63, each vmdq pool has 4 queues, there will be required 316 queues in a
> port.
> 
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

> ---
>  config/common_bsdapp   |    2 +-
>  config/common_linuxapp |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/config/common_bsdapp b/config/common_bsdapp index
> c2374c0..0b169c8 100644
> --- a/config/common_bsdapp
> +++ b/config/common_bsdapp
> @@ -137,7 +137,7 @@ CONFIG_RTE_LIBRTE_KVARGS=y
> CONFIG_RTE_LIBRTE_ETHER=y  CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
>  CONFIG_RTE_MAX_ETHPORTS=32
> -CONFIG_RTE_MAX_QUEUES_PER_PORT=256
> +CONFIG_RTE_MAX_QUEUES_PER_PORT=1024
>  CONFIG_RTE_LIBRTE_IEEE1588=n
>  CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
>  CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y
> diff --git a/config/common_linuxapp b/config/common_linuxapp index
> 0078dc9..5deb55a 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -134,7 +134,7 @@ CONFIG_RTE_LIBRTE_KVARGS=y
> CONFIG_RTE_LIBRTE_ETHER=y  CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
>  CONFIG_RTE_MAX_ETHPORTS=32
> -CONFIG_RTE_MAX_QUEUES_PER_PORT=256
> +CONFIG_RTE_MAX_QUEUES_PER_PORT=1024
>  CONFIG_RTE_LIBRTE_IEEE1588=n
>  CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
>  CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y
> --
> 1.7.7.6
  
Thomas Monjalon June 2, 2015, 4:25 p.m. UTC | #2
2015-06-01 01:00, Zhang, Helin:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> > The default value of RTE_MAX_QUEUES_PER_PORT is 256, which is too small for
> > some configurations for i40e. There will return an error when configured queue
> > number is larger than 256 in
> > rte_eth_dev_configure().
> > 
> > For example, in vHost sample, PF queue number: 64, configured vmdq pool
> > number: 63, each vmdq pool has 4 queues, there will be required 316 queues in a
> > port.
> > 
> > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied, thanks
  

Patch

diff --git a/config/common_bsdapp b/config/common_bsdapp
index c2374c0..0b169c8 100644
--- a/config/common_bsdapp
+++ b/config/common_bsdapp
@@ -137,7 +137,7 @@  CONFIG_RTE_LIBRTE_KVARGS=y
 CONFIG_RTE_LIBRTE_ETHER=y
 CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
 CONFIG_RTE_MAX_ETHPORTS=32
-CONFIG_RTE_MAX_QUEUES_PER_PORT=256
+CONFIG_RTE_MAX_QUEUES_PER_PORT=1024
 CONFIG_RTE_LIBRTE_IEEE1588=n
 CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
 CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 0078dc9..5deb55a 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -134,7 +134,7 @@  CONFIG_RTE_LIBRTE_KVARGS=y
 CONFIG_RTE_LIBRTE_ETHER=y
 CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
 CONFIG_RTE_MAX_ETHPORTS=32
-CONFIG_RTE_MAX_QUEUES_PER_PORT=256
+CONFIG_RTE_MAX_QUEUES_PER_PORT=1024
 CONFIG_RTE_LIBRTE_IEEE1588=n
 CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
 CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y