[dpdk-dev,2/3] vhost: fix the comments and log
Commit Message
It fixes the wrong log info when fails to unregister vhost driver.
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
examples/vhost/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 7/2/2015 11:33 AM, Ouyang, Changchun wrote:
> It fixes the wrong log info when fails to unregister vhost driver.
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
> examples/vhost/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 7863dcf..72c4773 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -3051,10 +3051,10 @@ main(int argc, char *argv[])
> if (mergeable == 0)
> rte_vhost_feature_disable(1ULL << VIRTIO_NET_F_MRG_RXBUF);
>
> - /* Register CUSE device to handle IOCTLs. */
> + /* Register vhost driver to handle IOCTLs. */
Also update IOCTLS.
or: register vhost [cuse or user] driver to handle vhost message.
> ret = rte_vhost_driver_register((char *)&dev_basename);
> if (ret != 0)
> - rte_exit(EXIT_FAILURE,"CUSE device setup failure.\n");
> + rte_exit(EXIT_FAILURE,"vhost driver register failure.\n");
>
> rte_vhost_driver_callback_register(&virtio_net_device_ops);
>
On 7/2/2015 11:33 AM, Ouyang, Changchun wrote:
> It fixes the wrong log info when fails to unregister vhost driver.
As commented elsewhere, fails in unregistering, not fails to unregister. :).
> -----Original Message-----
> From: Xie, Huawei
> Sent: Thursday, July 2, 2015 5:25 PM
> To: Ouyang, Changchun; dev@dpdk.org
> Cc: Cao, Waterman; Xu, Qian Q
> Subject: Re: [PATCH 2/3] vhost: fix the comments and log
>
>
> On 7/2/2015 11:33 AM, Ouyang, Changchun wrote:
> > It fixes the wrong log info when fails to unregister vhost driver.
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > ---
> > examples/vhost/main.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/examples/vhost/main.c b/examples/vhost/main.c index
> > 7863dcf..72c4773 100644
> > --- a/examples/vhost/main.c
> > +++ b/examples/vhost/main.c
> > @@ -3051,10 +3051,10 @@ main(int argc, char *argv[])
> > if (mergeable == 0)
> > rte_vhost_feature_disable(1ULL <<
> VIRTIO_NET_F_MRG_RXBUF);
> >
> > - /* Register CUSE device to handle IOCTLs. */
> > + /* Register vhost driver to handle IOCTLs. */
>
> Also update IOCTLS.
> or: register vhost [cuse or user] driver to handle vhost message.
Make sense, will update it, thanks
> > ret = rte_vhost_driver_register((char *)&dev_basename);
> > if (ret != 0)
> > - rte_exit(EXIT_FAILURE,"CUSE device setup failure.\n");
> > + rte_exit(EXIT_FAILURE,"vhost driver register failure.\n");
> >
> > rte_vhost_driver_callback_register(&virtio_net_device_ops);
> >
@@ -3051,10 +3051,10 @@ main(int argc, char *argv[])
if (mergeable == 0)
rte_vhost_feature_disable(1ULL << VIRTIO_NET_F_MRG_RXBUF);
- /* Register CUSE device to handle IOCTLs. */
+ /* Register vhost driver to handle IOCTLs. */
ret = rte_vhost_driver_register((char *)&dev_basename);
if (ret != 0)
- rte_exit(EXIT_FAILURE,"CUSE device setup failure.\n");
+ rte_exit(EXIT_FAILURE,"vhost driver register failure.\n");
rte_vhost_driver_callback_register(&virtio_net_device_ops);