diff mbox

[dpdk-dev] fm10k: remove useless code

Message ID 1437084317-13942-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger July 16, 2015, 10:05 p.m. UTC 
  The return in fm10k_dev_handle_fault has useless conditional
since it always returns 0 here.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/fm10k/fm10k_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Chen, Jing D July 21, 2015, 7:19 a.m. UTC | #1 
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, July 17, 2015 6:05 AM
> To: Chen, Jing D
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH] fm10k: remove useless code
> 
> The return in fm10k_dev_handle_fault has useless conditional
> since it always returns 0 here.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Jing Chen <jing.d.chen@intel.com>
Thomas Monjalon July 22, 2015, 10:44 a.m. UTC | #2 
> > The return in fm10k_dev_handle_fault has useless conditional
> > since it always returns 0 here.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Acked-by: Jing Chen <jing.d.chen@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 902ccae..493b6f9 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -1793,8 +1793,6 @@  fm10k_dev_handle_fault(struct fm10k_hw *hw, uint32_t eicr)
 			fault.address, fault.specinfo);
 	}
 
-	if (estr)
-		return 0;
 	return 0;
 error:
 	PMD_INIT_LOG(ERR, "Failed to handle fault event.");