From patchwork Sun Dec 6 18:46:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 9373 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9530C9267; Sun, 6 Dec 2015 19:47:30 +0100 (CET) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id A1D029255 for ; Sun, 6 Dec 2015 19:47:29 +0100 (CET) Received: by wmec201 with SMTP id c201so137415459wme.0 for ; Sun, 06 Dec 2015 10:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tuT23t5jPvJf4o6T57qyxukQioq1Pa9kVJ/GRTdxKEQ=; b=Mbs6dStcjdbXC/6nnm/0duEJuhzGbcts6e7xbqHzPk5/vk1WC1hs5ZDyOQM+7R72te y8eqyYu8haYnztDIukWmMQhlR95KQeNakhhqmjSKgKzrHgQ0+HzcxHTq+mIpyQCUJE7V fONfT/miwgud1TChepRXPJr814m9ITAHpi6MOgh7DCZDuOPbmz7pEFaR1Gc44UnNAJ8u BrL8ljdBoK2r+OtHjFAGVNvrTUyay1PybTDHEHX4n19skr8p8RKS526vBrHeL7y2v3Wk w4U3vq+VopIzsE4EtFSm0N56d6r2l8tV37isj6u70Oknb4AlIbmnT5/3MqQv8zUFSqtN 5M+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tuT23t5jPvJf4o6T57qyxukQioq1Pa9kVJ/GRTdxKEQ=; b=Bgg2wX+DkETCdkqStt0+MdDHxi9wGAEYMHQFK8uuiHyOYKjkbZpog9Zp2XraCUJGg5 wvStzrPNky9bFoKeynIGHKQPw7OHJpw+wbGwacGNyitpXsN/GS5eIpJDeWgrdB6BLQG/ U3mAtAVdypBDQNqzM3Rewf4P/2z/mcNESXK3S+TE6zFO1Lj5lgJmj7dXnjiKgIKEvLYD /iyN05KRu3TUtJUUoeYAUv+b3eBIgTITDLohwYxTOw1GvGcHRNgEeJAiKOiEtB6F56JT Y9WoQb+H8f2mpWOYeF7Tqm+rdoCR636yG4K/MjIzeWbxzjkdJrOJmLndUoC6bAYoM44/ 9pig== X-Gm-Message-State: ALoCoQnQSu69d2eWG/OEBGyrYgzwxZx7nDWLmvcP+uZFeYb0CKlyA+LQ8mHP9kvW+rJSwrFrFpxY X-Received: by 10.194.118.74 with SMTP id kk10mr28364284wjb.5.1449427649467; Sun, 06 Dec 2015 10:47:29 -0800 (PST) Received: from localhost.localdomain (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id vr10sm21850853wjc.38.2015.12.06.10.47.28 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Dec 2015 10:47:28 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Sun, 6 Dec 2015 19:46:05 +0100 Message-Id: <1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.5.2 In-Reply-To: References: Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH v2 1/2] mk: prepare dependencies in shared libraries not combined X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some DPDK libraries have a dependency. The Mellanox drivers embed this declaration in shared library case. So the application do not need to know the dependency when linking. But it cannot work with static libraries or the combined one. Note that Mellanox drivers are currently not supported in a shared combined library case. Most of the DPDK libraries declare their dependencies to be linked with the application in every cases, even when using drivers as shared library plugins. This patch improves the condition used for Mellanox drivers, so that it can be applied to other drivers without breaking the shared combined library case. Signed-off-by: Thomas Monjalon --- mk/rte.app.mk | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index d7e2964..3f56852 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -102,13 +102,13 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n) _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse endif -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) +# The static libraries do not know their dependencies. +# The combined library fails also to store this information. +# So linking with static or combined library requires explicit dependencies. +ifneq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(CONFIG_RTE_BUILD_SHARED_LIB),ny) _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -libverbs -endif # ! CONFIG_RTE_BUILD_SHARED_LIBS - -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -libverbs -endif # ! CONFIG_RTE_BUILD_SHARED_LIBS +endif # CONFIG_RTE_BUILD_COMBINE_LIBS or not CONFIG_RTE_BUILD_SHARED_LIBS _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz