From patchwork Mon Dec 14 07:48:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jijiang Liu X-Patchwork-Id: 9523 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E601958D4; Mon, 14 Dec 2015 08:49:01 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E48C7559C for ; Mon, 14 Dec 2015 08:48:59 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 13 Dec 2015 23:48:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,426,1444719600"; d="scan'208";a="617543349" Received: from shilc102.sh.intel.com ([10.239.39.44]) by FMSMGA003.fm.intel.com with ESMTP; 13 Dec 2015 23:48:58 -0800 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shilc102.sh.intel.com with ESMTP id tBE7mtnl018170; Mon, 14 Dec 2015 15:48:55 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id tBE7mqMJ028174; Mon, 14 Dec 2015 15:48:54 +0800 Received: (from jijiangl@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id tBE7mqKS028170; Mon, 14 Dec 2015 15:48:52 +0800 From: Jijiang Liu To: dev@dpdk.org Date: Mon, 14 Dec 2015 15:48:51 +0800 Message-Id: <1450079331-28139-1-git-send-email-jijiang.liu@intel.com> X-Mailer: git-send-email 1.7.12.2 Subject: [dpdk-dev] [PATCH v3] doc: announce ABI change for struct rte_eth_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In current codes, tunnel configuration information is not stored in a device configuration, and it will get nothing if application want to retrieve tunnel config, so I think it is necessary to add rte_eth_dev_tunnel_configure() function is to do the configurations including flow and classification information and store it in a device configuration. And tunneling packet encapsulation operation will benifit from the change. There are more descriptions for the ABI changes below, The struct 'rte_eth_tunnel_conf' is a new, its defination like below, struct rte_eth_tunnel_conf { uint16_t tx_queue; uint16_t filter_type; struct rte_eth_tunnel_flow flow_tnl; }; The ABI change announcement of struct 'rte_eth_tunnel_flow' have already sent out, refer to [1]. [1]http://dpdk.org/ml/archives/dev/2015-December/029837.html. The change of struct 'rte_eth_conf' like below, but it have not finalized yet. struct rte_eth_conf { ... uint32_t dcb_capability_en; struct rte_fdir_conf fdir_conf; /**< FDIR configuration. */ struct rte_intr_conf intr_conf; /**< Interrupt mode configuration. */ struct rte_eth_tunnel_conf *tunnel_conf[RTE_MAX_QUEUES_PER_PORT]; /**< Tunnel configuration. */ }; v2 change: Add more description for the change. v3 change: Change ABI announcement description. Signed-off-by: Jijiang Liu Acked-by: Andrey Chilikin --- doc/guides/rel_notes/deprecation.rst | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 5c458f2..9dbe89e 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -23,3 +23,9 @@ Deprecation Notices * ABI changes are planned for struct rte_eth_tunnel_flow in order to extend new fileds to support tunneling packet configuration in unified tunneling APIs. The release 2.2 does not contain these ABI changes, but release 2.3 will, and no backwards compatibility is planned. + +* ABI changes are planned for the struct rte_eth_conf in order to add 'tunnel_conf' variable + in the struct to store tunnel configuration when using new API rte_eth_dev_tunnel_configure + (uint8_t port_id, uint16_t rx_queue, struct rte_eth_tunnel_conf * tunnel_conf) to configure + tunnel flow and classification information. The release 2.2 does not contain these ABI change, + but release 2.3 will, and no backward compatibility is planned.