diff mbox

[dpdk-dev] ixgbe: restore imissed stat counter

Message ID 1450195501-9196-1-git-send-email-robin.jarry@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Robin Jarry Dec. 15, 2015, 4:05 p.m. UTC 
  This counter was left unmodified. Restore it in ixgbe_dev_stats_get.

The ierrors counter still includes imissed for ixgbe. This behaviour is
not consistent amongst all drivers. Another patch may be needed to unify
the meaning of the ierrors counter.

Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")

Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Van Haaren, Harry Dec. 15, 2015, 4:41 p.m. UTC | #1 
> From: Robin Jarry [mailto:robin.jarry@6wind.com]
> Subject: [PATCH] ixgbe: restore imissed stat counter
> 
> This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
> 
> The ierrors counter still includes imissed for ixgbe. This behaviour is
> not consistent amongst all drivers. Another patch may be needed to unify
> the meaning of the ierrors counter.
> 
> Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")
> 
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>

There is work to be done to allow easier distinction between
drops due to the host, and errors due to bad packets.

Until that work is done, write the dropped packet count to imissed, so:

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Thomas Monjalon Dec. 15, 2015, 5:06 p.m. UTC | #2 
2015-12-15 16:41, Van Haaren, Harry:
> > From: Robin Jarry [mailto:robin.jarry@6wind.com]
> > Subject: [PATCH] ixgbe: restore imissed stat counter
> > 
> > This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
> > 
> > The ierrors counter still includes imissed for ixgbe. This behaviour is
> > not consistent amongst all drivers. Another patch may be needed to unify
> > the meaning of the ierrors counter.
> > 
> > Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")
> > 
> > Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
> 
> There is work to be done to allow easier distinction between
> drops due to the host, and errors due to bad packets.
> 
> Until that work is done, write the dropped packet count to imissed, so:
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 1b6cd8efe815..4c4c6dfb1622 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2546,6 +2546,7 @@  ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	}
 
 	/* Rx Errors */
+	stats->imissed  = total_missed_rx;
 	stats->ierrors  = hw_stats->crcerrs +
 	                  hw_stats->mspdc +
 	                  hw_stats->rlec +