Message ID | 1450312714-10979-1-git-send-email-stephen@networkplumber.org (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 764345AA0; Thu, 17 Dec 2015 01:38:31 +0100 (CET) Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id A8C1C5A9D for <dev@dpdk.org>; Thu, 17 Dec 2015 01:38:29 +0100 (CET) Received: by mail-pf0-f171.google.com with SMTP id o64so20635436pfb.3 for <dev@dpdk.org>; Wed, 16 Dec 2015 16:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=uKH5fkOFS+ClX6bFXPrTabQBmB2LQKfxF3PfyWkNTSs=; b=tSmO/PgF2xAPiL3Tb7w+Axbpf/hmG0ANQeG/DWqBQllDhCgSDeZs5UQeBfRGAgMz8A +ardA2GSpSdLUguQyDtNG4ceYDSjBOpB0mB1xJUI0pfpQIT8bqwny6AMzhOn4fWzjZPV FeYHxXPVSm/hJVooWo7dwY7grxYDYtPm+Ac6yf7xMjeM2hVtu51h/r22ao/hNEMR5K7+ 5ifBnKzI3dBXqaBJsuPL2JAhv+TtTZIK31+9M92bbozH52rynOgdaXg7SuhOHNUrHmay SjdwQ3uaBJT0QodNXwxzHLq0+QKoX73ypeB8zloDh48wMGG7MWqCnnPP1o/Gl1rJXVk0 J5lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uKH5fkOFS+ClX6bFXPrTabQBmB2LQKfxF3PfyWkNTSs=; b=kiTphXO+uLNbrpZ43M3RIzDCp5OA2QdEPT2x+iJKaMI+0DZNuVMGGSqnzWgj3hmWDS 594QcShipTUnMYWwltc13AFEPuApQ9H6woPoOEvTRbEgLqGrjWpTlYxwLCSeZZxHTz10 fJ35ed5pkZA23ZqVw00DbggK2xD6HuwRxNXArF0Sp9myrbpwN0c+wY+TBplETFrZoEZI ccwq9+Vcl/JF5vtcss6SzZCqmbmy7i9GpOTHssNTm2BxLQnhlFgQHKR2KZRlh96RffZ6 rw5cdfQS87FQ5NZ14b4Uc1G7373iRSPzMJOzle5u3xzSbcnu/Tu3PdyCkTxNBXKDjuxO +KWw== X-Gm-Message-State: ALoCoQlM65zahIPUeJvivlzmlsamsJlbSXdmjxhlwuOHKIbuXNGAD7LNGtECvyWGc7nJHIAytDSx+S5VjwdDX5vzCsL+eTEccg== X-Received: by 10.98.87.201 with SMTP id i70mr10115462pfj.130.1450312708837; Wed, 16 Dec 2015 16:38:28 -0800 (PST) Received: from xeon-e3.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id 62sm7197367pfq.90.2015.12.16.16.38.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Dec 2015 16:38:28 -0800 (PST) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Date: Wed, 16 Dec 2015 16:38:34 -0800 Message-Id: <1450312714-10979-1-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] log: add missing symbol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Stephen Hemminger
Dec. 17, 2015, 12:38 a.m. UTC
rte_get_log_type and rte_get_log_level functions has been avaliable
for many versions. But they are missing from the shared library map
and therefore do not get exported correctly.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
1 file changed, 2 insertions(+)
Comments
On Wed, Dec 16, 2015 at 04:38:34PM -0800, Stephen Hemminger wrote: > rte_get_log_type and rte_get_log_level functions has been avaliable > for many versions. But they are missing from the shared library map > and therefore do not get exported correctly. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > index cbe175f..51a241c 100644 > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > @@ -93,7 +93,9 @@ DPDK_2.0 { > rte_realloc; > rte_set_application_usage_hook; > rte_set_log_level; > + rte_get_log_level; > rte_set_log_type; > + rte_get_log_type; > rte_socket_id; > rte_strerror; > rte_strsplit; > -- > 2.1.4 > > Acked-by: Neil Horman <nhorman@tuxdriver.com>
2015-12-16 16:38, Stephen Hemminger: > rte_get_log_type and rte_get_log_level functions has been avaliable > for many versions. But they are missing from the shared library map > and therefore do not get exported correctly. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ > 1 file changed, 2 insertions(+) Why only in linuxapp? > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > index cbe175f..51a241c 100644 > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > @@ -93,7 +93,9 @@ DPDK_2.0 { > rte_realloc; > rte_set_application_usage_hook; > rte_set_log_level; > + rte_get_log_level; > rte_set_log_type; > + rte_get_log_type; We try to keep an alphabetical order :)
2016-01-27 10:35, Thomas Monjalon: > 2015-12-16 16:38, Stephen Hemminger: > > rte_get_log_type and rte_get_log_level functions has been avaliable > > for many versions. But they are missing from the shared library map > > and therefore do not get exported correctly. > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > --- > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ > > 1 file changed, 2 insertions(+) > > Why only in linuxapp? > > > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > index cbe175f..51a241c 100644 > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > @@ -93,7 +93,9 @@ DPDK_2.0 { > > rte_realloc; > > rte_set_application_usage_hook; > > rte_set_log_level; > > + rte_get_log_level; > > rte_set_log_type; > > + rte_get_log_type; > > We try to keep an alphabetical order :) Reordered, updated in bsdapp/ and Applied, thanks
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map index cbe175f..51a241c 100644 --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map @@ -93,7 +93,9 @@ DPDK_2.0 { rte_realloc; rte_set_application_usage_hook; rte_set_log_level; + rte_get_log_level; rte_set_log_type; + rte_get_log_type; rte_socket_id; rte_strerror; rte_strsplit;