diff mbox

[dpdk-dev,v3,4/4] vmxnet3: announce device offload capability

Message ID 1452039178-15635-5-git-send-email-yongwang@vmware.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Yong Wang Jan. 6, 2016, 12:12 a.m. UTC 
  Signed-off-by: Yong Wang <yongwang@vmware.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

Comments

Stephen Hemminger Jan. 6, 2016, 12:52 a.m. UTC | #1 
On Tue,  5 Jan 2016 16:12:58 -0800
Yong Wang <yongwang@vmware.com> wrote:

>  
>  /* return 0 means link status changed, -1 means not changed */
> @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on)
>  	else
>  		VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid);
>  
> -	/* don't change active filter if in promiscious mode */
> +	/* don't change active filter if in promiscuous mode */

Maybe send a first patch in series with these message and comment cleanups?

Makes the review easier, and aides bisection.
Yong Wang Jan. 13, 2016, 2:20 a.m. UTC | #2 
On 1/5/16, 4:52 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:

>On Tue,  5 Jan 2016 16:12:58 -0800

>Yong Wang <yongwang@vmware.com> wrote:

>

>>  

>>  /* return 0 means link status changed, -1 means not changed */

>> @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on)

>>  	else

>>  		VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid);

>>  

>> -	/* don't change active filter if in promiscious mode */

>> +	/* don't change active filter if in promiscuous mode */

>

>Maybe send a first patch in series with these message and comment cleanups?

>

>Makes the review easier, and aides bisection.


Sure and patch updated.
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index c363bf6..8a40127 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -693,7 +693,8 @@  vmxnet3_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 }
 
 static void
-vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
+vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev,
+		     struct rte_eth_dev_info *dev_info)
 {
 	dev_info->max_rx_queues = VMXNET3_MAX_RX_QUEUES;
 	dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES;
@@ -716,6 +717,17 @@  vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, struct rte_
 		.nb_min = VMXNET3_DEF_TX_RING_SIZE,
 		.nb_align = 1,
 	};
+
+	dev_info->rx_offload_capa =
+		DEV_RX_OFFLOAD_VLAN_STRIP |
+		DEV_RX_OFFLOAD_UDP_CKSUM |
+		DEV_RX_OFFLOAD_TCP_CKSUM;
+
+	dev_info->tx_offload_capa =
+		DEV_TX_OFFLOAD_VLAN_INSERT |
+		DEV_TX_OFFLOAD_TCP_CKSUM |
+		DEV_TX_OFFLOAD_UDP_CKSUM |
+		DEV_TX_OFFLOAD_TCP_TSO;
 }
 
 /* return 0 means link status changed, -1 means not changed */
@@ -819,7 +831,7 @@  vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on)
 	else
 		VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid);
 
-	/* don't change active filter if in promiscious mode */
+	/* don't change active filter if in promiscuous mode */
 	if (rxConf->rxMode & VMXNET3_RXM_PROMISC)
 		return 0;