From patchwork Mon Apr 18 17:13:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Mrzyglod X-Patchwork-Id: 12102 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 06898568A; Mon, 18 Apr 2016 18:13:32 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 20A115689 for ; Mon, 18 Apr 2016 18:13:29 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 18 Apr 2016 09:13:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,503,1455004800"; d="scan'208";a="957556081" Received: from gklab-246-025.igk.intel.com (HELO Sent) ([10.217.246.25]) by orsmga002.jf.intel.com with SMTP; 18 Apr 2016 09:13:06 -0700 Received: by Sent (sSMTP sendmail emulation); Mon, 18 Apr 2016 19:13:24 +0200 From: Daniel Mrzyglod To: jing.d.chen@intel.com, jingjing.wu@intel.com, helin.zhang@intel.com Cc: dev@dpdk.org, Daniel Mrzyglod Date: Mon, 18 Apr 2016 19:13:23 +0200 Message-Id: <1460999603-188184-1-git-send-email-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1460998153-187871-1-git-send-email-danielx.t.mrzyglod@intel.com> References: <1460998153-187871-1-git-send-email-danielx.t.mrzyglod@intel.com> Subject: [dpdk-dev] [PATCH v2] i40e: dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix issue reported by Coverity. Coverity ID 13302: There may be a null pointer dereference, or else the comparison against null is unnecessary. In i40evf_config_vlan_pvid: All paths that lead to this null pointer comparison already dereference the pointer earlier Fixes: 2b12431b5369 ("i40e: add vlan stripping and insertion to VF") Signed-off-by: Daniel Mrzyglod Acked-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 2bce69b..2d75b96 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -538,7 +538,7 @@ i40evf_config_vlan_pvid(struct rte_eth_dev *dev, struct vf_cmd_info args; struct i40e_virtchnl_pvid_info tpid_info; - if (dev == NULL || info == NULL) { + if (info == NULL) { PMD_DRV_LOG(ERR, "invalid parameters"); return I40E_ERR_PARAM; }