From patchwork Tue May 10 10:11:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Mrzyglod X-Patchwork-Id: 12645 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 981C79608; Tue, 10 May 2016 11:11:07 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4A1AD9607 for ; Tue, 10 May 2016 11:11:06 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 10 May 2016 02:11:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="972379057" Received: from gklab-246-025.igk.intel.com (HELO Sent) ([10.217.246.25]) by orsmga002.jf.intel.com with SMTP; 10 May 2016 02:11:02 -0700 Received: by Sent (sSMTP sendmail emulation); Tue, 10 May 2016 12:11:42 +0200 From: Daniel Mrzyglod To: cristian.dumitrescu@intel.com Cc: dev@dpdk.org, Daniel Mrzyglod Date: Tue, 10 May 2016 12:11:04 +0200 Message-Id: <1462875064-119474-1-git-send-email-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH] sched: fix useless call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix issue reported by Coverity. Coverity ID 13338 A function call that seems to have an intended effect has no actual effect on the logic of the program. In rte_sched_port_free: A function is called that is only useful for its return value, and this value is ignored. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Daniel Mrzyglod Acked-by: "Ferruh Yigit " --- lib/librte_sched/rte_sched.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 1609ea8..9b962a6 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -749,7 +749,6 @@ rte_sched_port_free(struct rte_sched_port *port) rte_pktmbuf_free(mbufs[i]); } - rte_bitmap_free(port->bmp); rte_free(port); }