diff mbox

[dpdk-dev] qede: fix build issue in the cross-compiling mode

Message ID 1464169261-25455-1-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jerin Jacob May 25, 2016, 9:41 a.m. UTC 
  In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
instead of just gcc

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 drivers/net/qede/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit May 25, 2016, 5:01 p.m. UTC | #1 
On 5/25/2016 10:41 AM, Jerin Jacob wrote:
> In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> instead of just gcc
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  drivers/net/qede/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
> index c9b3b1c..10ced84 100644
> --- a/drivers/net/qede/Makefile
> +++ b/drivers/net/qede/Makefile
> @@ -47,7 +47,7 @@ endif
>  endif
>  endif
>  
> -ifneq (,$(filter gcc gcc48,$(CC)))
> +ifneq (,$(filter %gcc %gcc48,$(CC)))

What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
This saves adding gcc version or cross compilation related check.

>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
>  CFLAGS_BASE_DRIVER += -Wno-missing-declarations
>  CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
>
Thomas Monjalon May 25, 2016, 5:27 p.m. UTC | #2 
2016-05-25 18:01, Ferruh Yigit:
> On 5/25/2016 10:41 AM, Jerin Jacob wrote:
> > In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> > instead of just gcc
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > -ifneq (,$(filter gcc gcc48,$(CC)))
> > +ifneq (,$(filter %gcc %gcc48,$(CC)))
> 
> What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
> This saves adding gcc version or cross compilation related check.

True!
It could be used instead every occurences of "ifeq ($(CC), icc)" and so on.

cc Hiroyuki Mikita
It is the same issue with http://dpdk.org/patch/13013
diff mbox

Patch

diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index c9b3b1c..10ced84 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -47,7 +47,7 @@  endif
 endif
 endif
 
-ifneq (,$(filter gcc gcc48,$(CC)))
+ifneq (,$(filter %gcc %gcc48,$(CC)))
 CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
 CFLAGS_BASE_DRIVER += -Wno-missing-declarations
 CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized