From patchwork Fri Sep 9 02:42:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt X-Patchwork-Id: 15702 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 378872C4F; Thu, 8 Sep 2016 16:18:19 +0200 (CEST) Received: from mail-pa0-f68.google.com (mail-pa0-f68.google.com [209.85.220.68]) by dpdk.org (Postfix) with ESMTP id 8DFA22B88 for ; Thu, 8 Sep 2016 16:18:17 +0200 (CEST) Received: by mail-pa0-f68.google.com with SMTP id h5so2478988pao.0 for ; Thu, 08 Sep 2016 07:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=rOWQrxFkAsllC2NA7rT6LMg7PgIe0F+/ouVvkPvBTd8=; b=hfus5gksarkyiINaxFvMewQvQc3X9jQT3VE/caKbMXBOm4rWZM5BerNZeTZ3xFvDeA ZzMsywo6roSjUfX+j/Tu99ISDXMXuWWoA0CgU095u/ezMXGSmrgWY0/Coz3WVLRQ9aGB XxnWQjMTY1Ez4fZAlbZd9CfcuLHqwccTid0KA4QIlm9DrNvwqPRfoINHqk55SI8KPE/W i+o2RibRE7mX0LuAF15eqMJg37zGL71ST2NnC1IdoUR9xPVdiuZrPHFrmBS8fXc65q3D Wi38jRGywExWeGxtsDU+ic6MN+HPGfnesmCu4igMUPvEFWErCbe+cxQemGdLqTnnk3rK 0c8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rOWQrxFkAsllC2NA7rT6LMg7PgIe0F+/ouVvkPvBTd8=; b=DIJlwycqPMsIrBWuljUUrtAOwXJB2bId8JgKfpOiSj48YTk9O3KI1TaijVXkgsFiuk Th15/BP2MBYhgMLdDOLKeYD78VartzZ59TWmi8k7mnrR77JhnmCEbApMlWh8jfmxhfeg by9iiyXNKjOEz7BLqrCTgyYA07YdhqzY1g3eJHC3BfDwlmvAZ8t6L3TPtPvfG2IglRXn NXtK7p1i9kPs5coI2SJB8ULfEqkPQyFWBVbUZcB+QiPzFYw44+I17k8W29wkPfv8ovSp BQEkG4nqxM/0ftMot1oJTDcgoforwti1SOVdp54S+/G8Gnca+30kehwF0o2xhSOqkOZK PPEQ== X-Gm-Message-State: AE9vXwN6qPbcKrYym5pYD4EgPg453wUGTAb5qPoSA2aZXubowH+1Wo8fk1oUJk8uQHhsyA== X-Received: by 10.66.249.74 with SMTP id ys10mr35890224pac.29.1473344296798; Thu, 08 Sep 2016 07:18:16 -0700 (PDT) Received: from localhost.localdomain ([175.25.175.119]) by smtp.gmail.com with ESMTPSA id xn11sm56915933pac.38.2016.09.08.07.17.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Sep 2016 07:18:16 -0700 (PDT) From: zhouyangchao To: ferruh.yigit@intel.com Cc: dev@dpdk.org, zhouyangchao Date: Fri, 9 Sep 2016 10:42:16 +0800 Message-Id: <1473388936-2706-1-git-send-email-zhouyates@gmail.com> X-Mailer: git-send-email 1.7.1 Subject: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: zhouyangchao --- lib/librte_eal/linuxapp/kni/kni_misc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index 67e9b7d..17b6d7a 100644 --- a/lib/librte_eal/linuxapp/kni/kni_misc.c +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c @@ -361,6 +361,9 @@ kni_dev_remove(struct kni_dev *dev) igb_kni_remove(dev->pci_dev); if (dev->net_dev) { + if (dev->net_dev->state == NETREG_REGISTERED) { + unregister_netdev(dev->net_dev); + } unregister_netdev(dev->net_dev); free_netdev(dev->net_dev); }