From patchwork Fri Sep 9 02:46:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt X-Patchwork-Id: 15703 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8F59A37A6; Thu, 8 Sep 2016 16:21:44 +0200 (CEST) Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id ACB21379B for ; Thu, 8 Sep 2016 16:21:42 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id 128so2589576pfb.0 for ; Thu, 08 Sep 2016 07:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=2N5N/0EKjWDIvAVhjROzVfySy+4SH49wcRfdsMsHY6o=; b=CvuVPksUg9oLCJRs+wsYJpDU07fiT4b2XVOS2f5czrbSJNBCsO53GuYpmHZKhHG1Up fHrP0xnAxjKUxlyCvXzEDkzGCqJZ6xrp4eP6UCOwNSFplivlAcm7G+pBOQY66cGaPVBE DJ9x3pTnStGnyqwgKmwX40wxG7BAb6PZzn90kmG8898graG5shjDYVHd7FrUZnUa/o0h 0ZxkSn9BrZEApDvSEcLlA6tbpHaZdLx1u/IDROuLA+OpUYoN+wqq7RMILuLgw6L1P6GF VqMKbLu2YV5Au6ss8/vYcREWTxuq7atDV/RFH1qbEtI4X8NDnoSvODavLxorGji5Pdgc p6ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2N5N/0EKjWDIvAVhjROzVfySy+4SH49wcRfdsMsHY6o=; b=LuaXLDl69jysn0HiNjhzJJlb+MRErsyKAvUBBHuePKtifwHbzCqhfe/wQ5/WUnCric lNKc2lsmDn2SwC+AzjhB4x1lZrx60LISarZS6TRHLoMtkQ+z8b2GjwJ1W7TnbMUkxv0h tLI5htjHDF0P2K5hpCy8FfRAor4f8T6P5b83nxp4SImjWfftBYwBysCJX1vlj48UuUPl KXIpyAFuMDlecoSS3bHn7BhsiOgEvXVwkF4ax9j0P2GLT8fP3KROXGTbRVC13IQdm8ZU +QuRRDVRwLzpsTXmIvlMp1GaLqTWPMHl5aiqIFsGqgfcmNEw/WSk2IfNVidluYou080Z 7rww== X-Gm-Message-State: AE9vXwNmwiuMQw4fahz7OamMvACyJCcfT/gwM0BvxYA43WYjBMv+mSY9+giDRVNv2+VNbA== X-Received: by 10.98.32.200 with SMTP id m69mr7201206pfj.15.1473344501672; Thu, 08 Sep 2016 07:21:41 -0700 (PDT) Received: from localhost.localdomain ([211.157.188.187]) by smtp.gmail.com with ESMTPSA id ty6sm56991369pac.18.2016.09.08.07.21.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Sep 2016 07:21:41 -0700 (PDT) From: zhouyangchao To: ferruh.yigit@intel.com Cc: dev@dpdk.org, zhouyangchao Date: Fri, 9 Sep 2016 10:46:07 +0800 Message-Id: <1473389167-2758-1-git-send-email-zhouyates@gmail.com> X-Mailer: git-send-email 1.7.1 Subject: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: zhouyangchao --- lib/librte_eal/linuxapp/kni/kni_misc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index 67e9b7d..ad4e603 100644 --- a/lib/librte_eal/linuxapp/kni/kni_misc.c +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c @@ -361,7 +361,9 @@ kni_dev_remove(struct kni_dev *dev) igb_kni_remove(dev->pci_dev); if (dev->net_dev) { - unregister_netdev(dev->net_dev); + if (dev->netdev->reg_state == NETREG_REGISTERED){ + unregister_netdev(dev->net_dev); + } free_netdev(dev->net_dev); }