From patchwork Sat Dec 3 18:34:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 17581 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5FDD9591E; Sat, 3 Dec 2016 19:34:17 +0100 (CET) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0088.outbound.protection.outlook.com [104.47.32.88]) by dpdk.org (Postfix) with ESMTP id A205058CB; Sat, 3 Dec 2016 19:34:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mIYLTbT3raV5ETNcQr57m+9N0N1TXjYRmS85y2jb0ys=; b=QcCaRcprhYv1U2chx3TXdeakNbGtuSgcYYylD+g7xxpeKI9oy33kwQ3JGn9hFu50RYnEqLWzIw0ZcX+j/QttlXajPBeD4PL/20dFjlRv7AS0O4SDyL+A5C4BpxqjPAhIIbwHR+dN19HYTO3Vej0nX+DWprgMVnm2He7ZEK3VrPU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.net (96.95.216.225) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Sat, 3 Dec 2016 18:34:11 +0000 From: Jerin Jacob To: CC: , , Jerin Jacob , Date: Sun, 4 Dec 2016 00:04:01 +0530 Message-ID: <1480790041-6398-1-git-send-email-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1479237103-7166-1-git-send-email-jerin.jacob@caviumnetworks.com> References: <1479237103-7166-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [96.95.216.225] X-ClientProxiedBy: CO1PR06CA030.namprd06.prod.outlook.com (10.242.160.20) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 2:mh/SLZKdNimYOUTgpicfCC1lPxq6KvSQ1kjDUKGD32X9EdwqvIamq7lgEWp7ybKagK5bcHgLUB8SRePj36UvZEEH0IZ+ZXFJTyhiRAEPYAYdtlctS51PNEEtSdCY0cMLhjwoWwke5CekSVW6tb+tyxbS3zTcumsAtWc4ecK0+Bo=; 3:YOk1JZe75LaIIt2r2RjyuleEOy6aPWgh04xGdygEDlJtcMoqoodDDhEGTtnXH55qwGv26xtZH+33harjZWo+yGucI6Qxvg3nSnvgloSQMvWcGnU6sK2Z2V8WYywD+PRxQw+Ct3yY6CXX4/k+gBlAu1r0r91GE9kpMWBMc+ThdkQ=; 25:9hv8k7ZFmOOrgmrUIYwhItyw3KETQlVNvERcI3miLRamo6fw2uNCfu+eVcMk3X3Z3II5h8BNPEwe3fCE7+JUohBKLZvhDduCrYy+9vW3jrPOUVMQJyaRfKbT4GTjf/7vBpHkyICg0lsvDUnxpps/kRPStNMVQS3IFDrGPFlShohVz8cVxBXqqWhB7X69hj3uMN2oimI9NXbXSAUBfJLiGG/gYy2vo4ZmUvgihfNw9DceGrDxsSmW5DXWbY3Fd0Y0DLX50Y3TF8g72njgWkLOgtA9iXEGGSmBXRJzhbpkyDxaccpavo+ESXr4lhLPN5a2y+Z5Ez27iI6xekIJWpjE6Yhf36wci7YL2iOUvgoMzGnOcL+fMgdkKpcoxyKUdZ2YyEN1JJVgf97Zy0xURqiuZTGHh1tsFVa5D0tlXobk8zR+b39LetVZrDQkGUcKG2sAYQdAWbF9qjpnDa0Gl16z3w== X-MS-Office365-Filtering-Correlation-Id: de954ced-3e6a-4b61-7fbd-08d41baafa26 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:QcD5eEmt156Csspqn/oQorlYSEcokEgqclISSafkjNbP6YZypM2LMnQ9ZNvQn0PMeYfifeywuC17yOyVwsJugHNDmP5Z5UwF/K7d4I1yunXdslWpp7dbc22MXmlEgTfsnGQ05lpmq6IOCb7JJR1oUEwLFL3btvHswYbwm+kCWa2c7pkzZyHBQNoX4iXX45XslsxGVrHpoNSl1BKJEScMFOvv3Na/RwhaxXcYKU4vzENTIfvcaAJVtBaP9QuOiQa7YxK/8lU5TGnBhuyHxQGkUQ==; 20:Tr98PWwPsyzdEEzFvUSjyiKkDnZCHdA6t/mjn7QCASJKJa1O0IINqeqzxjWeUSR624djdnpPZ5zcC+o5HG1bUJsiXskFxxex1AaIAz5e/hYdG8/3tY31T7SpJBl9wiZcW1U4FEIYEXCyDa2FhHTpiFw3nQitQDHdEqwj5Ztu/kgN4SCJbfV5UMJVyIM7MMAnkdNVq9oO9lTZThwUm2oU2wK2XgsS8Oi1i60beWJvk6J08mZprxJJ0h0ti9UF1d77wLM3GS0BFnlKkvahgXKtCKEaZEEohONd66SZfDIP5uklrto0CQTGvWW/gksyl/NbUaWcLoSfcoD/+/VTxoj+xfpfxbhmvoUqVuqLv2Aor6ko+cru/PW60u5nIWkaSxf0R6iB/zAclRZI4ZQPNV56xNKqVlK/vPAVH1ECQfbGp/P/LffeQeS0VB03L7CcfTmp4/e+RInmKUc5J02pJPq3D3zYnhlipPH5oB5Bupq+9gjGKlOjRjKUf64nnWGacP+EtT3nyEVh84JWTaIS7oMffOLQQPoZsWnisg2AUZtKxB3nBOsZZzfxt39rfAEJGsdDZ81bpVf4laJ/du4jLEKNFYWwyrlM9zQMpGWx58ctL8U= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:Ovtg4pE+XxpcebOV+xSigMZhG9cSgv1Pop1hOGHw20qe8dLwGGHTKl9uAPn/XAg3yJoAQxwL3oO34/7IqGvKNvZSFEUFpTJ5noHLc9JXVLyF1CDYJX0+Y7SYxigdhayRpZJ6njazDhwCt0iKpXQaLIVEQlNjPQpzhHjfELezXj1Ch3FZBV9tFEqXGW/AU1+sTleZShw7B3AQmqU5FQIN3j3xIW7s+TwD1LYpYLIOBgIBFo0TOFi4H2jCG/49gRD42rXGTjXOX9o+Qpa490+KKT9VsPEilEfe2LPIMGYXTojdxaOuRQXbaQfPCD2UGdlKtgSfEbHQZNxnRLKorv4piES4+3zpBdbk06BUNuaA4KkEqOxq6e7Ed3eHXKPiMVJIdZ7eTABoiW8rOs8v8tgwFoqmVpR7h4NQlTpWzOAADUuYxsnNO35b9kDvUbn2WDusneTDHnfZBpSuuEI1HENPRumDy5kJAqf7TNpshpTDyOrFu4w82Gaa/kQ7UC0v6e+jCJoneKo8vMuZf1y5oq6M0XUGgoFtQOyGAvlj8zKMGmLmzQLZxUDNJApuXLT4EoGL0Ha8hGji2vPnsZyd6by21T66v6yxOMVDp3EXULgM7qunvMswrD8NncZx4R4ZMPUk X-Forefront-PRVS: 0145758B1D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6009001)(6069001)(7916002)(189002)(199003)(21086003)(33026002)(6506006)(36756003)(7736002)(6666003)(5003940100001)(39410400001)(101416001)(6116002)(189998001)(48376002)(50986999)(66066001)(76176999)(7846002)(33646002)(92566002)(305945005)(81156014)(2906002)(4326007)(575784001)(106356001)(42882006)(5660300001)(47776003)(38730400001)(110136003)(2950100002)(8676002)(81166006)(5890100001)(68736007)(6916009)(2351001)(39450400002)(733004)(6486002)(76506005)(50466002)(42186005)(3846002)(105586002)(6512006)(97736004)(50226002)(69596002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:jhDgLQy8vNuFJYV9MJKd4dyKDHiCnLNxPmwgB3Q?= =?us-ascii?Q?YEf4iwvOj6wHoLLZogIlTQjTsQCclZ8FmCPTYZcn3ckZ68uSBRPfpOPyBYKE?= =?us-ascii?Q?QVP65eHCJW2Cs0CVWF7Bn4uCV5PwPFBjqL+5tCkv+V182tSF5fkjvKeXJhSs?= =?us-ascii?Q?1I+dY7+6wG1CiQowutxczyR+33OKXsm7ncsc/DyNtavkBiaRSI5QH8c/MHNX?= =?us-ascii?Q?lze9dG8bL2DPjXzXTCecr5vz6uVwSCyCPIU5Z59HrvCqvp/eHQKegsmbaLQM?= =?us-ascii?Q?ayJfssbth4ZVNwTdQyWTmYvky8bYI8RXS+Mo3J8xGmsL8PTUxI4TFokIR4oO?= =?us-ascii?Q?jPRtOM431xaHhOgfnMi4r3MriyBw3gvEFzxWlxzyvONkVo5o9WLX91UY+7IY?= =?us-ascii?Q?+d4i29TiuK7V33e5z3zVH5iOALnEdeMTei9el29cvd2pLqC5bpPvpBrnsgdW?= =?us-ascii?Q?pi+SC0POkmuza/ZGrD1lpHArgIc1ZE/oLul60jPWEHdJovrd37oMCaEBYdaP?= =?us-ascii?Q?dFfsGthiMPMym1x1+nvmboGdXlY7NXZAbGQk6oFQ10X+PKmrUADEJ9h8gP1y?= =?us-ascii?Q?Q1J/tuU/5rZipkpnZuzJfKySJy7p6MKYCsE0G8BzYJyoDHSR2EanRthILjC0?= =?us-ascii?Q?NT7TvtwyRyvYdc/RGZCWvH2EbrQ/njHP23kiKTaTfA6ppRlgfJjN9eTKmEUt?= =?us-ascii?Q?UDNR5UTSNZqUCzEAtTlXY1kod4IQpr/s2dwRGV0n/SUdNPhDn/gqG9USWDS1?= =?us-ascii?Q?nS9C/gemZSDaiHfxA9401GaKgLJ+YKWQ7xO5taSc7N/eSG+8nEZujjDL8//7?= =?us-ascii?Q?6UKwsUGZvwyqyYgXo0HWmDxFhO8lwBmHER4XUBfYLAA8FS8kFC2ccLTbnfV0?= =?us-ascii?Q?l9QCIgfoqPZmJ9Ejx1yVh3rk9oE2tDTAdKjNsFjgQN+9j6HRpUQelnbA2HoZ?= =?us-ascii?Q?KMqj/5bs0XLnN+Y/pw0RJFwPbDgcx+fl1p1YDKyE1x4gawQZS+Z4efGw7bvR?= =?us-ascii?Q?DUarMjuasNkPfVRdH+S7tpnxnou09qwXCRZgyb9rf54msQWpNk73xDQmGGtK?= =?us-ascii?Q?kapkhLlSmZ8oBNWN+hBA8kO9C8dhEGnkDGrHCWpwO9iUbCH1ReAM7Tb1sPIy?= =?us-ascii?Q?Y4AGSwU5RaGuibDLil6JkFi+As5/gdPh68eMH5TIlM68/5Ar5oXLkMpxJEnC?= =?us-ascii?Q?ZvmFQUGaXr9vGRYBR93/BVDWwNnxoO99t3OT1iEZlIuKyoBwCCmo+T7c62j6?= =?us-ascii?Q?f2bCa2olhPqRPiflDIJS1Ncs0A0hxSL7svOHmam7mZ2Vcn4UjAYlFF7l6BQ6?= =?us-ascii?Q?ZHqJ3Iz5KkTNn4jbScSLefInNXm4T3/yNaF9CdNpG7cwgQXM67nc/yoA4vKY?= =?us-ascii?Q?VF4gwsc+LLX1Fqe2zqnm8WRdmxOM9Cf2tZlyy2TBqJBGHvZfcou4fSSW2tI/?= =?us-ascii?Q?8M19h6I9V/Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:QPhS5ph08P6bhSxLGSWp2wA6I56rIWK2nres2NiY2lYM91VeccjiypoLqotHPCES6qqtjHPSsXqHJgeIjiii/TtgdvYvzgLJm9sGLfrvHIejRrSugANNy8k83v27AUnwiRjX4f/pJ+PyhMQL1ep+zIarDd3DUZFVyqaMwK8wj2KBwgnMAhi/88qolCCxC3FE3bRoNu6R1uFt3CMixQmxtCxpZbY9n8mTjSC+EHW8ePOtJhTQC5zcFUddVdicRiEJ+2aibWCEt8+2j8JLYDEqCCty/YDwAPpe4PeA5ZcpFENvvrSbwdsJ6j2rLRgOdZQnKK5d8V1N+ajvFisU6G0YNSDAK8/puaPRPHQ8kCI1yV8=; 5:TKTMTLeA+HRck7kYQPlFpvXKO0PNMSAoMEZhpqqVFz1jBiv+jP5BjufqWHelxGbJNjduZVV+41imyeeBRTq+EdIcb0Zq5ZHxtzRJ6BLqcz1O8t7oAHkgNYSIw/NJra6vGxmnXGin0gaqoRcFYUpshg==; 24:Ip63UENC7iR3yaOFSAzi4X1qXuEmb4WXWphX+hOfjZ5f4a+RK4aBbc2cejvHKO6ZEtcOe6Mrvmr5ss2opzkqsOtcMCy19XcmdfSHNETKaZE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 7:jayajIyqOvwfi2bKpHZD2zT6bjSUBmxw4wSntR6idI9O7dGJZ89sEhEFLQBcv6d0Sm7CO84QSe53gicMf2m1ax9UjL+VlND0fvm/GMWYmM0kx+K58G7B1q348xOv6idLqiIGXH+UWHGn9tu0fnHNXmbcSqHM1smi65iHvHVyrh/RHpC8H674dxEKLX+wzu9ED8SlwVKHVgiklnPJ+UMVCHkQ0VQ/nOjkCUYDH2HyQtVCbE2A2eqFUFTkumXujpkdEUL03t4AQr9D3SfVIKjffwKnZYm7s2c2koYcxTBi4IIWrtC0NLYt6eS4YEqHYpri5XZPlwfJYByQiUnFt3l/mIA8hz0//jM3LzdvJZvMnw8= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2016 18:34:11.2862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: [dpdk-dev] [PATCH v2] cryptodev: fix crash on null dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" crypodev->data->name will be null when rte_cryptodev_get_dev_id() invoked without a valid crypto device instance. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Signed-off-by: Jerin Jacob Acked-by: Arek Kusztal CC: stable@dpdk.org --- lib/librte_cryptodev/rte_cryptodev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 127e8d0..54e95d5 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -225,13 +225,14 @@ rte_cryptodev_create_vdev(const char *name, const char *args) } int -rte_cryptodev_get_dev_id(const char *name) { +rte_cryptodev_get_dev_id(const char *name) +{ unsigned i; if (name == NULL) return -1; - for (i = 0; i < rte_cryptodev_globals->max_devs; i++) + for (i = 0; i < rte_cryptodev_globals->nb_devs; i++) if ((strcmp(rte_cryptodev_globals->devs[i].data->name, name) == 0) && (rte_cryptodev_globals->devs[i].attached ==