diff mbox

[dpdk-dev,1/2] net/ixgbe: remove unused global variable

Message ID 1482833398-30145-1-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Jerin Jacob Dec. 27, 2016, 10:09 a.m. UTC 
  Removed unused "reg_info" global variable from ixgbe driver.

cat build/app/testpmd.map | grep "Allocating common symbols" -A 15
Allocating common symbols
Common symbol   size    file
reg_info        0x18    build/lib/librte_pmd_ixgbe.a(ixgbe_ethdev.o)

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 drivers/net/ixgbe/ixgbe_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Jan. 3, 2017, 1:23 p.m. UTC | #1 
On 12/27/2016 10:09 AM, Jerin Jacob wrote:
> Removed unused "reg_info" global variable from ixgbe driver.
> 
> cat build/app/testpmd.map | grep "Allocating common symbols" -A 15
> Allocating common symbols
> Common symbol   size    file
> reg_info        0x18    build/lib/librte_pmd_ixgbe.a(ixgbe_ethdev.o)
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Jan. 3, 2017, 3:44 p.m. UTC | #2 
On 1/3/2017 1:23 PM, Ferruh Yigit wrote:
> On 12/27/2016 10:09 AM, Jerin Jacob wrote:
>> Removed unused "reg_info" global variable from ixgbe driver.
>>
>> cat build/app/testpmd.map | grep "Allocating common symbols" -A 15
>> Allocating common symbols
>> Common symbol   size    file
>> reg_info        0x18    build/lib/librte_pmd_ixgbe.a(ixgbe_ethdev.o)
>>
>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_regs.h b/drivers/net/ixgbe/ixgbe_regs.h
index 773e169..2aa4820 100644
--- a/drivers/net/ixgbe/ixgbe_regs.h
+++ b/drivers/net/ixgbe/ixgbe_regs.h
@@ -41,7 +41,7 @@  struct reg_info {
 	uint32_t count;
 	uint32_t stride;
 	const char *name;
-} reg_info;
+};
 
 static const struct reg_info ixgbe_regs_general[] = {
 	{IXGBE_CTRL, 1, 1, "IXGBE_CTRL"},