diff mbox

[dpdk-dev] net/vmxnet3: fix broken debug build

Message ID 1489409638-20193-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Andrew Rybchenko March 13, 2017, 12:53 p.m. UTC 
  Fixes: 4dd452523000 ("net/vmxnet3: add receive data ring support")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Shrikrishna Khare March 13, 2017, 5:19 p.m. UTC | #1 
On Mon, 13 Mar 2017, Andrew Rybchenko wrote:

> Fixes: 4dd452523000 ("net/vmxnet3: add receive data ring support")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Thank you for catching and fixing this.

Acked-by: Shrikrishna Khare <skhare@vmware.com>

> ---
>  drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 01da7e3..ae3efaa 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -347,8 +347,8 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
>  
>  	hw->rxdata_desc_size = VMXNET3_VERSION_GE_3(hw) ?
>  		VMXNET3_DEF_RXDATA_DESC_SIZE : 0;
> -	RTE_ASSERT((hw->rx_data_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
> -		   hw->rx_data_desc_size);
> +	RTE_ASSERT((hw->rxdata_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
> +		   hw->rxdata_desc_size);
>  
>  	return 0;
>  }
> -- 
> 2.9.3
> 
>
Ferruh Yigit March 14, 2017, 4:04 p.m. UTC | #2 
On 3/13/2017 5:19 PM, Shrikrishna Khare wrote:
> 
> 
> On Mon, 13 Mar 2017, Andrew Rybchenko wrote:
> 
>> Fixes: 4dd452523000 ("net/vmxnet3: add receive data ring support")
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> Thank you for catching and fixing this.
> 
> Acked-by: Shrikrishna Khare <skhare@vmware.com>

Squashed into original commit in next-net [1], thanks.

[1]
4dd452523000 ("net/vmxnet3: add receive data ring support")
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 01da7e3..ae3efaa 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -347,8 +347,8 @@  eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
 
 	hw->rxdata_desc_size = VMXNET3_VERSION_GE_3(hw) ?
 		VMXNET3_DEF_RXDATA_DESC_SIZE : 0;
-	RTE_ASSERT((hw->rx_data_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
-		   hw->rx_data_desc_size);
+	RTE_ASSERT((hw->rxdata_desc_size & ~VMXNET3_RXDATA_DESC_SIZE_MASK) ==
+		   hw->rxdata_desc_size);
 
 	return 0;
 }