From patchwork Wed Mar 29 16:53:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 22756 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D8B73D25B; Wed, 29 Mar 2017 20:33:34 +0200 (CEST) Received: from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com [209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 1942FD4AC for ; Wed, 29 Mar 2017 18:54:09 +0200 (CEST) Received: from unknown [12.187.104.26] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 2b6ebd85.2b122788b940.872481.00-2459.2242854.nbfkord-smmo02.seg.att.com (envelope-from ); Wed, 29 Mar 2017 16:54:10 +0000 (UTC) X-MXL-Hash: 58dbe6b24c3adced-c1c6f93a7ca8d1e74a13541ceb83da2d7e317ad2 Received: from unknown [12.187.104.26] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id ea6ebd85.0.872477.00-2384.2242847.nbfkord-smmo02.seg.att.com (envelope-from ); Wed, 29 Mar 2017 16:54:09 +0000 (UTC) X-MXL-Hash: 58dbe6b11e390b27-3f35a5ed5e73c1056436e37b8c5b5d0151a2ba6d Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 29 Mar 2017 09:54:03 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25 via Frontend Transport; Wed, 29 Mar 2017 09:54:03 -0700 Received: from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com [10.17.10.10]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id v2TGs1QT018933; Wed, 29 Mar 2017 17:54:02 +0100 Received: from uklogin.uk.solarflarecom.com (localhost.localdomain [127.0.0.1]) by uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id v2TGs1e4016981; Wed, 29 Mar 2017 17:54:01 +0100 From: Andrew Rybchenko To: CC: Ferruh Yigit Date: Wed, 29 Mar 2017 17:53:55 +0100 Message-ID: <1490806435-16945-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1490800132-1833-1-git-send-email-arybchenko@solarflare.com> References: <1490800132-1833-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-AnalysisOut: [v=2.1 cv=Ndfgoj34 c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==] X-AnalysisOut: [:17 a=6Iz7jQTuP9IA:10 a=zRKbQ67AAAAA:8 a=CEJcFFY3WHiKmPCuj] X-AnalysisOut: [mcA:9 a=PA03WX8tBzeizutn5_OT:22] X-Spam: [F=0.2368437033; CM=0.500; S=0.236(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [12.187.104.26] Subject: [dpdk-dev] [PATCH v2] net/sfc: fix crash on Tx queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Datapath TxQ handle is passed to release function, not control path. Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") Signed-off-by: Andrew Rybchenko --- Please, squash the patch into 19f92f3ec37c. drivers/net/sfc/sfc_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index b745714..bba8b01 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -485,13 +485,15 @@ sfc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id, static void sfc_tx_queue_release(void *queue) { - struct sfc_txq *txq = queue; + struct sfc_dp_txq *dp_txq = queue; + struct sfc_txq *txq; unsigned int sw_index; struct sfc_adapter *sa; - if (txq == NULL) + if (dp_txq == NULL) return; + txq = sfc_txq_by_dp_txq(dp_txq); sw_index = sfc_txq_sw_index(txq); SFC_ASSERT(txq->evq != NULL);