[dpdk-dev] net/sfc: remove logically dead code
Checks
Commit Message
Coverity issue: 1419717
Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Andy Moreton <amoreton@solarflare.com>
---
drivers/net/sfc/sfc_flow.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
Comments
On 4/18/2017 1:51 PM, Andrew Rybchenko wrote:
> Coverity issue: 1419717
> Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Andy Moreton <amoreton@solarflare.com>
Applied to dpdk-next-net/master, thanks.
@@ -837,8 +837,7 @@ sfc_flow_parse_pattern(const struct rte_flow_item pattern[],
return -rte_errno;
}
- for (; pattern != NULL &&
- pattern->type != RTE_FLOW_ITEM_TYPE_END; pattern++) {
+ for (; pattern->type != RTE_FLOW_ITEM_TYPE_END; pattern++) {
item = sfc_flow_get_item(pattern->type);
if (item == NULL) {
rte_flow_error_set(error, ENOTSUP,
@@ -868,13 +867,6 @@ sfc_flow_parse_pattern(const struct rte_flow_item pattern[],
prev_layer = item->layer;
}
- if (pattern == NULL) {
- rte_flow_error_set(error, EINVAL,
- RTE_FLOW_ERROR_TYPE_ITEM, NULL,
- "NULL item");
- return -rte_errno;
- }
-
return 0;
}