diff mbox

[dpdk-dev,v2,07/20] bus/fslmc: export qbman results in map file

Message ID 1494851864-26029-9-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal May 15, 2017, 12:37 p.m. UTC 
  Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/bus/fslmc/rte_bus_fslmc_version.map | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Ferruh Yigit May 15, 2017, 4:55 p.m. UTC | #1 
On 5/15/2017 1:37 PM, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/bus/fslmc/rte_bus_fslmc_version.map | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> index 2db0fce..6e7b94d 100644
> --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
> +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> @@ -49,3 +49,11 @@ DPDK_17.05 {
>  
>  	local: *;
>  };
> +
> +DPDK_17.08 {
> +	global:
> +
> +	qbman_result_SCN_state_in_mem;
> +
> +	local: *;
> +};

Syntax should be:

DPDK_17.08 {
	global:

	qbman_result_SCN_state_in_mem;

} DPDK_17.05;

No "local: *", and previous group (DPDK_17.05) after "}".

But again, it would be nice if you can document in commit log, why
exporting this variable required now?

Thanks,
ferruh
diff mbox

Patch

diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
index 2db0fce..6e7b94d 100644
--- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
+++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
@@ -49,3 +49,11 @@  DPDK_17.05 {
 
 	local: *;
 };
+
+DPDK_17.08 {
+	global:
+
+	qbman_result_SCN_state_in_mem;
+
+	local: *;
+};