From patchwork Tue May 16 16:14:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Miller X-Patchwork-Id: 24323 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 51A532986; Tue, 16 May 2017 18:14:25 +0200 (CEST) Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by dpdk.org (Postfix) with ESMTP id 1569B20F for ; Tue, 16 May 2017 18:14:22 +0200 (CEST) Received: by mail-qt0-f193.google.com with SMTP id l39so21492968qtb.1 for ; Tue, 16 May 2017 09:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=9qGUpdPwCeo+xCXvhQbk5oSZru2oEAFbX3A4eDtF3/w=; b=ZEXCUzE90Mi3y4ING8une/CAiR1xVtP9Atf5yEHsS9jK0a9lO+OLOVF9PTP4QOlVVA ff1LMyEgx0+cbsji/esZgNgA056G9IiqKYlwd8+hHFnU37SLdK42iVbCN17ACU9ualDp 1f/gMTLhu2J1kBJCa6HRnCU5W3nCqJLN6jqAsuDP/n4n+VJXSGF8yIySunwL8ik0/0uZ bALX1bHxeLZwFDH+KC/nZaGaTId4xVZwUPmF2NKvJuNuGx+KRSU3G3vp2ZBI8fsGoiCr pChkDoa6kbzHF0utnCu78P1x8257H3jOT8leU3uN7pOBDLQN3e7mUdsFgXhd/Qi7TNOk xqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9qGUpdPwCeo+xCXvhQbk5oSZru2oEAFbX3A4eDtF3/w=; b=iriIxp1y3fG+q9fN1VfyIu1HXDNMN2b2hmH9jmFJ2hTuMv7IvaXJLiWjyJ8puOXyZs plIPl7i/303D4DBSStqglDJuetF7yEt7vSzujyPmA7/NBr/5fqJb5+1qznZS0hk00koR 21PsXkdGcuKWHLw2YTBzZ1rJdbzFBgoXXkJHqNWSozMmByAO/6XgD9shCqd0Ksj1vdWI VLJ97//TdEpHgbGGdT19zJ80lJwP9lGMPRh+RzXq8mDmiQOKIVZ3Tksni3S2Q8AI7cxY Pu7Foh8AwkjlXMK2nYFxGjxxYHEqOWgE+BR2XnK3OqmsZknWkg37BIumwkaGHyCfDYh9 0KLw== X-Gm-Message-State: AODbwcA6u3/8QFnM4W1/dL5wKhiCZoR2P2hROhI8PddpSWCQr33wdqxL T5gKrNd+2l4hQryf X-Received: by 10.200.3.26 with SMTP id q26mr12117449qtg.3.1494951261916; Tue, 16 May 2017 09:14:21 -0700 (PDT) Received: from LOT3.Home (h69-21-89-58.cntcnh.dsl.dynamic.tds.net. [69.21.89.58]) by smtp.gmail.com with ESMTPSA id y31sm11181852qtb.27.2017.05.16.09.14.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 May 2017 09:14:21 -0700 (PDT) From: John Miller To: dev@dpdk.org Cc: ed.czeck@atomicrules.com, shepard.siegel@atomicrules.com, John Miller Date: Tue, 16 May 2017 12:14:15 -0400 Message-Id: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH 1/4] net/ark: fix for buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 144512 Coverity issue: 144513 Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and pktgen") Signed-off-by: John Miller --- drivers/net/ark/ark_pktchkr.c | 2 +- drivers/net/ark/ark_pktgen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ark/ark_pktchkr.c b/drivers/net/ark/ark_pktchkr.c index 62b3673..c3040af 100644 --- a/drivers/net/ark/ark_pktchkr.c +++ b/drivers/net/ark/ark_pktchkr.c @@ -372,7 +372,7 @@ struct OPTIONS { o->v.INT = atoll(val); break; case OTSTRING: - strncpy(o->v.STR, val, ARK_MAX_STR_LEN); + snprintf(o->v.STR, ARK_MAX_STR_LEN, "%s", val); break; } return 1; diff --git a/drivers/net/ark/ark_pktgen.c b/drivers/net/ark/ark_pktgen.c index bdac054..8c7a8a2 100644 --- a/drivers/net/ark/ark_pktgen.c +++ b/drivers/net/ark/ark_pktgen.c @@ -354,7 +354,7 @@ struct OPTIONS { o->v.INT = atoll(val); break; case OTSTRING: - strncpy(o->v.STR, val, ARK_MAX_STR_LEN); + snprintf(o->v.STR, ARK_MAX_STR_LEN, "%s", val); break; } return 1;