From patchwork Tue May 16 16:14:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Miller X-Patchwork-Id: 24324 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 4A1C42B9A; Tue, 16 May 2017 18:14:28 +0200 (CEST) Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by dpdk.org (Postfix) with ESMTP id 0E91129D9 for ; Tue, 16 May 2017 18:14:25 +0200 (CEST) Received: by mail-qk0-f196.google.com with SMTP id y128so23526519qka.3 for ; Tue, 16 May 2017 09:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QtzxPGRQtrRUoqI7MOGQryZpmV4qaTenGUMIhKTYeiA=; b=BCnIrRQco9Zei7Gua0UzQPv3Mg9bwCVA7E4q6tHkfH1+62lkFtssQvBJBogU2v7k1e +hq3JgLLL7PJYllfUyURtX9yGD1MPA5IIlpMG5jqvV5KoBz31HkdhBmZXemu8ajtbQTF VUQ/AJ1+vqYZZrGjVeDOkahkam3+iVS3HFdVxrSR+7Mv4pvJ45ISUTv3AlMtHlvvZlhd yINblsxdQdij+39QYFurAUe3l6l0DdHkF6WoX1FJqXnSuC0fc+b4TrtOHPtHfGVzMD4+ 6NiLoa02yuX60ZVrrhSQJBwiSPFjeYlil10ugkkYBR/iNzBKtZeJrScae0DoolX+wMy7 mz5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QtzxPGRQtrRUoqI7MOGQryZpmV4qaTenGUMIhKTYeiA=; b=e2hH04Sd4kZc2iPdVQxAdqKOlCRhzd+JiBt3nYMv2s1iV7ZSnzAajF6E1lJqM94KAI xdWDqkvA5kVjPCM3Qyts7sjeSyqrYRtA18ikXYnbwk+IgpPim7b+Yy9md6NAyVrTGnkF jj/nitRXv4pvHyZff3s8K9w9wR/cDg0AN3wO3BSHce9Hw51ErmrCxZTgMBRPjmTz+OtV 0FgKuo7S0aDT/13Ll4OgRjgzcnZo2rK4ixD/opetozauya9nU6CQrJk+ekjYmrQ/oE6a SybrFk7IqkvSfqwN9CFJv5ILoZWfpUpKHq5aSsqVgsBTGtuEzCJKb8mgGLECN+GbJUh0 RiAA== X-Gm-Message-State: AODbwcBCcwlumM2lOc47bg8egATQCJS2Rp12uFHXOhNOPvTVv8i2HSG3 y/KQzrIb9bMYtw== X-Received: by 10.55.186.5 with SMTP id k5mr11887000qkf.302.1494951265415; Tue, 16 May 2017 09:14:25 -0700 (PDT) Received: from LOT3.Home (h69-21-89-58.cntcnh.dsl.dynamic.tds.net. [69.21.89.58]) by smtp.gmail.com with ESMTPSA id y31sm11181852qtb.27.2017.05.16.09.14.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 May 2017 09:14:25 -0700 (PDT) From: John Miller To: dev@dpdk.org Cc: ed.czeck@atomicrules.com, shepard.siegel@atomicrules.com, John Miller Date: Tue, 16 May 2017 12:14:16 -0400 Message-Id: <1494951258-11232-2-git-send-email-john.miller@atomicrules.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> References: <1494951258-11232-1-git-send-email-john.miller@atomicrules.com> Subject: [dpdk-dev] [PATCH 2/4] net/ark: fix return code not checked X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue: 144514 Fixes: 727b3fe292bc ("net/ark: integrate PMD") Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index 995c93d..9143fc4 100644 --- a/drivers/net/ark/ark_ethdev.c +++ b/drivers/net/ark/ark_ethdev.c @@ -588,7 +588,11 @@ static void eth_ark_macaddr_remove(struct rte_eth_dev *dev, /* Delay packet generatpr start allow the hardware to be ready * This is only used for sanity checking with internal generator */ - pthread_create(&thread, NULL, delay_pg_start, ark); + if (pthread_create(&thread, NULL, delay_pg_start, ark)) { + PMD_DRV_LOG(ERR, "Could not create pktgen " + "starter thread\n"); + return -1; + } } if (ark->user_ext.dev_start)