diff mbox

[dpdk-dev] examples/helloworld: add output of core id and socket id

Message ID 1495028996-55146-1-git-send-email-wei.dai@intel.com (mailing list archive)
State Changes Requested, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wei Dai May 17, 2017, 1:49 p.m. UTC 
  Adding output of core id and socket id of each lcore/pthread
can help to understand their relationship.
And this can also help to examine the usage of the EAL lcore
settings like -c, -l and --lcore .

Signed-off-by: Wei Dai <wei.dai@intel.com>
---
 examples/helloworld/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit May 17, 2017, 2:16 p.m. UTC | #1 
On 5/17/2017 2:49 PM, Wei Dai wrote:
> Adding output of core id and socket id of each lcore/pthread
> can help to understand their relationship.
> And this can also help to examine the usage of the EAL lcore
> settings like -c, -l and --lcore .
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  examples/helloworld/main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c
> index 8b7a2de..fdd8818 100644
> --- a/examples/helloworld/main.c
> +++ b/examples/helloworld/main.c
> @@ -50,7 +50,9 @@ lcore_hello(__attribute__((unused)) void *arg)
>  {
>  	unsigned lcore_id;
>  	lcore_id = rte_lcore_id();
> -	printf("hello from core %u\n", lcore_id);
> +	printf("hello from core %2u at core_id = %2u on socket_id = %2u\n",

It is hard to understand difference from "core" and "core_id", what do
you think using "lcore" and "core" respectively in the message?

> +		lcore_id, lcore_config[lcore_id].core_id,
> +		lcore_config[lcore_id].socket_id);
>  	return 0;
>  }
>  
>
Wei Dai May 17, 2017, 2:29 p.m. UTC | #2 
> -----Original Message-----

> From: Yigit, Ferruh

> Sent: Wednesday, May 17, 2017 10:16 PM

> To: Dai, Wei <wei.dai@intel.com>; Richardson, Bruce

> <bruce.richardson@intel.com>; Mcnamara, John <john.mcnamara@intel.com>

> Cc: dev@dpdk.org

> Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and

> socket id

> 

> On 5/17/2017 2:49 PM, Wei Dai wrote:

> > Adding output of core id and socket id of each lcore/pthread can help

> > to understand their relationship.

> > And this can also help to examine the usage of the EAL lcore settings

> > like -c, -l and --lcore .

> >

> > Signed-off-by: Wei Dai <wei.dai@intel.com>

> > ---

> >  examples/helloworld/main.c | 4 +++-

> >  1 file changed, 3 insertions(+), 1 deletion(-)

> >

> > diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c

> > index 8b7a2de..fdd8818 100644

> > --- a/examples/helloworld/main.c

> > +++ b/examples/helloworld/main.c

> > @@ -50,7 +50,9 @@ lcore_hello(__attribute__((unused)) void *arg)  {

> >  	unsigned lcore_id;

> >  	lcore_id = rte_lcore_id();

> > -	printf("hello from core %u\n", lcore_id);

> > +	printf("hello from core %2u at core_id = %2u on socket_id = %2u\n",

> 

> It is hard to understand difference from "core" and "core_id", what do you

> think using "lcore" and "core" respectively in the message?

Yes, it is still a bit confused.
I should change it to printf("hello from lcore_id = %2u at core_id = %2u on socket_id = %2u\n",

> 

> > +		lcore_id, lcore_config[lcore_id].core_id,

> > +		lcore_config[lcore_id].socket_id);

> >  	return 0;

> >  }

> >

> >
Ferruh Yigit May 17, 2017, 2:29 p.m. UTC | #3 
On 5/17/2017 3:29 PM, Dai, Wei wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, May 17, 2017 10:16 PM
>> To: Dai, Wei <wei.dai@intel.com>; Richardson, Bruce
>> <bruce.richardson@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and
>> socket id
>>
>> On 5/17/2017 2:49 PM, Wei Dai wrote:
>>> Adding output of core id and socket id of each lcore/pthread can help
>>> to understand their relationship.
>>> And this can also help to examine the usage of the EAL lcore settings
>>> like -c, -l and --lcore .
>>>
>>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>>> ---
>>>  examples/helloworld/main.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c
>>> index 8b7a2de..fdd8818 100644
>>> --- a/examples/helloworld/main.c
>>> +++ b/examples/helloworld/main.c
>>> @@ -50,7 +50,9 @@ lcore_hello(__attribute__((unused)) void *arg)  {
>>>  	unsigned lcore_id;
>>>  	lcore_id = rte_lcore_id();
>>> -	printf("hello from core %u\n", lcore_id);
>>> +	printf("hello from core %2u at core_id = %2u on socket_id = %2u\n",
>>
>> It is hard to understand difference from "core" and "core_id", what do you
>> think using "lcore" and "core" respectively in the message?
> Yes, it is still a bit confused.
> I should change it to printf("hello from lcore_id = %2u at core_id = %2u on socket_id = %2u\n",

+1

> 
>>
>>> +		lcore_id, lcore_config[lcore_id].core_id,
>>> +		lcore_config[lcore_id].socket_id);
>>>  	return 0;
>>>  }
>>>
>>>
>
diff mbox

Patch

diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c
index 8b7a2de..fdd8818 100644
--- a/examples/helloworld/main.c
+++ b/examples/helloworld/main.c
@@ -50,7 +50,9 @@  lcore_hello(__attribute__((unused)) void *arg)
 {
 	unsigned lcore_id;
 	lcore_id = rte_lcore_id();
-	printf("hello from core %u\n", lcore_id);
+	printf("hello from core %2u at core_id = %2u on socket_id = %2u\n",
+		lcore_id, lcore_config[lcore_id].core_id,
+		lcore_config[lcore_id].socket_id);
 	return 0;
 }