From patchwork Tue Jun 6 11:04:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shijith Thotton X-Patchwork-Id: 25067 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 971C2567C; Tue, 6 Jun 2017 13:05:06 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0087.outbound.protection.outlook.com [104.47.34.87]) by dpdk.org (Postfix) with ESMTP id 833F45398 for ; Tue, 6 Jun 2017 13:05:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ooESayhN/vF+tOo7GwZhQ3yCmN5vp0U110ohvTR14A8=; b=oT6qa4h4c0xcHSgku3RjsfuEGpKyude6gWw2SyShLXphoSWfTj7ITqoiXXfJ6qRn0ka6B9B2GCclcdTLjJW61UHdNQl2nbGNn0XGyteYX8qrFkGS8O0YdPZnOAP/U8jVGYW/zgSFcqzYoYSUskHsJTdM1wlD+fuApUuABtAHL8A= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from lio357.in.caveonetworks.com (14.140.2.178) by MWHPR07MB3072.namprd07.prod.outlook.com (10.172.97.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1143.10; Tue, 6 Jun 2017 11:04:59 +0000 From: Shijith Thotton To: dev@dpdk.org Date: Tue, 6 Jun 2017 16:34:34 +0530 Message-Id: <1496747074-23138-1-git-send-email-shijith.thotton@caviumnetworks.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BMXPR01CA0017.INDPRD01.PROD.OUTLOOK.COM (10.174.214.155) To MWHPR07MB3072.namprd07.prod.outlook.com (10.172.97.14) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR07MB3072: X-MS-Office365-Filtering-Correlation-Id: 85e61f66-d1ca-4453-281a-08d4accbe0c8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:MWHPR07MB3072; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3072; 3:gx99FenzkbHQwCz7jbUuvuI5lb5XxdXtYtmDcbqsE+n385H7gF56YuvwjhrDtkNDo2w6Q2Ah0mo9Z29823ga0OtNM4I9u+qyWocBE3eclXeFR/BXMWWqq3b8Lzmd7gkimGM8wV4BaGQrH0yxE3waGjh8FnmKIJTrhHueVwdu0n0lE+V8cq4yle8TJzrnTNurKg11ztVdxfFUnVtY8ty1DMWGFdeTH0zix7gAyLjzwnyz7e6nQJfQRkJNQD3yTl905uESA0Z2Kq5cJSjYXR25koclOW6mLX1RbQGHX+klOW9uOia/oA1yUzfP8hATzjOsX5aiz/tFB3Pa6DTmtHk/hQ==; 25:mdXQrAtXhynWpQVgEst3r1JIoRFHcwEG/yZ6ZiKbPFebuk2dpsDj9p4NN0RSfGVaa5H888eymSG0uyFLKIeWbdyvgdW2g9HVM9rA1ugUJmXKp7oD90ZDciePD68k2PSAFZ2dWGBY51Yxj5DqdW+UInBmJvwj6R2JSGtOVBlsrY+GH8ZJ7Jt9PkXBk23rg0TJBMK5BmrUJBJiUDoFeRBkutpvxtyF0RSsOoWzAbTGQy8hlEAhCUGFj/34NaHCk6U5S4QyYx5DgEcLJafct8TDPTkZOOcM3st0f0hKDlEyP6GTJNMfwwLxPLCVCMiszkyTRwu9bk8pDZe0ovjK2ZWj2hXOuYAJjFq5ojc1K4grrgu1vk0MNLjvegYbieHsKlF2kbSTIJWyIO+32MQgrHfmccmFBSE7r5oQDs3X8cFkHi+uj08AW/yzkGTwwTIdCxBaJXl2PeUZMVjar0SNfrGInHRRB6uwm8zmeh1fwUBW/OA= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3072; 31:j9ZOtgDTdVrN60LdPfKLzDk58HFPoSmNv29/hoJANNub4giKJ1RakTmSC7jL88HhRXipqUoC1d6d3CmYNpPEoRwM7d0UEQQq3z8CHp0+IOp5ZLH6WWsqqrvH1JbwMc/JlDF9Rer5wBIg/8rbs1Ts0o/a9kzM+2v7aRAxCXfyEa6Dpdgu8kDhL0IeHbWiuRkCJNbLbGvp7Zc+kI3gwXGngGBmmezpx/93Vx/qyXMfvO0JJ0rVsBlj2HfbOg5pzwaT; 20:JqrCFjWadMDXPBb7fR30sW+heFzBgY0qn2v3oZILzEXRZdrXvCHR1Z/LcjFmFqa44A3jfFUeK+BQYb3zWYoXY5BPkZwMxeBuZFGxdRIg6gYxsHJxY10nzJLY5hDlqGIT5q8ys63mzcvSmcuLbQtxrwhE31PTW+UdBmN8S1RexDn8dyMSc6Pn9+I9aTcdDN7Ob39fOQps5PScwlI8ASb6SZVIgbprvROBuVHOJ3ulW9t510ANzVKImrnQd4SP9nmOvZqLppbEeYvOJDivGFZsMs9OJf3MWI6rYpIpNSQKu7jkHM0VRYAMtAuDx43JhSEDh85EVp4hzKSiFyk6CxjgmO4UBeZBbynwSAtG5lR3qrOdSwSk4HnMC+kXXbPJ+rCzgh1BDlRbKLdl5alSOYlj2V06A6cSnblb9m97vtfKTYShomU37mzwORud5rVOYafZxIcnbmdjQAU3Q3Kr/5OyaFbDD9Anb9/f5r0pPVj74gJ9hQBMzDxa2aanpq1U+X5W7+FVfVslKbZs0jc0oLCOBRQ4AKA1s3yORN/2oM6YQly5w6pkWaKubCNrZkkls2w9FAOVOhZ+7PYG3D2P/if9lvKpBujDWbnz8jGDww5d7VM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(6041248)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3072; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3072; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3072; 4:LQeTQv/u9QjpuiZrzR/B24Nf9P2zUgI4mOK/wVwAc8?= udx3P7o5EDW6h2+ufRABULGEXdTx0ynUcy6CCs0yvTl9qFMGWoLbfhdaNl526H854tUChJ43O8kGRttqhV7m1AW8xm02dZB9FR41O81Y/YA7xDV5/jy3roH+xW4IHRQNoG+1ntHtD3OW4mtE4m9kmTMCJOFiG6sVTw0n5eU169W7FBh9TQDrCvXEzqQ2WMeHATD0OreDs+q0Xz/XHL1eQpdyXvr/6SThWT7J7EiGbK57CwtEZaIFjuDwBCUqvYtXpnhHiIdLnrxL35tAQXXT4XeiUUKZzIfD3wkrXDvkWYByeTYm8cEI0gF4IYr/U0YCo3uKe5SYhvCte5dF5LYkQYeQpyA9XTrH1uYY/LaZYc1xqfqAScHrycD5vy5ofNCge6WFSJdlpBdmiKgWo2FKm/bFiwUS7Ob8F2pWW7igK8mQ8VoXKyzw3yKqOmVjS3dQWx+FFqXED/9LsIJcU6WPx7touDe3a7QXHdAo0o03lkvweBME2ha3BN3r0eQD6AMFkhiWElfICtKD0kYHYE73jdnPIuLnjp7YZIkbLdnw9D06sFsN6YI1aJaSbHV4vt+95DkZGgfpfuaYY4dU67HO/53FYcLtcxRfQFPL1JsXh51/Zg9cvVP5/4G5QEajgwyuHJxuDU3+ry9F6nvun0p/IYFunJzGNmCEXSNJ8BoMt430SQAw0zyDXfbD+xGyWxfkeI+qhqh2LmzzEYL3F3p6sSSSdCXzBxyqmT1r2HOe4LSFS3dheOVHHE3LEIxc2WCKr5Hvgv8TZhmboFIvAsuSL0voDZX/G5FGgr99vrGyXvh7y1lyG0SxMIXvxIwJVofIrGmrRg5ddh9LEr3C1Jz2MEZjtqJ62/Aa+Z/yWSDlSVbhbWPggi5GkPtKDZ802JKjavcDlzUoWVtjvC9sxDpw1ArCJ+CluQx8woKxDeR7eHqCqboL8borilSDn4A1T1O4fTo4ZoWF3ZHe+ppFZfhE2WhYC+HAfdHjmXcqh7++EKaT6agjVu2RqO0Bwvv90c1lNLGA+yXQei8OOrAVmVSpCAoQNErPgXjK0iKrRu0WObRjHBwlz6/Dd4lR7risNoQ2E= X-Forefront-PRVS: 033054F29A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39400400002)(39850400002)(39840400002)(39450400003)(6506006)(42882006)(6916009)(5660300001)(42186005)(2361001)(4720700003)(25786009)(7736002)(305945005)(33646002)(2351001)(48376002)(6486002)(6666003)(53936002)(5003940100001)(38730400002)(6116002)(3846002)(47776003)(478600001)(110136004)(50466002)(6512007)(66066001)(81166006)(72206003)(50226002)(2906002)(50986999)(5009440100003)(36756003)(189998001)(8676002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3072; H:lio357.in.caveonetworks.com; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3072; 23:tOimqSjgS83qdOOgvEOw0W3NgiDuHQKdi/n4pUAdD?= UrwqWmTmu8CN3kabylcoNV/KoUwQ7CW92Oz2Y6fxanQbdaEZ05WOxZmAbmxX0pRzzA3sfmccV1txhkBTMrRHus0K1/y+0M2chtnbB5hkBxKdLPkAFtRQyjPT5ld7xdRU4P0VyoYtWf75fAxqIfcmVkrH9zGC3AvXDhHRhSUfRVEbiXplf6/Av8YuHfmy9GuHoUA8WDYJzHChCXJ42GWDCfbPvP7jvB3rG+lKWI7Sh5qE2KSO71RoHEkjwG45Y3Rma3SZy9iAL1zlM4F+dgL7XajVkAWB2haqUOLLc5pxPxddgPRccStD5Z2rYvdOy9l1zdEbLD4T2yca82pEPkNrr//Tigen73Nt/CJu8sikgFkzRVyoiPy55RbUuKGLw69sa/1QnpLlK11RjaLRg4a1N2vLIwfg1c48OHXyl87Q67oAi/nb82U6efw/MIJ5fcH/yE9rKzrz5Jg0EMfTb/KGQyQVx5ZFEJrWQ1oDYOKVwFFm4Jqnf3GpOvKo7ts0jJ2wDjFVscJvZFTWmXWMRqNB+ti52ggzJeriLjsjgdkm9hrOuEpapW1uI9EkvY1ppdhOdi7Ys051Mu2gEbKZO9weZ/MLVpEKmRQuHzHHmM6Jn3ssTUDQ1GCI40iN5vHGPOQd1FAYxNa8pc8fGi5DlQY1Q3WWUi9oer4PyRgvsGST1xiIEuB0LcJPJbbLGfnkjw5PJ3hrmxpFGDBrjLMaK2TDid/P03KU5ef1FvDAgGoLtPqoSS0GHYSayK4RkOBF7x2VbiZXyYv+n0zGhnBQRcHRcr/44gzcA97w/2sWylZ/y+lw13HC9AzRsDC1XjlH4AKDCYZp+EMjrr/962Xmemhsqq7RsFfLyHxayvC8i72R1SpJ2U4NoiuRhrrN7l5X55Bcsxm8qIcSUF5pYi79OQb0iXVUADQ4SVZCD1Q1KHzFXLU8PcmrRzVEPBPaTOl6rWwdjrZbnx+zoe1K9V/JrOYR+yjxK7v4j26bvv/1dG/myu4jSwHmpZ+EJ0zmUjRJItyVnOF7mXTZ2+vJInLKp0faFyzPOD3c2wKvQchh2SSDzH+Jg== X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3072; 6:7/wpmWdXJX1TdqnqAVQfc4piHUzixgsyLTZFP5Cy9pdHkymrB5nZ57+umujDihbyiSxHUsmmxXmYSZ98ZGyXdsHHxSELzXwh8r44l+TCsrcSkq9/kkMv2JsMMoiWfFqeenHwBj5XbigMF52mACc20h2Hxox1OV7dGSacECCeQn3c1dnu0oBt2RswX0j3WsSyeRiQjtYtEoeS5fv7Fs8e1S70OlzxBHJ4CJJGh5IPH8jRYT4uFTw18MPTw230njHRi/KirqZOrHDwM6sI8DSBpOBNeigat6a+yXkvfOOqEH2yQvN7GvSOBxcdh7aVmrcU/zBaf9a/R3zx7SfAaLluHfrh5VmNnMjdK99ZRW1+wjpce3ysvCg8KZf3AuHJFz66kZEXbPvZHaJQxTVlBSFqiACSucvOth9i1jknKBjwG1E2WQHaief0+za7NSA+1l2cgfTiUupPq6wMZAOHLzXB5nh0nUogEMCOy19Ui3uM2OLPn/L8arrmrRKG6SPhCAAjxQB4Wmkz7/3TiOd63Cnsdw== X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3072; 5:Lhwy6IxgdpJfjmZQ+rXuYdKIxCU374usA4t/3/E5Cew97M9Ip4ffvIjUtrvYDSifp0cVEVTkxr8kZ19PzhYPGirwBpXqj37URt8PBvUR8Qc25xk2ZjbuOyADW6oRMWXUXmL8NwqP3JUPKM7lKQBwooPaBOZGlRMFrrLRYKFuQiUXvqRuSTPFgRxy79C1ml2dQHLep702dlGV1MmeqwANvP126Wj+HDj/09qI370Po6R265HqMmxahBL6THF9SzZHU1RgkP9IvrRQPgIzECbZFN4F12eD1QY/UNNJSya5S0idCE+FznbOwoAPzrErLP/MVzCaWDh9gnBQNpvrhlDTfB+rTuMP48F1/MGMfzV6wI1UuFlL0pK4JSKuG1sCXEorS+XnzADYkQAeBq5dHmvFjs5gk7nKSWm8W2KUqi0qUHZ5fvlMdrxdYp7GJZMOdEeFgBpOiFlJbkcvMsY/m+xVwADPGjPGIkq7FbBqmBX5ZzxvXaxa5+hdiDA9hqdm+gLJ; 24:Bc49tcmTgsHhGuUb0m7vz+EdI4gFGk9ybQJcuExdJvqhAHEnMFDzGQriK30YMt95E0QwINWuEYhL+ZgvbXo8fwEBsKdU8GTwG8XF396YsRo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3072; 7:zIxvs18pflriJGjnqc5IL6U9mrAJorR6s4Tz7fcGd1fDKQcgKRtmHVnHNeA5wLf6wK1TPubH3W709+i9Fye5ZDQafgrhjaGSNAbWOKln9xQ7i0TwYWZu2G9BiTbP0+3Jh00mn9cN2dXD45p91tD9xSV0gSiWzzWgkQdELpzF2m58NcJd8P3/uaFDj1Xze7X3c4H7RKVLxBMu23waBL6ESW/DpKuIoJSV+2k6lQkU5OqCCXEO4Ou2rtTu1ormdmKWTKUf8G9Raf2M36DeS+YXAqxeeUwMKRiMCBK+Oo9CVusWOu28NY+PJduiCQUR236rQoa1P6ZQh0Aa9kx0zRJMHg== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2017 11:04:59.9541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3072 Subject: [dpdk-dev] [PATCH] net/liquidio: fix MTU calculation from port configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" max_rx_pkt_len member of port RX configuration indicates max frame length. Ethernet header and CRC length should be subtracted from it to find MTU. Fixes: 605164c8e79d ("net/liquidio: add API to validate VF MTU") Signed-off-by: Shijith Thotton --- drivers/net/liquidio/lio_ethdev.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 436d25b..61946ac 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -36,6 +36,7 @@ #include #include #include +#include #include "lio_logs.h" #include "lio_23xx_vf.h" @@ -1348,7 +1349,8 @@ struct rte_lio_xstats_name_off { static int lio_dev_start(struct rte_eth_dev *eth_dev) { - uint16_t mtu = eth_dev->data->dev_conf.rxmode.max_rx_pkt_len; + uint16_t mtu; + uint32_t frame_len = eth_dev->data->dev_conf.rxmode.max_rx_pkt_len; struct lio_device *lio_dev = LIO_DEV(eth_dev); uint16_t timeout = LIO_MAX_CMD_TIMEOUT; int ret = 0; @@ -1386,12 +1388,29 @@ struct rte_lio_xstats_name_off { goto dev_mtu_check_error; } + if (eth_dev->data->dev_conf.rxmode.jumbo_frame == 1) { + if (frame_len <= ETHER_MAX_LEN || + frame_len > LIO_MAX_RX_PKTLEN) { + lio_dev_err(lio_dev, "max packet length should be >= %d and < %d when jumbo frame is enabled\n", + ETHER_MAX_LEN, LIO_MAX_RX_PKTLEN); + ret = -EINVAL; + goto dev_mtu_check_error; + } + mtu = (uint16_t)(frame_len - ETHER_HDR_LEN - ETHER_CRC_LEN); + } else { + /* default MTU */ + mtu = ETHER_MTU; + eth_dev->data->dev_conf.rxmode.max_rx_pkt_len = ETHER_MAX_LEN; + } + if (lio_dev->linfo.link.s.mtu != mtu) { ret = lio_dev_validate_vf_mtu(eth_dev, mtu); if (ret) goto dev_mtu_check_error; } + eth_dev->data->mtu = mtu; + return 0; dev_mtu_check_error: