[dpdk-dev] test: fix the parameter issue of test case

  When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
should be toggled according to the test name.

Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
 test/test/test_link_bonding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

On 13 July 2017 at 16:00, Herbert Guan <herbert.guan@arm.com> wrote:
> When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> should be toggled according to the test name.
>
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
>  test/test/test_link_bonding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> index aa2a1a2..12dd91d 100644
> --- a/test/test/test_link_bonding.c
> +++ b/test/test/test_link_bonding.c
> @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
>  static int
>  test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
>  {
> -       return balance_l23_tx_burst(0, 1, 1, 0);
> +       return balance_l23_tx_burst(0, 1, 0, 1);
>  }
>
>  static int
> --
> 1.8.3.1
>

Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
  

Declan, you are the bonding maintainer, please confirm this fix.

13/07/2017 11:48, Jianbo Liu:
> On 13 July 2017 at 16:00, Herbert Guan <herbert.guan@arm.com> wrote:
> > When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> > calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> > should be toggled according to the test name.
> >
> > Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> > ---
> >  test/test/test_link_bonding.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> > index aa2a1a2..12dd91d 100644
> > --- a/test/test/test_link_bonding.c
> > +++ b/test/test/test_link_bonding.c
> > @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
> >  static int
> >  test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
> >  {
> > -       return balance_l23_tx_burst(0, 1, 1, 0);
> > +       return balance_l23_tx_burst(0, 1, 0, 1);
> >  }
> >
> >  static int
> > --
> > 1.8.3.1
> >
> 
> Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
>
  

On 13/07/2017 9:00 AM, Herbert Guan wrote:
> When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> should be toggled according to the test name.
>
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
>  test/test/test_link_bonding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> index aa2a1a2..12dd91d 100644
> --- a/test/test/test_link_bonding.c
> +++ b/test/test/test_link_bonding.c
> @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
>  static int
>  test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
>  {
> -	return balance_l23_tx_burst(0, 1, 1, 0);
> +	return balance_l23_tx_burst(0, 1, 0, 1);
>  }
>
>  static int
>

Acked-by: Declan Doherty <declan.doherty@intel.com>
  

On 7/25/2017 10:46 AM, Declan Doherty wrote:
> On 13/07/2017 9:00 AM, Herbert Guan wrote:
>> When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
>> calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
>> should be toggled according to the test name.

Fixes: 92073ef961ee ("bond: unit tests")
Cc: stable@dpdk.org

>>
>> Signed-off-by: Herbert Guan <herbert.guan@arm.com>

Acked-by: Jianbo Liu <jianbo.liu@linaro.org>

> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied to dpdk-next-net/master, thanks.