diff mbox

[dpdk-dev] mempool/dpaa2: alloc pool data dynamically

Message ID 1499955528-32012-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal July 13, 2017, 2:18 p.m. UTC 
  In order to support multiprocess applications, pool data is to be
allocated on dynamic memory instead of existing usages of global
variable.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Shreyansh Jain July 18, 2017, 2:45 p.m. UTC | #1 
On Thursday 13 July 2017 07:48 PM, Hemant Agrawal wrote:
> In order to support multiprocess applications, pool data is to be
> allocated on dynamic memory instead of existing usages of global
> variable.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Thomas Monjalon July 21, 2017, 6:15 a.m. UTC | #2 
18/07/2017 17:45, Shreyansh Jain:
> On Thursday 13 July 2017 07:48 PM, Hemant Agrawal wrote:
> > In order to support multiprocess applications, pool data is to be
> > allocated on dynamic memory instead of existing usages of global
> > variable.
> > 
> > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
index d578c2f..ad48709 100644
--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
@@ -63,6 +63,7 @@  rte_hw_mbuf_create_pool(struct rte_mempool *mp)
 {
 	struct dpaa2_bp_list *bp_list;
 	struct dpaa2_dpbp_dev *avail_dpbp;
+	struct dpaa2_bp_info *bp_info;
 	struct dpbp_attr dpbp_attr;
 	uint32_t bpid;
 	int ret, p_ret;
@@ -127,7 +128,12 @@  rte_hw_mbuf_create_pool(struct rte_mempool *mp)
 	rte_dpaa2_bpid_info[bpid].bp_list = bp_list;
 	rte_dpaa2_bpid_info[bpid].bpid = bpid;
 
-	mp->pool_data = (void *)&rte_dpaa2_bpid_info[bpid];
+	bp_info = rte_malloc(NULL,
+			     sizeof(struct dpaa2_bp_info),
+			     RTE_CACHE_LINE_SIZE);
+	rte_memcpy(bp_info, (void *)&rte_dpaa2_bpid_info[bpid],
+		   sizeof(struct dpaa2_bp_info));
+	mp->pool_data = (void *)bp_info;
 
 	PMD_INIT_LOG(DEBUG, "BP List created for bpid =%d", dpbp_attr.bpid);
 
@@ -169,6 +175,7 @@  rte_hw_mbuf_free_pool(struct rte_mempool *mp)
 		}
 	}
 
+	rte_free(mp->pool_data);
 	dpaa2_free_dpbp_dev(dpbp_node);
 }