diff mbox

[dpdk-dev,v2] net/i40e: add checking invalid VF queue id for FDIR

Message ID 1500015096-58857-1-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei July 14, 2017, 6:51 a.m. UTC 
  There's only invalid queue id checking for PF when creating FDIR
rules, this patch adds checking invalid queue id for VF.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
v2 changes:
 - rework commit log.

 drivers/net/i40e/i40e_flow.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit July 18, 2017, 10:23 a.m. UTC | #1 
On 7/14/2017 7:51 AM, Beilei Xing wrote:
> There's only invalid queue id checking for PF when creating FDIR
> rules, this patch adds checking invalid queue id for VF.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 93ecee2..95af701 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -2846,7 +2846,10 @@  i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
 	case RTE_FLOW_ACTION_TYPE_QUEUE:
 		act_q = (const struct rte_flow_action_queue *)act->conf;
 		filter->action.rx_queue = act_q->index;
-		if (filter->action.rx_queue >= pf->dev_data->nb_rx_queues) {
+		if ((!filter->input.flow_ext.is_vf &&
+		     filter->action.rx_queue >= pf->dev_data->nb_rx_queues) ||
+		    (filter->input.flow_ext.is_vf &&
+		     filter->action.rx_queue >= pf->vf_nb_qps)) {
 			rte_flow_error_set(error, EINVAL,
 					   RTE_FLOW_ERROR_TYPE_ACTION, act,
 					   "Invalid queue ID for FDIR.");