From patchwork Tue Jul 18 15:40:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 27036 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9AB5F7CAA; Tue, 18 Jul 2017 17:41:58 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 673C8532C for ; Tue, 18 Jul 2017 17:41:46 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 08:41:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="994343834" Received: from dpdk25.sh.intel.com ([10.67.111.96]) by orsmga003.jf.intel.com with ESMTP; 18 Jul 2017 08:41:44 -0700 From: Tiwei Bie To: dev@dpdk.org, jfreiman@redhat.com Date: Tue, 18 Jul 2017 23:40:19 +0800 Message-Id: <1500392421-76672-5-git-send-email-tiwei.bie@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500392421-76672-1-git-send-email-tiwei.bie@intel.com> References: <1500392421-76672-1-git-send-email-tiwei.bie@intel.com> Subject: [dpdk-dev] [RFC 4/6] net/virtio: revert the changes in 18dc1b1ac X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Revert the changes in 18dc1b1ac, because we want to test the performance similar to the real world case. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 3983626..7be9aae 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -139,9 +139,7 @@ virtqueue_dequeue_burst_rx(struct virtqueue *vq, struct rte_mbuf **rx_pkts, } rte_prefetch0(cookie); -#if 0 rte_packet_prefetch(rte_pktmbuf_mtod(cookie, void *)); -#endif rx_pkts[i] = cookie; vq->vq_used_cons_idx++; vq_ring_free_chain(vq, desc_idx); @@ -512,9 +510,7 @@ static void virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) { uint32_t s = mbuf->pkt_len; -#if 0 struct ether_addr *ea; -#endif if (s == 64) { stats->size_bins[1]++; @@ -533,7 +529,6 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) stats->size_bins[7]++; } -#if 0 ea = rte_pktmbuf_mtod(mbuf, struct ether_addr *); if (is_multicast_ether_addr(ea)) { if (is_broadcast_ether_addr(ea)) @@ -541,7 +536,6 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) else stats->multicast++; } -#endif } /* Optionally fill offload information in structure */ @@ -664,6 +658,9 @@ virtio_recv_pkts_1_1(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts dxp = &vq->vq_descx[used_idx & (vq->vq_nentries - 1)]; + rte_packet_prefetch(rte_pktmbuf_mtod( + (struct rte_mbuf *)dxp->cookie, void *)); + len = desc->len; rxm = dxp->cookie; dxp->cookie = nmb;