[dpdk-dev,v2] net/i40e: fix sync phy type by adding retry
Checks
Commit Message
Some phy's take longer than others to come up. Add a retry to give
more phy's a chance to come up before returning an error.
Fixes: 2209c3e2c275 ("net/i40e: avoid PCI probing failure when using bogus SFP")
Signed-off-by: David Hunt <david.hunt@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
Comments
> -----Original Message-----
> From: Hunt, David
> Sent: Monday, July 24, 2017 4:49 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org; Hunt, David
> <david.hunt@intel.com>
> Subject: [PATCH v2] net/i40e: fix sync phy type by adding retry
>
> Some phy's take longer than others to come up. Add a retry to give more phy's
> a chance to come up before returning an error.
>
> Fixes: 2209c3e2c275 ("net/i40e: avoid PCI probing failure when using bogus
> SFP")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
On 7/27/2017 1:28 AM, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Hunt, David
>> Sent: Monday, July 24, 2017 4:49 PM
>> To: dev@dpdk.org
>> Cc: Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org; Hunt, David
>> <david.hunt@intel.com>
>> Subject: [PATCH v2] net/i40e: fix sync phy type by adding retry
>>
>> Some phy's take longer than others to come up. Add a retry to give more phy's
>> a chance to come up before returning an error.
>>
>> Fixes: 2209c3e2c275 ("net/i40e: avoid PCI probing failure when using bogus
>> SFP")
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -9248,16 +9248,22 @@ i40e_dev_sync_phy_type(struct i40e_hw *hw)
enum i40e_status_code status;
struct i40e_aq_get_phy_abilities_resp phy_ab;
int ret = -ENOTSUP;
+ int retries = 0;
status = i40e_aq_get_phy_capabilities(hw, false, true, &phy_ab,
NULL);
- if (status) {
+ while (status) {
PMD_INIT_LOG(WARNING, "Failed to sync phy type: status=%d",
status);
- return ret;
+ retries++;
+ rte_delay_us(100000);
+ if (retries < 5)
+ status = i40e_aq_get_phy_capabilities(hw, false,
+ true, &phy_ab, NULL);
+ else
+ return ret;
}
-
return 0;
}