diff mbox

[dpdk-dev,v3] eal: disable NUMA related warnings on non-NUMA systems

Message ID 1500888027-20539-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal July 24, 2017, 9:20 a.m. UTC 
  Disable multiple NUMA warnings on non-NUMA systems.

"EAL: eal_parse_sysfs_value(): cannot open sysfs value
	/sys/bus/pci/devices/0000:00:00.0/numa_node
EAL: numa_node is invalid or not present. Set it 0 as default
EAL: cannot open /proc/self/numa_maps, consider that all memory is
	in socket_id 0"

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
v3: fix checkpatch error
v2: convert check to run time for NUMA systems

 lib/librte_eal/linuxapp/eal/eal_memory.c |  4 ++--
 lib/librte_eal/linuxapp/eal/eal_pci.c    | 12 ++++++++----
 2 files changed, 10 insertions(+), 6 deletions(-)

Comments

Jerin Jacob July 24, 2017, 9:45 a.m. UTC | #1 
-----Original Message-----
> Date: Mon, 24 Jul 2017 14:50:27 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: thomas@monjalon.net
> CC: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] eal: disable NUMA related warnings on
>  non-NUMA systems
> X-Mailer: git-send-email 2.7.4
> 
> Disable multiple NUMA warnings on non-NUMA systems.
> 
> "EAL: eal_parse_sysfs_value(): cannot open sysfs value
> 	/sys/bus/pci/devices/0000:00:00.0/numa_node
> EAL: numa_node is invalid or not present. Set it 0 as default
> EAL: cannot open /proc/self/numa_maps, consider that all memory is
> 	in socket_id 0"
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Thomas Monjalon July 30, 2017, 9:29 p.m. UTC | #2 
> > Disable multiple NUMA warnings on non-NUMA systems.
> > 
> > "EAL: eal_parse_sysfs_value(): cannot open sysfs value
> > 	/sys/bus/pci/devices/0000:00:00.0/numa_node
> > EAL: numa_node is invalid or not present. Set it 0 as default
> > EAL: cannot open /proc/self/numa_maps, consider that all memory is
> > 	in socket_id 0"
> > 
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index daead31..5279128 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -610,8 +610,8 @@  find_numasocket(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)
 
 	f = fopen("/proc/self/numa_maps", "r");
 	if (f == NULL) {
-		RTE_LOG(NOTICE, EAL, "cannot open /proc/self/numa_maps,"
-				" consider that all memory is in socket_id 0\n");
+		RTE_LOG(NOTICE, EAL, "NUMA support not available"
+			" consider that all memory is in socket_id 0\n");
 		return 0;
 	}
 
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 2041d5f..8951ce7 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -314,10 +314,14 @@  pci_scan_one(const char *dirname, const struct rte_pci_addr *addr)
 	snprintf(filename, sizeof(filename), "%s/numa_node",
 		 dirname);
 
-	if (eal_parse_sysfs_value(filename, &tmp) == 0)
-		dev->device.numa_node = tmp;
-	else
-		dev->device.numa_node = -1;
+	if (access(filename, F_OK) != -1) {
+		if (eal_parse_sysfs_value(filename, &tmp) == 0)
+			dev->device.numa_node = tmp;
+		else
+			dev->device.numa_node = -1;
+	} else {
+		dev->device.numa_node = 0;
+	}
 
 	pci_name_set(dev);