diff mbox series

[v2,073/148] net/ice/base: remove unused define

Message ID	1501489afc404eb1096945a977c4a8439b9796a0.1718204528.git.anatoly.burakov@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Bruce Richardson
Headers	From: Anatoly Burakov <anatoly.burakov@intel.com> To: dev@dpdk.org Cc: Ian Stokes <ian.stokes@intel.com>, bruce.richardson@intel.com, Dave Ertman <david.m.ertman@intel.com> Subject: [PATCH v2 073/148] net/ice/base: remove unused define Date: Wed, 12 Jun 2024 16:01:07 +0100 Message-ID: <1501489afc404eb1096945a977c4a8439b9796a0.1718204528.git.anatoly.burakov@intel.com> In-Reply-To: <cover.1718204528.git.anatoly.burakov@intel.com> References: <20240430154014.1026-1-ian.stokes@intel.com> <cover.1718204528.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Update net/ice base driver to latest upstream snapshot \| [v2,000/148] Update net/ice base driver to latest upstream snapshot [v2,001/148] net/ice/base: convert enum ice_status to int [v2,002/148] net/ice/base: replace ICE_SUCCESS with int [v2,003/148] net/ice/base: update E830 headers [v2,004/148] net/ice/base: update phy config during link restart [v2,005/148] net/ice/base: fix for pointer to variable outside scope [v2,006/148] net/ice/base: add missing include for flow [v2,007/148] net/ice/base: add ability to set markid via switch filter [v2,008/148] net/ice/base: improve ice_debug_cq messages [v2,009/148] net/ice/base: add mgmt netlist auth support command [v2,010/148] net/ice/base: fix undefined variables [v2,011/148] net/ice/base: fix get media type [v2,012/148] net/ice/base: clean up __ice_aq_get_set_rss_lut() [v2,013/148] net/ice/base: update flow seg fields to declared bitmaps [v2,014/148] net/ice/base: update interface in ice_parse_common_caps [v2,015/148] net/ice/base: refactor (non) bitmap declarations [v2,016/148] net/ice/base: remove unnecessary control queue cmd_buf arrays [v2,017/148] net/ice/base: alloc port_info only once [v2,018/148] net/ice/base: update code with flex array safe allocations [v2,019/148] net/ice/base: bring back ability to use 128 as size of PF type RSS LUT [v2,020/148] net/ice/base: support for OROM update in recovery mode [v2,021/148] net/ice/base: code adjustments for E830 [v2,022/148] net/ice/base: improve find recipe routine [v2,023/148] net/ice/base: fix memory leak when checking firmware version [v2,024/148] net/ice/base: add LL Tx timestamp interrupt read [v2,025/148] net/ice/base: use model-dependent number of PHY ports [v2,026/148] net/ice/base: use ice_bitmap_t in promisc functions [v2,027/148] net/ice/base: fix rx-only unicast promiscuous mode [v2,028/148] net/ice/base: add support for E825-C TX clock changing [v2,029/148] net/ice/base: fix for applying multiple cloud filters [v2,030/148] net/ice/base: limit PF RSS LUT to one VSI at time [v2,031/148] net/ice/base: prevent potential integer overflow [v2,032/148] net/ice/base: cosmetic changes [v2,033/148] net/ice/base: implement initial PTP support for E830 [v2,034/148] net/ice/base: fix resource leak [v2,035/148] net/ice/base: move lock outside of if-else [v2,036/148] net/ice/base: refactor control queue send delay [v2,037/148] net/ice/base: fix NVM feature check [v2,038/148] net/ice/base: allow for dumping all clusters [v2,039/148] net/ice/base: remove PTP aqc_driver_params [v2,040/148] net/ice/base: add FW load status mask [v2,041/148] net/ice/base: add direction metadata [v2,042/148] net/ice/base: change data buffer in i2c write to be const [v2,043/148] net/ice/base: remove unused code from upstream build [v2,044/148] net/ice/base: fix sign-extension [v2,045/148] net/ice/base: implement switch recipe reuse feature [v2,046/148] net/ice/base: add helper function for refsync [v2,047/148] net/ice/base: added informational message for NAC topology [v2,048/148] net/ice/base: add Cage Max Power override NVM module [v2,049/148] net/ice/base: adapt No FEC in Auto support check to add E82X devices [v2,050/148] net/ice/base: move (read\|write)_sma_ctrl functions to match upstream [v2,051/148] net/ice/base: fix incorrect size when allocating children arrays [v2,052/148] net/ice/base: fix GCS descriptor field offsets [v2,053/148] net/ice/base: add VSI type for subfunctions [v2,054/148] net/ice/base: correct the return type of ice_bitmap_hweight [v2,055/148] net/ice/base: fix ice_ptp_one_port_cmd to avoid stale PHY commands [v2,056/148] net/ice/base: remove dead code from ice_get_ddp_pkg_state [v2,057/148] net/ice/base: get rid of enum ice_status [v2,058/148] net/ice/base: use ICE_PTP_NOP to better indicate no action [v2,059/148] net/ice/base: add fw log file [v2,060/148] net/ice/base: update comments regarding clearing timestamps [v2,061/148] net/ice/base: use "err" instead of "status" in ice_ptp_hw.c [v2,062/148] net/ice/base: re-number E810-T subdevice IDs to match upstream [v2,063/148] net/ice/base: enable RDMA Act-Act unload paths [v2,064/148] net/ice/base: parse 1PPS GPIO in 1588 function caps [v2,065/148] net/ice/base: rename netlist check functions to match upstream [v2,066/148] net/ice/base: fix check for existing switch rule [v2,067/148] net/ice/base: fall back to safe CGU params [v2,068/148] net/ice/base: change tmr_idx to u32 [v2,069/148] net/ice/base: be more verbose when preparing timer sync [v2,070/148] net/ice/base: be more verbose in configuring Rx timestamp offset [v2,071/148] net/ice/base: match code style to upstream [v2,072/148] net/ice/base: update strict status when assigning BW limits [v2,073/148] net/ice/base: remove unused define [v2,074/148] net/ice/base: improve read retry value calculation [v2,075/148] net/ice/base: check if recipe buffer was already allocated [v2,076/148] net/ice/base: fix handling recipes when reusing is not supported [v2,077/148] net/ice/base: use correct type [v2,078/148] net/ice/base: read OROM in a loop [v2,079/148] net/ice/base: ignore snprintf return value [v2,080/148] net/ice/base: check array bounds [v2,081/148] net/ice/base: copy output IO params from command descriptor [v2,082/148] net/ice/base: enable Next Cluster ID capability [v2,083/148] net/ice/base: fix potential TLV length overflow [v2,084/148] net/ice/base: add function to read SDP section from NVM [v2,085/148] net/ice/base: add Floating VEB support [v2,086/148] net/ice/base: add defines for loopback mode [v2,087/148] net/ice/base: allow skipping PF clear [v2,088/148] net/ice/base: fix in the definition of the Board Type [v2,089/148] net/ice/base : make ice_clear_vsi_q_ctx() non-static [v2,090/148] net/ice/base: fix package download algorithm [v2,091/148] net/ice/base: allows packages with mixed signature presence [v2,092/148] net/ice/base: fix ice_memcpy type specifiers [v2,093/148] net/ice/base: allow different FW API versions based on MAC type [v2,094/148] net/ice/base: add 32 GT bus speed enumerated value [v2,095/148] net/ice/base: add E830 debug dump cluster ID values [v2,096/148] net/ice/base: fix for preparing PHY for timesync command [v2,097/148] net/ice/base: support for firmware sanitization [v2,098/148] net/ice/base: add 200G speeds to PHY types decoding [v2,099/148] net/ice/base: temporary workaround for E830 signed package support [v2,100/148] net/ice/base: add PHY OFFSET_READY register clearing [v2,101/148] net/ice/base: rename PHY model designator fields and functions [v2,102/148] net/ice/base: enable SB access explicitly before 1st PHY access [v2,103/148] net/ice/base: refactor ETH56G PHY initialization [v2,104/148] net/ice/base: refactor ETH56G support for miltiple PHYs per MAC [v2,105/148] net/ice/base: implement interface to reset timestamp memory [v2,106/148] net/ice/base: fix iterations over PTP ports [v2,107/148] net/ice/base: return high address for multi-read eth56g registers [v2,108/148] net/ice/base: add function to read Tx timestamp status register [v2,109/148] net/ice/base: implement upper-level PHY control functions [v2,110/148] net/ice/base: squash multiple fixes for e56g device [v2,111/148] net/ice/base: add PHY statistics dump [v2,112/148] net/ice/base: move ice_ptp_init_phy_model to align with upstream [v2,113/148] net/ice/base: add Get Link Status Data version 2 [v2,114/148] net/ice/base: add port option commands [v2,115/148] net/ice/base: merge unified E830 headers [v2,116/148] net/ice/base: replace array initialization with macros [v2,117/148] net/ice/base: switch speed conversions to static lookups [v2,118/148] net/ice/base: support E830 in DDP pkg handling [v2,119/148] net/ice/base: support E830 in Topology AQ command [v2,120/148] net/ice/base: add E830 PTP init [v2,121/148] net/ice/base: allow skipping main timer programming [v2,122/148] net/ice/base: add missing files for shared code update [v2,123/148] net/ice/base: align code to upstream [v2,124/148] net/ice/base: use const char* array for storing link modes [v2,125/148] net/ice/base: fix compile issues on some targets [v2,126/148] net/ice/base: move code to common headers [v2,127/148] net/ice/base: make some switch-related functions static [v2,128/148] net/ice/base: add support for L2TP on switch [v2,129/148] net/ice/base: add L2TPv3 support for adv rules [v2,130/148] net/ice/base: detect and store device sensor reading capability [v2,131/148] net/ice/base: add missing defines and misc cleanup [v2,132/148] net/ice/base: increase PF reset wait timeout to 500 milliseconds [v2,133/148] net/ice/base: fix memcpy type [v2,134/148] net/ice/base: too big a timeout for QV diagnostic tests [v2,135/148] net/ice/base: fix ice_get_ctx() issue [v2,136/148] net/ice/base: add AQ function to configure SyncE error reporting [v2,137/148] net/ice/base: support DCF query port ETS adminq [v2,138/148] net/ice/base: update boost struct for traffic types [v2,139/148] net/ice/base: clean up ice_lan_tx_rx [v2,140/148] net/ice/base: enable CGU error reporting [v2,141/148] net/ice/base: cleanup timestamp registers correctly [v2,142/148] net/ice/base: rework multiple functions [v2,143/148] net/ice/base: change a method to get pca9575 handle [v2,144/148] net/ice/base: rename SMA register macros to match Linux upstream [v2,145/148] net/ice/base: introduce new functions in ice_sched_node [v2,146/148] net/ice/base: misc header file clean up [v2,147/148] net/ice: update rss lut value for RSS init [v2,148/148] net/ice: add new device ids

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues

Commit Message

Anatoly Burakov June 12, 2024, 3:01 p.m. UTC

From: Ian Stokes <ian.stokes@intel.com>

In a previous patch a define was added that is not used. This is causing issues
with CI builds.

Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---
 drivers/net/ice/base/ice_sched.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bruce Richardson June 20, 2024, 1:38 p.m. UTC | #1

On Wed, Jun 12, 2024 at 04:01:07PM +0100, Anatoly Burakov wrote:
> From: Ian Stokes <ian.stokes@intel.com>
> 
> In a previous patch a define was added that is not used. This is causing issues
> with CI builds.
> 
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
>  drivers/net/ice/base/ice_sched.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c
> index d39106173b..cb6131f69d 100644
> --- a/drivers/net/ice/base/ice_sched.c
> +++ b/drivers/net/ice/base/ice_sched.c
> @@ -4660,7 +4660,6 @@ ice_sched_save_tc_node_bw(struct ice_port_info *pi, u8 tc,
>  }
>  
>  #define ICE_SCHED_GENERIC_STRICT_MODE		BIT(4)
> -#define ICE_SCHED_GENERIC_PRIO_M		0xE
>  #define ICE_SCHED_GENERIC_PRIO_S		1
>  
This was just added in previous patch, p72, so quash 72 & 73 together for
v3.

diff mbox series

Patch

diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c
index d39106173b..cb6131f69d 100644
--- a/drivers/net/ice/base/ice_sched.c
+++ b/drivers/net/ice/base/ice_sched.c
@@ -4660,7 +4660,6 @@  ice_sched_save_tc_node_bw(struct ice_port_info *pi, u8 tc,
 }
 
 #define ICE_SCHED_GENERIC_STRICT_MODE		BIT(4)
-#define ICE_SCHED_GENERIC_PRIO_M		0xE
 #define ICE_SCHED_GENERIC_PRIO_S		1
 
 /**