[dpdk-dev] doc: remove unnecessary deprecation announcement

Message ID 1501695251-2199-1-git-send-email-jianfeng.tan@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Jianfeng Tan Aug. 2, 2017, 5:34 p.m. UTC
  The original purpose of this deprecation is to make sure pci devices
are reset whenever DPDK apps crash. Since the
commit b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
from Shijith can fix this problem without deprecating anything, now there
is no need to deprecate iomem and ioport mapping in igb_uio.

Fixes: 3bac1dbc1ed5 ("doc: announce iomem and ioport removal from igb_uio")

Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 -----
 1 file changed, 5 deletions(-)
  

Comments

John McNamara Aug. 3, 2017, 10:43 a.m. UTC | #1
> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Wednesday, August 2, 2017 6:34 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; thomas@monjalon.net; Tan, Jianfeng
> <jianfeng.tan@intel.com>
> Subject: [PATCH] doc: remove unnecessary deprecation announcement
> 
> The original purpose of this deprecation is to make sure pci devices are
> reset whenever DPDK apps crash. Since the commit b58eedfc7dd5 ("igb_uio:
> issue FLR during open and release of device file") from Shijith can fix
> this problem without deprecating anything, now there is no need to
> deprecate iomem and ioport mapping in igb_uio.
> 
> Fixes: 3bac1dbc1ed5 ("doc: announce iomem and ioport removal from
> igb_uio")
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Thomas Monjalon Aug. 3, 2017, 11:36 p.m. UTC | #2
> > The original purpose of this deprecation is to make sure pci devices are
> > reset whenever DPDK apps crash. Since the commit b58eedfc7dd5 ("igb_uio:
> > issue FLR during open and release of device file") from Shijith can fix
> > this problem without deprecating anything, now there is no need to
> > deprecate iomem and ioport mapping in igb_uio.
> > 
> > Fixes: 3bac1dbc1ed5 ("doc: announce iomem and ioport removal from
> > igb_uio")
> > 
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index f6bd910..72aa404 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -23,11 +23,6 @@  Deprecation Notices
   Accompanying this evolution, device command line parameters will thus support
   explicit bus definition in a device declaration.
 
-* igb_uio: iomem mapping and sysfs files created for iomem and ioport in
-  igb_uio will be removed, because we are able to detect these from what Linux
-  has exposed, like the way we have done with uio-pci-generic. This change
-  targets release 17.05.
-
 * The VDEV subsystem will be converted as driver of the new bus model.
   It may imply some EAL API changes in 17.08.