From patchwork Tue Aug 15 06:59:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 27606 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C829C9129; Tue, 15 Aug 2017 08:59:49 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50045.outbound.protection.outlook.com [40.107.5.45]) by dpdk.org (Postfix) with ESMTP id 2608C9115; Tue, 15 Aug 2017 08:59:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=q7/haHCPS2tM5EkdArRi0KorCS7HoNgYIMMmDpOzUr4=; b=i3HZ2885j+jG3LAlIRmHPnrrOcXoNrBfUwf0rjKWX4B4MKqFgwphYOS3/JiXrH+HCjQocozeLZTlzY0zBo2DJI+wl+4oMfR1XHi21+fZyDABVGm0c8YHffqNbaTZTs0aaFKySHqNtdyu7xkUzwWDdowiKPfK681XRYvIlKgQuv8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR0502MB3053.eurprd05.prod.outlook.com (2603:10a6:800:b3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1341.21; Tue, 15 Aug 2017 06:59:45 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 15 Aug 2017 09:59:19 +0300 Message-Id: <1502780359-60553-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1P189CA0009.EURP189.PROD.OUTLOOK.COM (2603:10a6:802:2a::22) To VI1PR0502MB3053.eurprd05.prod.outlook.com (2603:10a6:800:b3::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6be69da-7e31-46d2-bb77-08d4e3ab36b1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR0502MB3053; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3053; 3:Bt+3neISqqf1k3dbEWDokIvwOcqi1efpnoPzZk3boEL6mCKKUC/fR2GUTyToHVeyNW9zIMB3dpzF3XG9TWRjqxhB/2PpaBM2NKuydJpsiMKP7s3W9oHUN4TwBuZ/tN/x1rRRBqRHOMv1GlIHH60L8LkHjxq8Apeqg85Z8nANzjD2C0UmjfCCFuIdMIBrP9UnSgWua0cnKKTNO7+FRj4LKjg4MSjTd/ul0laMXO0TkbYb8Pgiq2rxiBgeF91wEgk3; 25:Au7Iz/OqIbgLqQr/MMp5nt7iCKg2L4NSONTJVFMsXIUeeICDPlKgNMeZsaTDBa7sucdGHm7faSla35mhYc6plJEzMsCAYqduNGupvyfyq7KGv7W9bM603oUrxMG4YO8Gi/pn36ikInBfQ27pW6e9eGJ41x3X2x7zODFHc/lb6Q+vuV3whKnfiggp3h9hBIJaruOlvn0jLMOwWwM8km9iVhGt8/5kSMuuaxCyp2Hd6VAJIir3G25tHHPxbgKZFQPlH0Y51dGzwkPrw/z/eUpLa2xZlEELjzLc4VuxW1QzRkv8z++oYhxt1l2L30z8mBMWODZzxIKC+ItuuwEohMWXlQ==; 31:SrqrB7qqXUy6NDr9uiHvicmrTrIRhfSoexgJaoFmi74gyZDQvXW+RHKpZRPpl5NHPUNQHTCCG+7PTzAKaM+/ZY17C8u5g5kEBX+/JG0jKNrrzbHpcE62p3X53Hkz0pjNzKpFg7PZwyjGx1ctjUBLJslEBu8CuDDOGj1KSBbK/OdWVavkJ4ikW63yPwqYcoEoq2ZlwD1mPy0FHCQvSPY+BABxaGL2T4PAP1fev852iQA= X-MS-TrafficTypeDiagnostic: VI1PR0502MB3053: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3053; 20:eqbSzSWhucFXAypTVJGZUeAsgNUzh7fzEDT9I7G8x7bbkiho0WpppJk7MPVMkCMhcHFuvLhUaMWJLDxH7XIzcAZFltt598216pbORVA8+aAJfFlCbD5V5baZUR6FJYvOwRPBZz/sUDUs4oY02sZIj1DHsMIKl2phUTtchKU3JW75H1W6UybJcSJf/5PV3XrA0BGmTVzqlZOZCJJG1QZ2IFRL/XyBbpFdX35FegTg9Jbkf5ign9CcGUrSDwmJrU0epMwR9aLVt+Kl9GI5cTTd2ucvQL+gcWSJJJvBUkhf0wgDTFcXyjoozAUsxbsV5NAG17ZzPy07Pe+mgR9AmgaGNPjqjDYbMXwpaKgdXjQQzU7TpfqvIUGaCikgk+bUHYwoDD2zfQWEUQG7BLTDqq+/JBGjjEhrYDIoTAAOG4qTkpuh3KZ1d9h17u0yYvIl2EcNJadKnFlbVxKFkeBZ7rM9WLwaDwGBI4f+SyjsSbF62ZS7iqyLZUUIP3kUZGT2XkV8; 4:XJh2nSE8d/+Z2CuH5ppnMi1+VC1lQVtDOlqaFpo/Vh3UYxDaEKV00KZojxTBIDJCh2wtLJbgCBK+3MbgXkO1eR+lsBXEsnBr+DpDuwAqAsUk6q4dqQwZr1XdVdHakvH14j8/xYQts6FL26WGC3yrbtfKI/DgWeK5n+T2N+T67Ep8ZICAwTyYOoT47TyQRYqIKQxDWCZKdBP2qla6nV+iWUWpRfTdWcVNoryHIR+2VjnkNykXCtTg31pz6BKDelIU X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0502MB3053; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0502MB3053; X-Forefront-PRVS: 04004D94E2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(199003)(189002)(6116002)(110136004)(97736004)(21086003)(47776003)(189998001)(66066001)(68736007)(53936002)(81156014)(8676002)(5003940100001)(55016002)(86362001)(2906002)(81166006)(33026002)(7350300001)(50226002)(25786009)(7736002)(305945005)(4326008)(478600001)(5660300001)(69596002)(50466002)(48376002)(6666003)(6916009)(3846002)(36756003)(42186005)(33646002)(106356001)(105586002)(50986999)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3053; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0502MB3053; 23:NiuetDUm7xUgnUt+MRfK2Sg47elFyjY+xwEZFQ6?= 79yd1uG94d+7ZE6S6jaATSBfIBBqjqegEXxoTRTUbNmBX9i3oooVKvuPj2kPWEamNCOKPymYuXM6cxM8ZmaqvqMRmk46l6DVUxR/LCWW6hBPgC72mrX8HSUVtOz4QhK9WlVrKxDNa0z5IF2zn2v6n1xmslfSkV7c3joiv54EoGLO9Qma9FiR8HWITFtz1cu+w3h5TDPOAdniKOEoRWZqn5aMnEXfuC0n3ejf1wh28QA8KD2iEvMv5EAduewSKnyMwKlewz+nlSajl5Teog++ZP//cxTN4D4WpZPU242fDMXhx56kJy0ZAhVL1JYaJGrSzmXq9u+fxqY/VX09I0ybwcHr4/bOcURgql93f7tbBmbXUc1CscnI6hEF0vhc9u12WlD/kPr3ZT1q/OwggCI0B3e0Xqke8PtfEfNfP7HmdZN1rTiV9QADszSTH0CK8xACNtApn1wTXh28IpJoeBCoEI3W+7r7FK61lNLviX0bu2MPolPP55sp3mTj3o3/MVjJlq5M8+h5SFao0wI4TSWcwFwtQ5avxKI8Ez7A9hjl8/4RBWR4OK2ef2/fHuTEvLji8yP7kqS08cm3t9DqttrGYukyheM4Tm4frUGIHZlcVSgn8zi1rnFWHhu2jFrzi9VZ06nGhyCTVFI+FRxPNmGT35Uqae16asF7tPSbpTnbRFyAfPW4+AVLVMql7VXWIfdKqNGz2QKjfIw5gsuP8m/9EFNulFx/mQXmR2PrNTxuFKqgkTFnfp/2bjo8vx2rA+kI/MauiHLxWx6Y8HHzPmHhHnW4t48bCcvMpYX9VjSqR9m+8HGKKELfYscLz8ixin7O12odjSIpnByDxPsW/35q+kf2O6fkYvxzUyRRydidbDyvlkkSAnWv2z3qxNg89BwS0MSuzeCSEE+I5KP3+Jh//z7HTiSTmJL5uAoHWk+90THLKzWgsYP4b08KCgAgVFqVLL0BAaEyKiTVzujabTXjgfAiD+t3os4wcevuvzSaOybBHeF+xP45iiDqfuOnwkifgUdY+Fl4Rn8sd+0s2gv6B0A8vZnwTG6PiEbRUWjxhInRA1Q== X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3053; 6:CwcWy987SyGOR0SV45w/OKIlOgmv0bAK98P4yEHUQ7MLkrqZJYPSYMeYAoLoPZZKhJT13CLNiGxR2dinwZVdgeN9F6YLKoAp0v2Y7Sd9kiYSFC0k7XxECEgvH6qmx0p0wsF/CTSLFfqIB6SU0AzZr46KyYjucmDtiYeYpQO8b4USQ+ws7ZZfpCeyc0wFX85/EfEKC8SZWuvB0Osd1SCeCoeEbdnFmwTVCQadQTDO2UofqBRe1i9vrwgGl6apat+TPMzjSagBHw9LDrIBg9V0JJov6wCcqiG0/plujunnYQ1Hi1weZTeaHnkM4aHGKruJFSA/mebm9+zqPrKClHaqzw==; 5:LNg6dwCcDIZy5IDs1cut3wmUhuj8Nc2MRJVAj2VIC3MoA3YoZ3D6ztp57/t3vErY6ReKo4N7mwWPCr/L80DwgHW286o+9v2F3HzV3Y1D8fK3U1FjV+VS16taqYaJWrIeWIGJnImR+96cj1KMV0A25w==; 24:tYpqODjgSZcMkx52yAfQ6Bjww7MZJ297FyfuFeiOFgNyBSGDFZS4cyir0V4/lSRsBENgn9YajgIXzXMB/HLFR6fJg4LUlNEWLe29wyO/6Es=; 7:Opvdao87EImHgiTlkt6J8NHNl1Mn/CkSM2ED6R4gh1VnSHQOE7imR96k8QepOC80NWXRrGb6kEB0gIuEZTPiKC+C0IiwqbuDqKd1MP+1gFyLHzn18bJORuIbkd8cHnV6+i9g4wAR1IgLeB/PEl2SdNqexIlFhyWohr12xt8XU/KmRcbNQld/sfvWpYG7ojoDIPpm9cCAvuP/PssA0qUhMoq2xuJ1FcmtDStazaKOx+4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2017 06:59:45.6831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3053 Subject: [dpdk-dev] [PATCH] net/failsafe: fix tx sub device deactivating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The corrupted code couldn't recognize that all sub devices were not ready for tx traffic when failsafe PMD was trying to switch device because of an unreachable condition using. Hence, the current tx sub device variable was not updated correctly. The fix removed the unreachable condition and adds condition in the right place to handle non tx device ready scenario. Fixes: ebea83f899d8 ("net/failsafe: add plug-in support") Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Signed-off-by: Matan Azrad Cc: stable@dpdk.org Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_private.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) Hi Gaetan I didn't find any real scenario which cause to problematic behavior because of the previous code. But it may be. diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h index 0361cf4..dc97aec 100644 --- a/drivers/net/failsafe/failsafe_private.h +++ b/drivers/net/failsafe/failsafe_private.h @@ -346,9 +346,10 @@ fs_switch_dev(struct rte_eth_dev *dev, PRIV(dev)->subs_tx = i; break; } - } else if (txd && txd->state < req_state) { - DEBUG("No device ready, deactivating tx_dev"); - PRIV(dev)->subs_tx = PRIV(dev)->subs_tail; + if (i >= PRIV(dev)->subs_tail || !sdev) { + DEBUG("No device ready, deactivating tx_dev"); + PRIV(dev)->subs_tx = PRIV(dev)->subs_tail; + } } else { return; }