From patchwork Mon Aug 21 06:17:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shijith Thotton X-Patchwork-Id: 27676 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D377E7D1F; Mon, 21 Aug 2017 08:17:40 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40]) by dpdk.org (Postfix) with ESMTP id 766037D18 for ; Mon, 21 Aug 2017 08:17:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UCozUg/Qxz6RbNzoQpjrnR9JZz2tVzZga6gvablmB2U=; b=Ndma74pX/5C0L8EZAdvzNRM6d1qF2JFwdoO1D0Lf/kd/Dt663JQPhgy1jU4Ya6tMW9jX8magagsXGX3KALygGjfICvr7W+wnpzDLLfTNnTNpEARy04B0DCho++SwLBtGCzQPW3kkefT4plMYF1o8VT07ssaJiEydaFXYDqIqV6w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from lio357.in.caveonetworks.com (14.140.2.178) by CY4PR07MB3061.namprd07.prod.outlook.com (10.172.116.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Mon, 21 Aug 2017 06:17:35 +0000 From: Shijith Thotton To: dev@dpdk.org Cc: Ferruh Yigit Date: Mon, 21 Aug 2017 11:47:05 +0530 Message-Id: <1503296225-8184-1-git-send-email-shijith.thotton@caviumnetworks.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BM1PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (10.174.208.20) To CY4PR07MB3061.namprd07.prod.outlook.com (10.172.116.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3fa45330-5598-4410-51dc-08d4e85c515f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3061; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 3:7wLgy2eB0iQW8AvW1868eqc7OvGyYlkVimbYWq4wMep8Ipu6MGNOlebvmZc7Hl2FZYhxz+7Ey1kxEkXqjWdA5uyKTvPQRV5yJGmv4seNpFve8ic4q2/Lnf9opePZ4ZYkk9I7BADsbRSDWATg9ODX+kxErVsPThFQbq3lzwmONU5OTH+nRFyxgtptnAVw/BG5ne8OPs+yhlpyhpQJRc82ElKUSVJONDuVSmQ9ye8118yG9v0trw3CByx8kp8M2f88; 25:xbei0SX4sgAZHkv7Yux6EkDMEjGdRvIC7L9n0+xbAtVSO/k0YmQ782LrkSpCsypDZeAl+caddGgTgM1Ydm7XKEKtRnYq3QvTgN4lz0dktqjPJpzXozIOkAMKK5VGCson+LsX4Fa83dXIc8Lx5ki4jWkXWFulWi2jAMvVLWtxPa25QXPOJLj5opQCBSZf6IlB/fcdHb9ICrpFNLHQYBwjGY3PKfQ/dD6qw2jh1tpXmkQF2+QZ1dcqKb5w5j/yBLj6CPlz77x91B9Gce9XFDkxw4qkOv7+Pagm7IUhQ7hChUrDeOSUUwF6ClvA4kGo6mX8J5qnDVgpA7gYdL1W4fde/Q==; 31:PzgL2etXz/8KSMA4smaxnWtsC8NASX/2yslxElT9xzgLfknBYqdqjsNDW8fn0dN2e/JUb7OfXZi3Xd4/zdyLr1NTBqa2Bw8r+VhscfdxJo8L+iKjkFvLKh48ZpL6cawS0Ntu6QBJz/WpdkJhWrhde1liD8QLnoqWzu+H5AFxcucM4Dsuxrt10S0FVZ5Lq63HxSm3M3An0lGR8AP6V3Lr34qKV0ZbuxsY/r20Rfd+kIY= X-MS-TrafficTypeDiagnostic: CY4PR07MB3061: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 20:1ABadega0e2dY/j8L3Dh9BZV0aBB/5zgEyQENGvJwfPzky4cTKIQz60m6XAYK+gVNn8ojlraMxFar1bJ4U6tGtgU71JpR9HWev6V7+8QLEGEPqloUaOe0jqIFtC4BqN/6sc7tSPnKRHIRueYQWIZBNd7pjt+TfGEItyD6LUwj2jIzOV+W9gaFoziLKZ5BJdEgwfGmBo38/S9VnIJz5kQVY8IRF6jE/OWdScV9a7CtYQuc9hvN5dtXdKXvwqd47KyGnVGgO3fWbu98ZEjN5AYkShO7KBjaIsKAM4GoqDtpPoJJ7yvQqrbCITFzfrYDH7KCDqWnZaa5yxsn8ULvJFVk4L5Pf6IrNTy2QufVgDjwA1LhhcrGeTcqzoIKBU3YFLw2cggK5rx3xxNXv71daopTwPqHDm5+E8klDKXs558Dk03GsXSykjTjo0rAvf88scn09+tB+cXNywCYdLwGqIurNSez7phW7QPHdOuf0ZcLeOl06YG++tBOxhlLoTBSkAJvo4pCDoi1L44ssc1FhVeJKZSdcK/0yXiq8sAvpxzJ+KiovzRiGoU98Tp7bjFkEQvkDgNteHylj65ej9sNCK0Q1Xf3Za6xMDO7hkLRfqooSE=; 4:3xdhYqucy+OG1FZgKV7iRGxybLJd34j5hFHrhATeEbKzExqJHyHhcRRgtZ/v7gRctpoLxsqrGBReGz8GBZ/kRRKNYlYOGm+m9hyXfC/clml4AnDo3Tf57PY4Z2iNh/Ch4hfrVrQ4soyKqR3wpP/UHnylPiYMU2QYO8lcqgdX6zhuYsvRB0IAxcjATAY+CtLChWofZD2bEA3Op0nSh6rkJeih4ftg2hHzlaFlOCCvEHIuoOEDLNmRYrehHbDaaL6Y X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(3002001)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3061; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3061; X-Forefront-PRVS: 040655413E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(189002)(199003)(5660300001)(575784001)(8676002)(48376002)(2906002)(50226002)(81166006)(50466002)(81156014)(305945005)(7736002)(68736007)(6512007)(4326008)(2361001)(478600001)(106356001)(2351001)(25786009)(6506006)(50986999)(33646002)(101416001)(53936002)(6486002)(6916009)(6666003)(42882006)(36756003)(72206003)(97736004)(42186005)(110136004)(105586002)(7350300001)(5003940100001)(189998001)(5009440100003)(47776003)(66066001)(4720700003)(3846002)(6116002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3061; H:lio357.in.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3061; 23:+ooAYzPnaJO+uLLaXk7iQLX3dFEFK5bJj+YG6jGo+?= KPBPqaO/Nun+aKaHAPqI6aIsYfLAH9KIevP+6eBACrEzGNrvNyFLg6BczqGoo/Zt1BP7BAeAofEKiE/sQW1HhyAOQuxmA7W89GaCrsHbufMMlzzWdXkereDAsV/GuBHShe6H+6S/5lG9mGVYGgMdR2rI4S+rmlz8nCT8oqFUPfrSUTQDd/JvOETlmZ3+aY0ensXbSzYncU0Ivp5wCcXMUCIkKxYzNHc3ebmW5FTJWyNIrpoi1mKo1n+IgvLU+0IHkI7H9vOU0u+EVnFwCO2ZG6IvPgf8Ry9CF6G7BKdHP661N9g4zRtFdlQIJ4lNb6XD5SAALLjybqUHO2jIauXkWXnONC29f2hIWswnXZKBK4zHWIj4GTKgriv6qoyD/D8qXOPXYHXcPJcy/eQ9wG4K/JqwIYjWPL+/kFTb5OpY2F8wkBwRm0DZ5WIDEjICkF70oDe9Yth7sYdjDV+0umZuaaQ6uweR3IL24JPNthj1ZJ125kBj2vAr4lj06YAYbdrd7TEg6nHuDiu5pMgjnrxDdXR6aaV4ghIz4JHCIu1J7Xw2KA7Nr9i5LdDAYfcLH+N/gh/f+6Xn4GlcGi2rFAhPLMcngkE9CiWDWYiLo5hrQwxzNLNSVgwHnSoEZKbHpFbK0OMShT0o6w1E78cmt6dnJXitYIItpZVi+0AO31MQSs2CVcGSThspgRKjhN4oA82RPdMWcEb3QLCEFeG2dzFNb7JO6lp7KE377KxfWZHZEaHa/GIRKXjzygwA7XJX1KrLoh65mLNsMEYgumUBpYYfKUn4/RP0Nu6fNFwHhaDBd0so5ScOW/hatLlNPydHJOSSso4h53EBgrhMnhq1Pni+4GHTYbDp/TtIrvSrwxHawmJtq7XKRi9vqUVxFo6nmidCx/2jkv179rQffqpHr4v/EutyAC1v0gXNxuSIoBbJ1gPN0dQJcSQvvFXOad2yyJaUIoagjZhTekWA5kQ4zj9Fh79V/sOkgSTPPAASPO/KAUiN/2i8k7GXxXvNsj4RKV04MAhpfFv+Li4kN2ZyfYlbug8yd0frrlO1+WD6QlH6Fwrsz7GyxDFyUPnWT20uTEU/UgWsUThRgwelyVpF4WOzx4TUX5Q62B3AcAMcrzb72bMZNmEXEbPD3zfO0W1ojqfvFhx9cMWUXm4sbJzvwABI/Zn X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 6:VkPsJoNzsI0qLGbgpAAzgm8zjK2d7eFVVXCjAv5XWUWTwxYo9QiN8N7FfPZBe1/bBT9ouMLLCUoFcQR7Lt+4NJk9iZIFbxnie+7yHDrJoaWorAf1iN00zyUvzlrEKEBuLRC9c405BXbwNySDSDzxsPw5rB93He7hxV4t2j2lf4zm2GfKnCFklcTQbl5uTTGXsBBXf2v8p08Wgws4Aae5asVPgSHYTW5jUZn04VjFgzM/TUgMzFO62Ekk+MNdOoXfo0AQJnHQtJy0/GYTI9QctP2ix+yTVaknNRqWmOa/8RgIZUG6XgV/fxctOEYdeRL1m3EvBx8PhzMczjOGVF4h+w==; 5:HPcRpMea/cXzEJRCkoDp+9pLEWwuVOlpVqxdwGX7YuTRlxCfAIWIAd4LdaegrPLWwT4AHV648Ts5JKRAsBJ+03Yk+YCAc6EFtjMQr8ur4ptdFsaC4sG7evT7hS8IEUxshU2sxB0wfr/v9pISnvOGpA==; 24:ousMuJzdoI2bmSF/8ezrj094FL56MCnkEaBUhKgWaaZt4Pm+IvF+9zhk0vrQNZAI2F/qELzI2HWnoTgBhoDqQveKNOL8d9NIgZMcV6yFcBk=; 7:tiuup3VWRyrew0GkGa3GHtYb/bRtzBeo7lorUzQXVkk0glNenoZ3kpPK/sBOcZr8BOx6TamEULp8WdMAW+7KrloygwlZYL47qijUUIxR8HByFN0G+XEePmsRzQwsbtUgxZNXVwelIGskSdjRR4apr6sin98imWQIHU+4m+6OQZG2uFE0lPJKwltyNepubCqN5gw8KlSyUHoIo4cRO79fAKXKfiTSaBX8QfIUdFoZm1o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2017 06:17:35.4512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3061 Subject: [dpdk-dev] [PATCH] net/liquidio: remove FLR request to PF driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" igb_uio and vfio-pci does pci reset during open and release of device. So FLR request to LiquidIO PF driver during init and close in PMD is not required. See commit b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") Signed-off-by: Shijith Thotton --- drivers/net/liquidio/base/lio_23xx_vf.c | 19 ------------------- drivers/net/liquidio/base/lio_23xx_vf.h | 2 -- drivers/net/liquidio/base/lio_mbox.h | 1 - drivers/net/liquidio/lio_ethdev.c | 8 -------- 4 files changed, 30 deletions(-) diff --git a/drivers/net/liquidio/base/lio_23xx_vf.c b/drivers/net/liquidio/base/lio_23xx_vf.c index e30c20d..9978017 100644 --- a/drivers/net/liquidio/base/lio_23xx_vf.c +++ b/drivers/net/liquidio/base/lio_23xx_vf.c @@ -379,25 +379,6 @@ cn23xx_vf_reset_io_queues(lio_dev, num_queues); } -void -cn23xx_vf_ask_pf_to_do_flr(struct lio_device *lio_dev) -{ - struct lio_mbox_cmd mbox_cmd; - - memset(&mbox_cmd, 0, sizeof(struct lio_mbox_cmd)); - mbox_cmd.msg.s.type = LIO_MBOX_REQUEST; - mbox_cmd.msg.s.resp_needed = 0; - mbox_cmd.msg.s.cmd = LIO_VF_FLR_REQUEST; - mbox_cmd.msg.s.len = 1; - mbox_cmd.q_no = 0; - mbox_cmd.recv_len = 0; - mbox_cmd.recv_status = 0; - mbox_cmd.fn = NULL; - mbox_cmd.fn_arg = 0; - - lio_mbox_write(lio_dev, &mbox_cmd); -} - static void cn23xx_pfvf_hs_callback(struct lio_device *lio_dev, struct lio_mbox_cmd *cmd, void *arg) diff --git a/drivers/net/liquidio/base/lio_23xx_vf.h b/drivers/net/liquidio/base/lio_23xx_vf.h index ad8db0d..83dc053 100644 --- a/drivers/net/liquidio/base/lio_23xx_vf.h +++ b/drivers/net/liquidio/base/lio_23xx_vf.h @@ -87,8 +87,6 @@ #define CN23XX_VF_BUSY_READING_REG_LOOP_COUNT 100000 -void cn23xx_vf_ask_pf_to_do_flr(struct lio_device *lio_dev); - int cn23xx_pfvf_handshake(struct lio_device *lio_dev); int cn23xx_vf_setup_device(struct lio_device *lio_dev); diff --git a/drivers/net/liquidio/base/lio_mbox.h b/drivers/net/liquidio/base/lio_mbox.h index b0875d6..f1c5b8e 100644 --- a/drivers/net/liquidio/base/lio_mbox.h +++ b/drivers/net/liquidio/base/lio_mbox.h @@ -43,7 +43,6 @@ #define LIO_MBOX_DATA_MAX 32 #define LIO_VF_ACTIVE 0x1 -#define LIO_VF_FLR_REQUEST 0x2 #define LIO_CORES_CRASHED 0x3 /* Macro for Read acknowledgment */ diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 479936a..5f3c05e 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -1559,9 +1559,6 @@ struct rte_lio_xstats_name_off { rte_write32(pkt_count, droq->pkts_sent_reg); } - /* Do FLR for the VF */ - cn23xx_vf_ask_pf_to_do_flr(lio_dev); - /* lio_free_mbox */ lio_dev->fn_list.free_mbox(lio_dev); @@ -1929,11 +1926,6 @@ static int lio_dev_configure(struct rte_eth_dev *eth_dev) if (cn23xx_pfvf_handshake(lio_dev)) goto error; - /* Initial reset */ - cn23xx_vf_ask_pf_to_do_flr(lio_dev); - /* Wait for FLR for 100ms per SRIOV specification */ - rte_delay_ms(100); - if (cn23xx_vf_set_io_queues_off(lio_dev)) { lio_dev_err(lio_dev, "Setting io queues off failed\n"); goto error;