From patchwork Thu Aug 24 12:00:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Dewar X-Patchwork-Id: 27866 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 17E9C7CEC; Thu, 24 Aug 2017 15:48:20 +0200 (CEST) Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 3B4A27D24 for ; Thu, 24 Aug 2017 14:00:33 +0200 (CEST) Received: by mail-pg0-f68.google.com with SMTP id 189so3618100pgj.0 for ; Thu, 24 Aug 2017 05:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=56hUEizRff1GmxecmbxPc3XTQN5YYa4ppMYhEL871qU=; b=IP4/YHgH3h5SwfQO99QBUGtIm92UHRYfkVlQ474Ymk1lToWON/u3WKZi1pRFDPBLVm FqZkT5RC/qvzolZqg9C9wj6R/YIQJ1ivGuYU/0WyaASPewoKflWrbenLIbPBkjOHd+l4 yvURw2B2M9ZIVpXZyPXrR3KHnE56lFAvBF2QFdN4WBRQKRWB97Txkwd2EcHMCelDJhRQ 6U4ifNv7egN4Ka09qGrKbui3wYy3XlpD8sYnnOIxzIbnEm3g+DqnkGYZ9s10neMNFUjZ oxBthhpr/2zOhxDb4Zewif+X1mIrGuLKo+J29mhvDWHY4ohEsJ6wbpaSlqOMvQ8puUyo mYVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=56hUEizRff1GmxecmbxPc3XTQN5YYa4ppMYhEL871qU=; b=hXlaxiEA1KDk61FyeL9/pa70p8GRFftyNSyLFAZnMQ5GFKgBnW7Dih2xm8ylqfMv3C lOL2epS7OoZdbJC9bKMfz/8JTQMs8mPB86Iafq/Ur7h+2ubYhcUkLgLjo/DSPJWvqGZt SK2IIeiHLQq3Cpag1Xgh6zNGheG0BwpPzzq8LWst+Dv8X9pY1MHqLheZJnU+3K5o0PPT y178g7AT60kc4HOoc/T1fqilfaBmbSgDrV4V6MIRzorhRn6ja4qJx2692H3I7CcSHoor +RcAuRlqbRPJplSaWFaQAPT0+6HuvDCnFCWYwJps7YGoz/oFLPwic98G2wxDtG5QPizF HIXw== X-Gm-Message-State: AHYfb5g4q5khhUA5/b1AUKhBLe1IZVygldP+Y8HVGbvTq+X68G039WmN V8uZMFR6SfGFtvL6Z+0m2w== X-Received: by 10.84.214.2 with SMTP id h2mr6587633pli.436.1503576032486; Thu, 24 Aug 2017 05:00:32 -0700 (PDT) Received: from bra-l27t7p12.corp.brocade.com ([213.251.34.151]) by smtp.gmail.com with ESMTPSA id n11sm8852967pfg.15.2017.08.24.05.00.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Aug 2017 05:00:32 -0700 (PDT) From: Alan Dewar X-Google-Original-From: Alan Dewar To: cristian.dumitrescu@intel.com Cc: dev@dpdk.org Date: Thu, 24 Aug 2017 13:00:11 +0100 Message-Id: <1503576011-11389-1-git-send-email-alan.dewar@att.com> X-Mailer: git-send-email 2.1.4 X-Mailman-Approved-At: Thu, 24 Aug 2017 15:48:18 +0200 Subject: [dpdk-dev] [PATCH] rte_sched: don't count RED-drops as tail-drops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Everytime the rte_sched_port_update_subport_stats_on_drop or rte_sched_port_update_queue_stats_on_drop functions are called the n_pkts_dropped counter is incremented. The n_pkts_red_dropped counter is only incremented when the function argument red is non-zero. Packets that are RED-dropped are not Tail-dropped, so the n_pkts_dropped counter should not be incremented when the n_pkts_red_dropped counter is. Signed-off-by: Alan Dewar --- lib/librte_sched/rte_sched.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index b7cba11..c10c266 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -1108,7 +1108,7 @@ rte_sched_port_update_subport_stats_on_drop(struct rte_sched_port *port, uint32_t tc_index = (qindex >> 2) & 0x3; uint32_t pkt_len = pkt->pkt_len; - s->stats.n_pkts_tc_dropped[tc_index] += 1; + s->stats.n_pkts_tc_dropped[tc_index] += !red; s->stats.n_bytes_tc_dropped[tc_index] += pkt_len; #ifdef RTE_SCHED_RED s->stats.n_pkts_red_dropped[tc_index] += red; @@ -1140,7 +1140,7 @@ rte_sched_port_update_queue_stats_on_drop(struct rte_sched_port *port, struct rte_sched_queue_extra *qe = port->queue_extra + qindex; uint32_t pkt_len = pkt->pkt_len; - qe->stats.n_pkts_dropped += 1; + qe->stats.n_pkts_dropped += !red; qe->stats.n_bytes_dropped += pkt_len; #ifdef RTE_SCHED_RED qe->stats.n_pkts_red_dropped += red;