From patchwork Tue Aug 29 07:51:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 28052 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 255D9137C; Tue, 29 Aug 2017 09:51:43 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0053.outbound.protection.outlook.com [104.47.0.53]) by dpdk.org (Postfix) with ESMTP id 035B311F5 for ; Tue, 29 Aug 2017 09:51:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ylkWoZyhMKMLB48klFDmPSQO2phnTWpJERcM19a3BXg=; b=oOZwTKN2yGhHfrxrZqdTR/KJri5J7Ur+BDiAuHQn+j7Ea6UMiZx1M27CAOTRRte2A8Y/N2A3VrVI0e7zdJ57owa8oI7xd5cz7wkl7D58aU635+58SRbuMmbj0Fzy2zyZCAFgGsrKVPdWTqeXrlpXXZ87oVKkOwK8ZPdcjLXrHfI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM2PR05MB1220.eurprd05.prod.outlook.com (2a01:111:e400:8450::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Tue, 29 Aug 2017 07:51:39 +0000 From: Raslan Darawsheh To: thomas@monjalon.net, gaetan.rivet@6wind.com Cc: dev@dpdk.org Date: Tue, 29 Aug 2017 10:51:29 +0300 Message-Id: <1503993089-55121-1-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR08CA0167.eurprd08.prod.outlook.com (2603:10a6:800:d1::21) To AM2PR05MB1220.eurprd05.prod.outlook.com (2a01:111:e400:8450::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 396ff2d5-c8b6-4496-5181-08d4eeb2c847 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM2PR05MB1220; X-Microsoft-Exchange-Diagnostics: 1; AM2PR05MB1220; 3:/iNiUFFV5VQexrnqa637Hhz89RPUUwk8bVcdFQt0teECv0PKh9mSKw6pxl1R2mQYALq5oHxFGK876rAT4hIfLE/E/ytsqB6IFwu4WoEsWRqfRhE6fsU+pPxyAV8z5i2wrqaxDQgOBVZ6ndF1SbJ6YYUv2bEKOWH0VZdU4/qK4J4QHgUfmE0Y6kNyalSNKSe3eTWaCwLk94/XkMKjObQozYXjcRoTpicodaNGes860YmdyqFnnKazZBoix2yChWw9; 25:xgoRH80HbZiLGvsqYlhivV0l+cUwk/Lxx5PDpZhQcblAsfEg22B2zy6671yH6OgrbEjSLWHNshl+a1S6DrKkZ9fcHcFg6QISMQWCjZTnHWGkCXK1U0PJvjZ1w2oi9r0grM7VA2zG6yblr/n2rdX+tUBEbCmO8ZXGE0XEv5omW6YhaN1sHtDwV0OUmU1KcHMySoj6JzugWW8zjXQrt9pJiVZMYHogA8CHuARm4+iU9VlYT/rOkpXynwaISfKrRwKVKK9kN0oN2Be30juqHLJF3OAGvwgozVx+QcvFmNc0H9/UcJU1fi8XjFIv2JPZj+K0AJAWkXnoOkQiQN8ceQan0w==; 31:3iRKQOVvlGWD6t/KTCxw9v+ubMDaELISs3KuQ5FwC+cA+sJtJ9cmD8pQYh5H+3tynggFqs9btcjzXRDL9yafkOLJDkTemNjmXIgtIN3ijOTeZfFVvdOr73iUcOII3p7thI14HbRzi3KJcDt3A8ftMNqminOFkB0MZOpQZcL53Bif0WCOljqDw9q8t9HlTt4xLIR6HaFwVb41ExJ/XKkKyaQzSTmiYicX1ZsnpdT0hYw= X-MS-TrafficTypeDiagnostic: AM2PR05MB1220: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM2PR05MB1220; 20:wQ7U++zbhyqEkFHNz4mSdrCgmA3TMZeDcx4JgZ53L7ckSXQTjer6ZVgpEXviH8rZ51o+v75Jf20yJOV8sTjnV8ILMQTfv5nRj+ywiNeDSYoAE1TjbjQwQW98J3JDyCxQHH+Ke+t/NguhJjMy/fGx9IQKnZIcyus+IS/m0q3ebAwVHPJGsBv/8N9SfhUlrH+GLS1Tg9fOleA9qpbK1sn+UnIAkNdSRbtTnzqNJ0R/FJNe5x5HVRe9XYZVeaIgpLWj2FjiAYOvDvI7oh1RnM27S5w9vYlCdDBJ8RbmGepHjKBXYbstgjtezCB/C87fAeRj2Lgor2a0U+JYbeYQxSDjlyoVsn4lUh8FFlWmaAWSf3vvcL5J+ZzB/Lv/wI749VcBHb+6ABYMXl6DKZfXw2P9SjBkgfBg0Pseo2N9PXzZygQ7Fb+Gx47WV+UpCudFkpGkEXyEdrT5JQziYFgP5TihHgea6kuwZelRcag2blT0xi9Az8PtvfTgUXH4f+4M+M/k; 4:raaJBUc+QM/FbPX7ypvgcD8T+ij93r9NH5u6sO1XiHj6vT57D5Laz9eYHynhNbsJVvjdunNp00ehOnqW3xVI8tQzBSdN4S+iw8Xy34iwMwqXoILo6tcFCzDkfaUjF+DNl4i+6Ln2KFDVJJfMslnzV6sDfXf+Mek7jgJiEbbczo2Bd5oLtIsmT9l179dent98iqxJK4nWeb208fUJmEpybWU0upboKobbvJQMedXlC1Xr584F6OJ0TVuAOHIoZKsb X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM2PR05MB1220; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM2PR05MB1220; X-Forefront-PRVS: 0414DF926F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(199003)(189002)(66066001)(106356001)(105586002)(4326008)(68736007)(101416001)(47776003)(5660300001)(2906002)(189998001)(86362001)(5003940100001)(6666003)(97736004)(69596002)(50226002)(110136004)(53936002)(33646002)(48376002)(7350300001)(6116002)(3846002)(50466002)(33026002)(36756003)(50986999)(25786009)(7736002)(42186005)(305945005)(81156014)(8676002)(81166006)(478600001)(21086003)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR05MB1220; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR05MB1220; 23:ePR45zLfLl8M6PPLkq4xn+wyK33x38lpVMKNAtxoU?= Py2vaXOhP2FpqMI5BJmCpV3D4Y6Vlt6JoQ2i4cgg9BcEOJEc6e7mO8sDtiqMGBhZOIIISGdB9hzZ0mbLuDiU1MnICsJoTQZhPBYewmlsdm1sXcgUsRUwsc6kzGBO7qx/AemFehp2c8BR9ZhyU0s39hdeDZQEYEG6T2PWK6Mtbh3UF9G57ix+B6rcCrIwoh5mzwTNt3ZwpzQgJdFzd7t6bWLZuZdQFJ6XQd8HcDLN05xhTMTT0eXVaySW9KdiNZC4gsUctEN5LOnGMIntRCD+rZqEksV2G+2X4RcGUQGos0Rfnz/3FuD4GOrv6E9uQkIHxC0C6rwWSseRprWwiEQYbk9WFm+E7PzYJryRl1iuiv+26x0FT1vsRip5k8VkqQ61oLdIhola6hpr24tV0DCBmPi5AuQpbaKMU34tDYTbB5F4MRdbnyHWhAZXUzzDfvX5o5SgZ3ciHb66OiZRZxs2qzWtDlNSnuOap6HPgMC1E6LuxImAcM/PA2UJ3fesqFMidLrYWuvtcaq2X0YG1tNnZ14PK3dGwr0V1kkSY+JIVQkhJt5S7gpB8lIzwi7sTbAeWiaRKdKKdxusNUIUBiGXWpWg7VuqD+YOQETHs9hz4xgd0uU8/deD3lEDWsSEhrr6lo1oJl91jl7ef5rCTjNHpZXFLqcVneZJ+X5t5kflaTGYKhmZx3IqTmW+HtJhG3IojrXMw7jEadwURM4nwuMDcMCTUZCuANreSXhnDRHd9RBBx07CULZ+19XE0aICTG9SjtClQdEPM9X9guTyi4o+V6xYqFWV/HRP+kSU2/rX+B0sv1bWtJSZ88sRRbm4WvhXeC/oaQlMwZbGdoohyVXgK9ReEO0Gznvf9NNpP1N89+7wOjRdbrthbpVcQDbsKR6Y2hb0O2I7v/nQbC5ZHGekdJN0s6vWhLlbvRX5Xhq63yj1ftelKhn6KirZc5Nu2udXyGI3AchX00YMKrwiimQs6SQ0J+WaA7242oLKwg5I11wrJtyn5lWFEulSIUp2xMDVUo= X-Microsoft-Exchange-Diagnostics: 1; AM2PR05MB1220; 6:J9Sg3Yjqnn7pUr6uzkTO6lBK26a4fTuuzjqmEtDqcugxElXXQK1Ha9I/NhxB6rxQYtS5GOtn0yd6B+hCC4LjoDQ6j5jAzO+/mH3jsDnWrb8s262MEIk98wVAcEpqsX3apJosW0wWfGcs3YXJ41x6vIQnV2htzzWitNSxS4KYCEnRpowucS/0tWo47L7sUhKKAqU3YUZcI1UjtwnbW90Nu97ZyC8gl3FgbmsbWmYktMqYqMApywyGDvIUYHX0m9tt5yrgacr/RTD6zVQZP29pK//Bnwrqeum6YkKF2LujGnoDQQVh42+YMeUOj5ALmKhbrpQS0svROTorUVw5kGIMgQ==; 5:okJOEqo4zgoD0YiA6DyXZ2w1enMZvGSiAqYN+T1JMdWG9i1LLLfjOB9/yK3ISXwFPwHpZduqpl/nht2fcivfmps32lzhN+Val7sR8WDCWXvun1veIaEYEoUNgVWAhTRlMivK4Qxotjl0rDYnpNf/Hg==; 24:C3Ywcm59eMaig29dz3BqwX3MeHsVrEj6ZbBnSvdIqWZx2nMVaCykjbBy5zrL0SzI9qJvE+s4DIPREdpndkn85o4WUl1iBxftBrjrtK3RWs0=; 7:qIQhmqUKoja6qf2G9I6Bjxr9aL841mjroJLj7ITo7//ScerCTGj0FA26q4GojTRbLpNd0cbi+1qugC0YIJTdQwTPldaH7c5hu357Fea6zgdeIuZg/+3WxMcDMWjdDhzXd0yLKk5UJKRbzvgvOXR/jImlOnZ8n6/DSa2CCB9E4FIhIE8QmxDbpMrcqMa8KhjytO6XYDF8EO8Tv7JEcPgz8aKMUSNZH0YDNWn10sCKiX0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2017 07:51:39.1226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR05MB1220 Subject: [dpdk-dev] [PATCH] net/failsafe: fix failsafe bus uninit return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Will now return the first sub device fail value in case it fails. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index c8f4318..4295347 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -90,19 +90,20 @@ fs_bus_uninit(struct rte_eth_dev *dev) { struct sub_device *sdev = NULL; uint8_t i; - int ret; + int ret = 0, sdev_ret; FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { - ret = rte_eal_hotplug_remove(sdev->bus->name, + sdev_ret = rte_eal_hotplug_remove(sdev->bus->name, sdev->dev->name); - if (ret) { + if (sdev_ret) { ERROR("Failed to remove requested device %s", sdev->dev->name); + ret = (ret ? ret : sdev_ret); continue; } sdev->state = DEV_PROBED - 1; } - return 0; + return ret; } int