From patchwork Tue Aug 29 09:08:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 28057 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8A570137C; Tue, 29 Aug 2017 11:08:20 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0056.outbound.protection.outlook.com [104.47.1.56]) by dpdk.org (Postfix) with ESMTP id B8F3D11C5 for ; Tue, 29 Aug 2017 11:08:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2p09L3jfLM6bSg8eLyVXUjCOvHeAMY/7tfrzsZ6nKdk=; b=F2lIKDI7UF3FoiMVLqxrpHUgElskUdKABADGENV8Avyv4D4eEbmcj3YK9U3ZYExrmnQ6bpygCsmiM7R/jWxMd02n/HD/HbddNyPOEU48L9C7y8WEi0T0yK1HeIm8sG7Ovkhhu2P+Z5W/SiiCaKx84fbjnoeTwwa+xa8am3TIpRE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR05MB1230.eurprd05.prod.outlook.com (2a01:111:e400:582e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Tue, 29 Aug 2017 09:08:16 +0000 From: Raslan Darawsheh To: thomas@monjalon.net, gaetan.rivet@6wind.com Cc: dev@dpdk.org Date: Tue, 29 Aug 2017 12:08:08 +0300 Message-Id: <1503997688-1182-1-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503996945-62885-1-git-send-email-rasland@mellanox.com> References: <1503996945-62885-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6PR02CA0036.eurprd02.prod.outlook.com (2603:10a6:6:15::49) To VI1PR05MB1230.eurprd05.prod.outlook.com (2a01:111:e400:582e::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 35657a9d-5c25-4cb3-0192-08d4eebd7c65 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB1230; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1230; 3:+zCnkeQC6VamJdfO3YC6Z+0w+l+5wqcZH3JX/3AG1HSIm7Ilr/+aA0eSxS9Pu9ISLd94XWx3n068gz7UcsWcibBS53WAePWpdsLv8Hs+u5LRqksxNJXOhHY+6/zpEu78Zqrz3GsgjKIFhzhiz8o1770s68rFrXe0AKw3VcMCAnx83kD0SxOUubmaoLoziQhGy6vUJJzTOZGA1KSFIi2z5rBhUQYuVqLHork/kjKZpbm95ZodxPxy6d9Lc+aT1mR6; 25:tonAznUKVE/0LhQPD3wohFuzHfM9NdxnaJ/b046JXFhRWhS8sWc3MtqnN7zYTEOHvgoirwXqTEkLcVtZw8eNsKUu4p51ma5NmemsiWzbB49KVwPUANlscBupOAEweEP55YU+JtsS6YhhCDHhccJAg0Z4I59EE17EpUAEQ5E/NEyCfx2AyrqhP0XlOBUN05g1Fz/1RyaJGr6sPDteFU29g8IT9mbojibv7F2p/L+YIlTzC+9tHSKAr2+IG9QPWP6x3XSbT/qBAYxSBO8/FraiuL7g0711EKySJ88aIkcyMqrVqDkMY+p7db9p3OkA4+0SDJ2XLPpVlOg5DiVYmlgaOg==; 31:H3TBf/dduo2Oat3HvDULuM9dMmCWvmdo7zaqQT/N146XbQCnk2OugWKhRW8H0G3bAPS9Y5UaJcvidml7plm5PKUF0lk3YSrdqDaYzqB+hD2lOozi6eVG9FLPx83gBKxcXfZUMMkVnZPOmMXRIzBC6Yxq9yv+yp+l9Ti3r9xR32gdEPFii/33mUDQb3X6gjPHjoD/BTukUZyY/VElaAMVjW7knralag0YiOwIpQFHpqQ= X-MS-TrafficTypeDiagnostic: VI1PR05MB1230: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1230; 20:XyyIGBoKzjz91gPNvEMnpsmZWeNNVspcZVp3Pd1mIbhihndQUUx/xF3/Ac4aIk0vZwbBOJvFTB1nMpFdcffld3NJK+Up2d//7PFxgfdI8yYdZKI42+eHkZyrBuRJNbITdZ+XWP6OLdYhUKDFYCQreBc/sBDtLQtv0mgnJwVGvjLW8IVkE1nmkMIQw3IWI/EsGlJtw7ubnGr2nW798w/EvH9g14emRYg156d2T9/iLcfK6H44LcA6YyoL62ylnB0EPy6+IFyPtVO/buzfRmom8nMyE7lrPR9n49EsCJ/v2eqXHv/HE6v0Y3nmi44Ejw/GPJHVxqtYe5VrccHEwy/kli8lQtICccDrJhRrs7s0r480J0HQHt9Z0kxpz3zud86Es8PBQGhuhEwPJ461kJMrxeZP/bOk996nTnyx6dY+ASDgxdxuOvArnj3gk9hb0ygQb0gNUfIxXJg8rSitJvc8n6YKxN0t2/CNx4BxT6Sp1frKGndVBK0cbGFb/HfUe0CH; 4:XB9pz3HWNg2X+V81DiI1Xi0c28K1aWGNXZD0/Pb47Yf+IgObH/QbNtA7vBI23t2n2eLAnhqonr8as7YVeEVmsifhmsKaNyemo4TZqoQ4BSy+8GTpzJ7pW7Xx7CYGJVFaNG3vZvV0jd0ZtLaG6Ir3UjQAiffa1zzLRlGSeGbfoeIP5gDQho1hgfLV8g62zMUzFgjpVGJvELGTvBjH8jlUDeglvhinixjknBPXNMMUS8Skq3mXCwFw2oqvxE45wMK2 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1230; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1230; X-Forefront-PRVS: 0414DF926F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(189002)(199003)(66066001)(36756003)(6116002)(3846002)(69596002)(2906002)(47776003)(97736004)(105586002)(305945005)(7736002)(76176999)(50986999)(21086003)(33646002)(5003940100001)(189998001)(101416001)(110136004)(7350300001)(86362001)(4326008)(5660300001)(48376002)(25786009)(81156014)(81166006)(68736007)(33026002)(50226002)(8676002)(106356001)(42186005)(2950100002)(6666003)(53936002)(55016002)(478600001)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1230; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB1230; 23:CCxN4EGEe6KudP/54X/L6yRvcCxagI6vgdM56CptC?= Yz2RapZY4We/gpF2QrOYSWnKKkCLUqLMCw+genawZ6PNRoKkzL3reo2Kjbqa8/jUqeevszvmcyNRcILE4CBiDLuavDucLCkAFHumxoR+mC7efKdYa/Sh+CqT1VJZhwgYP0esyipqkkuXkrYP+wFbhVVw9YpdicTN+wuRQEz1qIu1hhmVBoCZNU+cTewFhM7rfJmWhTAoPG7ZwL292khLFRsb7WM4CznLaU79s8rsY8tLyrQQJaRXyAirBT/5XDMwBb/cvDAqBS6VfeTS0ukLjSFvvvFzc6ZyFSpRpeS3sOcBp2SRw0bVECKmaPgEGHdYXlwuIBpcWCRikYm2Da3oOQMtfFUUzzqqCHqRubc/zZvVBWLbfDnXTepNvP65t4ms0GpiAoctKV1eMoWrfDurLX6ryJUC6nirTJF/XosGABqxmfPrP2IBQGsg/Sr8aYPtgntWosmMiwMkemK2nDbDcN1PbY3rnbVA1xj3zLkAU0vwz6GR5pC6l4Vnui4eu69yzjK6bDCv01ezql4FYGHti/JZFkKKTX0iHJpV0qScC6d9Es6gBlPMJ7zlR8xpR6E1VcYvfft6LxVGymyR2fx22Sic/LNLwY37SWGc4PmsdC50PBHkBcytGg5zUO7NjhgTMvYYF965hputUX1pv8hxVOzsk/oc2JoUU1GxJ0Q2tHR3vNplSg08XN+SA9VO3L2yW8EfHJKjihdYFilurDjPwNjTr4mkMK7JpPV9v5ay07Z2eZh+iCBU1wGl0/C5GqWoTOqBqhg/H9T+JmTgRdzJDPn6RjRgaGwXNyaoONY3e8CJ+0dT128DhqoMVoS98grkwcu8YeHWS9o63NLKKQiTJXRlUkAchcloDPgEluttFtWeyD4EOWl7AdbKuxpl0Wf+xolpqJfG6AJauIaMYQfHZCbLvLtqh1Fr7EfKd2t7iE/4vaFX58QJu/rtJTxDzlkJCeo0B7/KyVjowS7fOBdhpNI67dsTll4YAmbZo7Zy38D+9dyTo5jjekslKDnmCRadld+TUXL9p1MWCCC9OHsn7elW1NJM+aYcoDKRdJuXP38c5NpdQucV8J75lT7Y90xbtI= X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1230; 6:Vv1xzVlBQl7L92DjhFGvw5oCFiamOJk7mZzY2kZC3+uX/4PpH9Ji5UccOzy98dQxepGrzFNhonVox154I6w0Sn2ggLEmnsrUdgkBuaYOs5tlw331kq3uG5kVZA/2u+D1bp3cITPuggPB3wJLj48V9dLHvZE/wS9Tj1zkL/FnegK7q0UwXWd0uUX0QPIziKt0x/wmG2ia4o4jVu2m6mnWeemprNiePa0gac+fP3NiPI+MlSFmmEpw0D3r3Z8AQYIhuOwRehmvXLjbo3hM6qSKWR8xOEcQvDRMMIm2mdvIO9EyH0rfyx1gMhfwto93DX+Wx3un7HYKy0y10HMq7Idbqw==; 5:LLJPOzxwpsyWwVOzyo32rNwr9Se6Irt/jFVI1Wy5C5zNdceIhlZ+PxQ29Apf7oYk8ak8BBxUilnohNaGewj8NTO2Z7cEFhQuzoX7hHeaPf3EKxMddL0v3t9d0mILSpmrBwg7Pz02S3BhGpYtELvm6g==; 24:BwBQCZ1MVfdA42i2oHj1XV0LmVwVi9dfG3E0MJaq7dwMi2wGSVmwoHbrFiAvEDoXe6S7awdrPdLuzVeKK39V0lGIpM9sOSdpWaUN5nDFSi0=; 7:zRSsgWj35BdVC0uWSicEKKffP+Yj202YVQeaEJr0tzG9m7cHUz6eqb+9nI7Hk85EisEbs2IQWulrKe9kkrIkyOK3w0fVdEfuVVv7q4CGuXiilKGpQBbzqENPf+fE6wO+D0a1Bp/2mBQ1fgGcVdec4ETCNESYYNfkrTQuqdWrIDc6f1a0QCEifbNDmwh4TzZgA1bWYHQABDw6IW/zFduSaBMQvlfR15dK9UJmt88yWGY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2017 09:08:16.1493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1230 Subject: [dpdk-dev] [PATCH v3] net/failsafe: fix failsafe bus uninit return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_eal.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index c8f4318..aeb87a0 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -90,19 +90,20 @@ fs_bus_uninit(struct rte_eth_dev *dev) { struct sub_device *sdev = NULL; uint8_t i; - int ret; + int sdev_ret; + int ret = 0; FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { - ret = rte_eal_hotplug_remove(sdev->bus->name, - sdev->dev->name); - if (ret) { - ERROR("Failed to remove requested device %s", - sdev->dev->name); + sdev_ret = rte_eal_hotplug_remove(sdev->bus->name, + sdev->dev->name); + if (sdev_ret) { + ERROR("Failed to remove requested device %s (err: %d)", + sdev->dev->name, sdev_ret); continue; } sdev->state = DEV_PROBED - 1; } - return 0; + return ret; } int @@ -111,8 +112,6 @@ failsafe_eal_uninit(struct rte_eth_dev *dev) int ret; ret = fs_bus_uninit(dev); - if (ret) - return ret; PRIV(dev)->state = DEV_PROBED - 1; - return 0; + return ret; }