From patchwork Sat Sep 16 10:52:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 28787 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78A711B222; Sat, 16 Sep 2017 12:53:49 +0200 (CEST) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0086.outbound.protection.outlook.com [104.47.32.86]) by dpdk.org (Postfix) with ESMTP id 528D91B1F2 for ; Sat, 16 Sep 2017 12:53:42 +0200 (CEST) Received: from MWHPR03CA0054.namprd03.prod.outlook.com (10.174.173.171) by DM5PR03MB2699.namprd03.prod.outlook.com (10.168.197.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Sat, 16 Sep 2017 10:53:41 +0000 Received: from BN1BFFO11FD004.protection.gbl (2a01:111:f400:7c10::1:152) by MWHPR03CA0054.outlook.office365.com (2603:10b6:301:3b::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11 via Frontend Transport; Sat, 16 Sep 2017 10:53:40 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD004.mail.protection.outlook.com (10.58.144.67) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.13.11 via Frontend Transport; Sat, 16 Sep 2017 10:53:40 +0000 Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.134.28]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8GAr6v4028328; Sat, 16 Sep 2017 03:53:38 -0700 From: Hemant Agrawal To: CC: , Date: Sat, 16 Sep 2017 16:22:31 +0530 Message-ID: <1505559161-29222-18-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505559161-29222-1-git-send-email-hemant.agrawal@nxp.com> References: <1504860327-18451-1-git-send-email-hemant.agrawal@nxp.com> <1505559161-29222-1-git-send-email-hemant.agrawal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131500328202364426; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(316002)(53936002)(189998001)(54906002)(8656003)(50986999)(76176999)(105606002)(106466001)(33646002)(356003)(104016004)(97736004)(5003940100001)(498600001)(85426001)(110136004)(4326008)(16586007)(68736007)(5660300001)(77096006)(8676002)(50466002)(81166006)(81156014)(86362001)(2906002)(6916009)(2950100002)(6666003)(50226002)(2351001)(36756003)(8936002)(47776003)(305945005)(48376002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2699; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD004; 1:EWVLhhyBw3TLqZrz0hODi717ZmeG2xR2DDMVmkllEqskit12EusnDiBw5zxmmSkzJz827pexPVGlRSD6hJVk9SSGL0hxX66HIg+EYav/j1P6y6lAVSu3Mzs4dH3LZT1r MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d51ae6f-2dcf-4f8e-04a9-08d4fcf130ce X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR03MB2699; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 3:aJ8tijOa93HH4vWoJrT8sVLpiwsWfAXO7z40M+qL+Q8nKSBa1+r4UjCe12DegC/Vxd+eK5IrdinI7AY8KtWyrnAd2xeFDvjLxkEPcM0p2xDtuyKiS4dHGl7QNwPm4HzQ9Ms8yV9UYhS5+utPnFIVYl2yWRDDy1T8uuZwHZ0a0qJFzXqLG+ECEhUWN+diVhZhwy2OJPa9pd7Ua+FLflIt3nUQVGz7cOjhRpnMyE0PIX1GQOw3YZJhrrxTKznck9MNZQleVnKpMurQKmtdJLPB41Gk3aXN+2ps75X6uVu925UXOvp5xNd4O2P7wK9u465tWZBjMLQ6LGb6rmoff2r6XIw0GVfPDsStKy5YDc49fZA=; 25:L6VpAgGLfzGDKrdo586a/BWcyBcZNEkesxme9fZfT8Nq5vcI3kHAjhFVb+ZGtzlRzQ8/w/2R6MmDmX20tjOsCvdKzqqeS4T78i/Av0apsaP+0vnobY84D06J3b23ip+HKZLQLuFN/+aej18GBuCPczk2nbHcoN/LELnoCLi2DykU6sFzF2TgOn4ePx5hRgR9P2o7zvahYJSCma8us3OrKsC645WgZGHGEgQPVZZRzVIQlbceWbo1MA8QPfsa6co1pRRr4iBOIdpzAJQ9BQ/f1Z2DkqksUBtI1DgIY0prQwIfDQBsxgugHTEG6jdW/cxsGMsTfvIwKQAh02CoV/tAOQ== X-MS-TrafficTypeDiagnostic: DM5PR03MB2699: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 31:tHEQ9d+Eb9Qi5csgOZEM4p98QLImR27QpkO6jny1pyYfVyo4MyyZAZEDw1ow5Fy/ic4wIYuvau79JnLRCNeNKMzzaisKAco/UMAOcr+n5n4Qwsx2J+BV/cEU1SyiTk2MB3hpJg/xIYqyeOBUYS+b/K5CLgWIgZPUPYRQePhYkBqb2J80q3szy447s7dElD5DCT+g0DW8CgqztIopY8JgFGWd5+WT5uUpQM91DRgY73M=; 4:4fuLC4SbPh/Ef8Cc7tEp267aika+rBehLLpAY8HBBrMo5i9iASuSmbxoPWiaGB2zBKgGEFnIAtpFV6mvpEq4k7HZPikQewN2Wr4IZBq1I5KEJiR6YBG0WmfH9Myxx5EUs8GIg9QQiAsMLCLK0kUbFfbmyCNbxUf56FWY560mICuIwgAAHB1DBbK3fUk06yw+z16hAthhS5WxuGuqSAAdYNvph+iugkawknHrHOdcOaskR4GznrNg9ZoMp3sPcTr2uiTo8kizYCsQO4OVQ2KEiot/qZGwsRXDxi7Vs5ZD51E= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123563025)(20161123561025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123565025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR03MB2699; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR03MB2699; X-Forefront-PRVS: 0432A04947 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR03MB2699; 23:zpHX/gWQzlO0jzgeQ3I1xsgEX2zXp/pWqO9050n9/?= wo9BvdmAGi5cCFDCY0OYCjO4Xi/UHw1X9RliYFyb6c/z0UtG5Zp03kE51x9s+79/xZ2YbaJUsRmLhtsv3r1H+eudfJP7HSe8jkaWD8taHV3etuiwPTzO5ODXku1S8uA4fPXRnP7Zn6WUo8yJ4CdVkXtgufDz0UvyZupc99QG8ew7+/cTcjqsDxQ6Gh/Cw6zcwbvLE9YpPSj0ex3d1zmhFgsPI5W+5je9J8defVRrYN28HyduhF1pkY0uh7O9DjFY0hDeWnrz5Fo5p/8X8gD4svp9W8vgju292ucCKBcZLhbDaIMGagM2J1d4cNKpoKIAfpskx26iPbCb0LeQe6c+uAYutOOF8Xi3B3eg1kBwxgEttcD3bEAKtFebEgGMhHJ6FfoDN3dEIE1d+rIOSlJNtTe5tX6ZzzAe09rQwdT4mcQ/dxc/oXLuR+YOGpvv+3ZQUtzWEeqO9ljnZT0m+GDHjHr4DTNpApa6+SbF1YQfub0uftAvDqdQ0B1dYtkBJ16mamQCIQ6/UDVSm68DfRLEH2hN5LJ/WhhrjtCh6v2xcyY3AZLAcP4VkP0QMcBRKE6IsFSUS6AMmM+wA61zlw/OLFW7TETkpqmMe92CkX+bvPNOr8qP0AqeA/TKMqzwIfMlkNjAnYyRtRuJK5utauEOKmJZp6ChVq7ngTLhkU2Z7QTAFObMUbpJgOZ1T1F7EnHnAa3nzN2OuvCluCpERfmmrVZR2oapqXDCoocO11Nr3Qh3rTe7JpQrvo0/ppM583Bo4BJvl6yTsfp6bX3YYidPUt+zZ4L4P0rTgOx9o7lqPKD8MunoFQODKd6kYEWomWOEBZ+g8BiYvNtGCX13+sXS3e+Jxn7qXLtXSiqweY7Q8keQuDOg09Dmg3cMGs0z+wZCvLqaf0sIPt6hJ0tscdfP2uAeOY/JD6j4qa5Zn2Wf/tA/ka5StpgvlSZJ9cRmhB3Btze1uzSYzJU8tbaOPp3AqpCs+1xR3PdKM+06SV7ojGvge9Wa3ri+bzGMWz7KDdG+3mENACb0CLJpe1hIt4yB+2qQu6Efi8PJPaqMJJssLoYIIjRxwDSs+oKxbsmsTVqSZgGHXiuH6sOvnkbPZBQg8K40SmdydBI0fwVNcE6WSAkS6PkSEyRIzrI8Kz+OLgtXRP0YlFqdYwg2JNRcPevfvDRa+9b3W1Fe80cFRqbeKawqBRniB/KSS6eX4/SHLyfIl3Bi/Ice+zI9+knzVuH3yCg X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 6:aS72Qx6/4hiVwGvp9RVMMG3ZTUj5l43cqgCcxSmJxGRVwVP5nixd8bjLMuPjNbOmdMbBFsBjTQjHzpoRTWk0iNVSpGsfq/UgXAuaR3qvdrN9lF82xLZlaYXrfZl0vPxQcoteYCmhcruhrKLFgVnrLNnKiUXKw2qk3gffmkOEncFaR88oGcEbaZ4AqjL0qSihoxqsy1foMEey8Niuh9hNY0oiG6iKAPGg1isHrF18ZmWUZ7+W5CNj+HwgAj/v/Pd5IPf7qakZNJJ4dBc7Sl+J3beq0WYC6du8C2ELi/fJojk2WyvVTrp4hkhEIDDvJR4ZIK9s8aZrau+PwPMB+54Tog==; 5:n7RNHmu/IvcVdtkt79/DBzdmRaigF6irNFptdzXUEXR95E3DJeN2uzQVijynE+nLzOdl+NXxrZowc6kQ5mjpItVRV8a5F9XnPa8ZL6KQuo6zV6tB+vt6JpNXMWypp5fv9LdHg5m3QZxvwbrT73rTJCabqCP8gSijyYG6tArBxAs=; 24:Xp1NTSqUbAyU0mIuj4xB55SSMBt2DIo47u024cM1pBXCNyNUzHZ2ThQDDrJ8rFjeCbRsvW44In3His4oex/ExsvEROag/SpC76y5m24qNBE=; 7:4f8c6sFvvgjsjOlocWGjKEosG5kc5pK2DhkIEoLdqvB6JGfyXZPcxEKNiGupykctg80aGkf/YW/9seEv6pDylyIqVnC6u6dMdPTybFgNF+r4zpaG1ckS06bpQpPxLX9jJdZmXBfu8KvRTIH8ZWlZikeaNueFRDWT4RFPyhLqb5AuA/4VCRS4amYNF8zBicPqKjNr/djMQwnSlHWixNWRsxAxU0Eh0zJQxCBe4slsjC4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2017 10:53:40.0492 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2699 Subject: [dpdk-dev] [PATCH v3 17/27] net/dpaa2: improve error and logs for flow distribution X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 39 +++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c index 1269dd2..ca8a6f7 100644 --- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c +++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c @@ -49,7 +49,7 @@ #include "../dpaa2_ethdev.h" -static void +static int dpaa2_distset_to_dpkg_profile_cfg( uint32_t req_dist_set, struct dpkg_profile_cfg *kg_cfg); @@ -68,20 +68,26 @@ dpaa2_setup_flow_dist(struct rte_eth_dev *eth_dev, p_params = rte_malloc( NULL, DIST_PARAM_IOVA_SIZE, RTE_CACHE_LINE_SIZE); if (!p_params) { - RTE_LOG(ERR, PMD, "Memory unavaialble\n"); + PMD_INIT_LOG(ERR, "Memory unavailable"); return -ENOMEM; } memset(p_params, 0, DIST_PARAM_IOVA_SIZE); memset(&tc_cfg, 0, sizeof(struct dpni_rx_tc_dist_cfg)); - dpaa2_distset_to_dpkg_profile_cfg(req_dist_set, &kg_cfg); + ret = dpaa2_distset_to_dpkg_profile_cfg(req_dist_set, &kg_cfg); + if (ret) { + PMD_INIT_LOG(ERR, "given rss_hf (%x) not supported", + req_dist_set); + rte_free(p_params); + return ret; + } tc_cfg.key_cfg_iova = (uint64_t)(DPAA2_VADDR_TO_IOVA(p_params)); tc_cfg.dist_size = eth_dev->data->nb_rx_queues; tc_cfg.dist_mode = DPNI_DIST_MODE_HASH; ret = dpkg_prepare_key_cfg(&kg_cfg, p_params); if (ret) { - RTE_LOG(ERR, PMD, "Unable to prepare extract parameters\n"); + PMD_INIT_LOG(ERR, "Unable to prepare extract parameters"); rte_free(p_params); return ret; } @@ -90,9 +96,9 @@ dpaa2_setup_flow_dist(struct rte_eth_dev *eth_dev, &tc_cfg); rte_free(p_params); if (ret) { - RTE_LOG(ERR, PMD, - "Setting distribution for Rx failed with err: %d\n", - ret); + PMD_INIT_LOG(ERR, + "Setting distribution for Rx failed with err: %d", + ret); return ret; } @@ -113,7 +119,7 @@ int dpaa2_remove_flow_dist( p_params = rte_malloc( NULL, DIST_PARAM_IOVA_SIZE, RTE_CACHE_LINE_SIZE); if (!p_params) { - RTE_LOG(ERR, PMD, "Memory unavaialble\n"); + PMD_INIT_LOG(ERR, "Memory unavailable"); return -ENOMEM; } memset(p_params, 0, DIST_PARAM_IOVA_SIZE); @@ -125,7 +131,7 @@ int dpaa2_remove_flow_dist( ret = dpkg_prepare_key_cfg(&kg_cfg, p_params); if (ret) { - RTE_LOG(ERR, PMD, "Unable to prepare extract parameters\n"); + PMD_INIT_LOG(ERR, "Unable to prepare extract parameters"); rte_free(p_params); return ret; } @@ -134,13 +140,13 @@ int dpaa2_remove_flow_dist( &tc_cfg); rte_free(p_params); if (ret) - RTE_LOG(ERR, PMD, - "Setting distribution for Rx failed with err: %d\n", - ret); + PMD_INIT_LOG(ERR, + "Setting distribution for Rx failed with err:%d", + ret); return ret; } -static void +static int dpaa2_distset_to_dpkg_profile_cfg( uint32_t req_dist_set, struct dpkg_profile_cfg *kg_cfg) @@ -276,14 +282,17 @@ dpaa2_distset_to_dpkg_profile_cfg( break; default: - PMD_DRV_LOG(WARNING, "Bad flow distribution" - " option %x\n", dist_field); + PMD_INIT_LOG(WARNING, + "Unsupported flow dist option %x", + dist_field); + return -EINVAL; } } req_dist_set = req_dist_set >> 1; loop++; } kg_cfg->num_extracts = i; + return 0; } int