From patchwork Mon Sep 18 13:42:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 28843 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8581A968; Mon, 18 Sep 2017 15:42:07 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0F4BD237 for ; Mon, 18 Sep 2017 15:42:05 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 06:42:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="901335793" Received: from silpixa00398672.ir.intel.com ([10.237.223.128]) by FMSMGA003.fm.intel.com with ESMTP; 18 Sep 2017 06:42:03 -0700 From: Harry van Haaren To: dev@dpdk.org Cc: jerin.jacob@caviumnetworks.com, Harry van Haaren Date: Mon, 18 Sep 2017 14:42:20 +0100 Message-Id: <1505742140-63285-1-git-send-email-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] event/sw: remove spare newline from error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit removes extra newline characters from SW_LOG_ERR() messages, which cleans up the error output. Signed-off-by: Harry van Haaren --- Note that this patchset applies cleanly only on the updated service cores patchset (which contained a trivial change to SW PMD). Suggesting a rebase of next-eventdev tree before applying this - will make life easier :) --- drivers/event/sw/sw_evdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index da6ac30..361df89 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -176,7 +176,7 @@ sw_port_setup(struct rte_eventdev *dev, uint8_t port_id, dev->data->socket_id, RING_F_SP_ENQ | RING_F_SC_DEQ | RING_F_EXACT_SZ); if (p->rx_worker_ring == NULL) { - SW_LOG_ERR("Error creating RX worker ring for port %d\n", + SW_LOG_ERR("Error creating RX worker ring for port %d", port_id); return -1; } @@ -195,7 +195,7 @@ sw_port_setup(struct rte_eventdev *dev, uint8_t port_id, RING_F_SP_ENQ | RING_F_SC_DEQ | RING_F_EXACT_SZ); if (p->cq_worker_ring == NULL) { rte_event_ring_free(p->rx_worker_ring); - SW_LOG_ERR("Error creating CQ worker ring for port %d\n", + SW_LOG_ERR("Error creating CQ worker ring for port %d", port_id); return -1; } @@ -360,10 +360,10 @@ sw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id, type = RTE_SCHED_TYPE_PARALLEL; break; case RTE_EVENT_QUEUE_CFG_ALL_TYPES: - SW_LOG_ERR("QUEUE_CFG_ALL_TYPES not supported\n"); + SW_LOG_ERR("QUEUE_CFG_ALL_TYPES not supported"); return -ENOTSUP; default: - SW_LOG_ERR("Unknown queue type %d requested\n", + SW_LOG_ERR("Unknown queue type %d requested", conf->event_queue_cfg); return -EINVAL; } @@ -618,13 +618,13 @@ sw_start(struct rte_eventdev *dev) /* check a service core is mapped to this service */ if (!rte_service_runstate_get(sw->service_id)) - SW_LOG_ERR("Warning: No Service core enabled on service %s\n", + SW_LOG_ERR("Warning: No Service core enabled on service %s", sw->service_name); /* check all ports are set up */ for (i = 0; i < sw->port_count; i++) if (sw->ports[i].rx_worker_ring == NULL) { - SW_LOG_ERR("Port %d not configured\n", i); + SW_LOG_ERR("Port %d not configured", i); return -ESTALE; } @@ -632,7 +632,7 @@ sw_start(struct rte_eventdev *dev) for (i = 0; i < sw->qid_count; i++) if (sw->qids[i].iq[0] == NULL || sw->qids[i].cq_num_mapped_cqs == 0) { - SW_LOG_ERR("Queue %d not configured\n", i); + SW_LOG_ERR("Queue %d not configured", i); return -ENOLINK; }