From patchwork Tue Sep 19 01:29:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28886 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0F691B1BF; Tue, 19 Sep 2017 03:31:29 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0061.outbound.protection.outlook.com [104.47.37.61]) by dpdk.org (Postfix) with ESMTP id 5A2E31B027 for ; Tue, 19 Sep 2017 03:31:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PVR2jjjrajeqPofGu04b80LPGvqbcgs2JRe71zpk2zw=; b=A/zJyRqhyMFdcUMojnZzt8Efs43fxnhCzT85mFEazeP8UJXcFEptHtSVf8Pjrxcked8LO1gi/LmmGHZOjVbbWwYL8tVR4Y9IQ+a1IYx4loDErEzhIFiTzRASl5OCO0TrKKmHSqE4wD/mpdBFynksVcfQnDt0FCqjdKsqwQcKBkg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by SN4PR0701MB3838.namprd07.prod.outlook.com (2603:10b6:803:4f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:31:14 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Mon, 18 Sep 2017 18:29:51 -0700 Message-Id: <1505784633-1171-12-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505784633-1171-1-git-send-email-rasesh.mody@cavium.com> References: <1505784633-1171-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: SN4PR0501CA0015.namprd05.prod.outlook.com (2603:10b6:803:40::28) To SN4PR0701MB3838.namprd07.prod.outlook.com (2603:10b6:803:4f::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc5af804-7b22-4843-c51b-08d4fefe1e59 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN4PR0701MB3838; X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3838; 3:K9PbxXFQVxV5sn7g7E6ZkJZNumltkT5gMVwqiYYDGU1wILC4Fr1QweVlzhG7Ilo1UIgTSa//eCFEosCGNrsqj+/swk/StL415CCc8iyXCVVMfiullvj1LY4yHeVYLxXomBfHQGC16xJvINzRk1i3FxMYwTzQFhc2xVGq+6aK/yy/i/xmGk+0qxCmXtnXB//L9uzIVW8cLgO6WQ6tO723birF3pnDFyFoLrP9T0THgS0Oaqi/U0ZFTZfBETzgTAF7; 25:ALFUgfxOnNCFhUMF6vL49SeeCkXyWBPDW9Y8MIEq/LmtJObg3x+i2AH9ILRSeSGu3aybN6d6Xc7RVJn1nbSRt3nz3iaNGyVwVxuoygBKekJQBDUHFiAUAGaQbWMH5ooOjF0eRXFVCB3xB0npT5ehUh82B1HsqER3YRrnIiJm9Qh06+bRFzdZFYYuxkKm4FZjFnHCDQj38iek/jo6owLGsJv+K8xB064uwj9r7xpKbivTPXtN8c5SBdjCo6pVnC4fCl/CIqcdfrbvdW132tPs6F40GmXIQ+zFEfUqICYS9g4FIc7XTUqzOoTn2tK3QuiMGPsbFTUowEhEQ8QP+rA8aw==; 31:rXMekN3RFOXojzTUYw21YZMh9YuUaDLdg0oQlM5tSFsL1GGAStN88T40Ka8ilMmYLEgCBt9hqJsRmWj5LIvkiLS9fU5/IWHuV/qAnltetsFyfvBpMo1WDt41qJRZ9eUqg3oDSC8s90QCgDh0aRm0pC/dDB+hy8BKXe9a+JArsKxA/lsF9RvkZxNQ8SAr0RdhQozk+8tLm9/CV2wE/hQ/3mIL67vPNsKbrlXAs6dRAUc= X-MS-TrafficTypeDiagnostic: SN4PR0701MB3838: X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3838; 20:zQYK6a01aGI7kNrPQ/3Ycu42Vky74MSOF8OZrHO84har1lErNX8Owjy3j2dWYzxO+F+CtRzDRGJfjVy6rUQj3NEF6rjdQ3txFrO2CjICuDYT2QGVXdGjCoPXkQiSbadHG8UrhU8H0lDyM+Ja0bnBva7XsNnNsuQnYgDK7LwvURXdwADDIeMpdH1nf//y5Kj6NYYF6M7mML8qL2laQDqWVFs+Ef3gCKpq+DpX35mdlktwSPXD/uBnB8+BjwdYsBwjHWpTi6T7m6PC0udgpDRdqCOq2dHRIqToG8EePB7BF7Zc7LFExUPQAu55Vj5DQcI4s+wHaDO7HJtEo2uO5T2dbaXyoz+1H5PIFtXReVJeNV1YohyrOIfMeyVV4h4RtpEKFqQTDzIjrAVXjWuiJ2I6jxj0W0maRfyojpfUIbo2lUiDhk3Wd3jYu8xhTehw03uPhCUCqzGh1RCLw7oJ+byp77o+CSZWS+UEh/uYsvbxmMO6NX4bNtfHli9zW/8Cfn57; 4:bxFy8aStJpEqyEiDTlPkTuYGmGAzxEjwWUxnne9G3wohd4ydv50v105j5zBurwWC6KwENj8/wFPFoQgKnT/YyICDXTT2iRCvM7ZeH4hjIJ8OKlSUM5DolpnlyZvNgo3BDne/vV9Iqf8q5o1RYfkqgqtpM0EBkDyQK9NGKHgRFJqlCINdxW7a15UpKdgVXKWbCh9aWlZO2gTMR+PEk/jjC19ChhzF03ZLJBT19QTDv5SHVEbSUTPSNKiLQG8DiZOP X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN4PR0701MB3838; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN4PR0701MB3838; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(48376002)(33646002)(68736007)(316002)(21086003)(16526017)(16586007)(72206003)(36756003)(478600001)(97736004)(86362001)(66066001)(25786009)(69596002)(47776003)(50986999)(81166006)(8936002)(50226002)(8676002)(5660300001)(7736002)(53936002)(305945005)(81156014)(55016002)(50466002)(76176999)(6116002)(3846002)(2950100002)(101416001)(4326008)(4720700003)(2906002)(107886003)(6666003)(189998001)(106356001)(5003940100001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0701MB3838; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN4PR0701MB3838; 23:lmIEdYgA8wdwni2fZ8d1APavZ+eNWZVAKeZ0uLo?= Wg95HodUspVm/+nnEpfpc4iW4Hq+3bnomI1BmqTdANadTlnSbi3rn605wEaKkZ+GfTOc2bfcMbF2qNylHnL5MsAKdKhSOHAApSdgkPycFZHCx5Gz3mUKrprjiZSx0jegN3FQTLZkWXe2dzef9ZdeFu5B0NtAjMGS5TSfObEHm5Gf/hYJkMKP/q08iaT4kvz8GjWhNaX4xq4ILdWX1N/yZ8S/vfyHLLl0006K778loUHch/kxb6TNs5jHLjBDxw2w1C5MTwEIMWNbEO2eWZACUCf4Ia4qiGCuktEV+ytQuVMUmemBvcqdNj4hdMFVYcNcZHstDtOjKMmrTYuIPNAEUU1r0RjHiach+FrHXPhpCeury99RZppvw8f9dSZ4o7f1cKB5CiD9GPFOiagZIdZ5hK6+23b1b73WsX+iHABR2R+8/Qc6BJEKzU0imBRx3/MyjJFjG4zAuYQVzVt6p9mEm8XPTtS+RJTmEn62cdcqyA8Y6tBMFQ1CMAnwSIbnWcRxcucvi4RMfx22H/cWG/clf7E1jzvG20w9iJMaEOtf0FpGBMo4URn6jlgSswkpf1phpaiS/IbMh2e4wCeYvDujj9HrpERWlR1n+q/EWEBObp6gA2q2+NqTLEHkhoL555hjpooDu7glFkVqqlx+UfHTkPNXlNi1dmUeNRjl0Z2Du5hK9LPJJgxvJcRXbNQrDghFuI2V30n8gaG3x0CCs5ER27T/WtXR+xsZh0pCSI16WTQwGgJwt8wDbBr+dLmDC0Cb9Xrxosko6dvdYoguDWBJXi+VtFlzh9wct6SzbU9hseUDDFckatXy+pthPmMC+xE89gbA8rw5oMWzv4aN7X/VnEVDa9r2O5paltFg1YmD+9PqBRBzm0n94ww3Z3XTCJHUNKf3Z4XJc6iydlcHs9r5qsScHxC0vdwnTO7eosqdg7DgAZqtRiZvkQ00MqoQkwg42ebrNFE17qBu6kTIR2TJXM2nWk9pF+dIcW0UWGSp860fZLCZCce7PMh90osMoVI/G26nLXy+ObO520QHdOB4Z8ybLR9yb7glhdXkjn+55dZqmteIVjS4II64ES2kyA9yvHNA= X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3838; 6:t5GBTMfTVnaaCt9QpHiGfzzWInwtZWfPsbfnUmL5GhQv9x74AM+a84XkOoDicM6KCM8TpeoD1jt6FzUGsaI9Bj7rKG54MafwNWoIm0ElS8LYp4LRbr/+lBUBPb8ZicyO6MQcpHT0WjO/sDVhQcZLyngy7hGW6yPI6uJnff2ZBLhCOQcYTep/OEDGlb+00vKup0pNsVNOmbSWqpUMWn+qp0LkN/KJ/2oEEXmO2J/kLZOptoq2gp2xl8XUdaATWqxKKrWabGC1loIaQvxexj2i252GG2qR71GdCm6L2u5FNduK0U/Oi55diFHUo6mVQtd6dwUMa+/azS3mR8nqLIhiBQ==; 5:PqxwzJfKDhScrEp8If0oGwdKsTBOtRsT7yr3LdRNt8KIcXfmUED9EXOCCKPtAqlGqZBHIlEgo6cDPt0n8l0e1Fi6x0WYoReLUbZNVAxemyxBcogEzfzybYDxwxfAcPRCb9EYy0+sSSnouU2ZCaZx/A==; 24:VodhFO1ltMKGIh/W19pNGU4nh0TiA9cxDAcdMY0jp9YcNHeGthhPimzHIMC5LeL7oC7k+vqIUBwlMXG6fGTFpydiInCAgSc6BHByLHV5Xaw=; 7:Pt3gk0AByN2ho2uvLGyWeVMfxEpmknYcqJ4ITYlvF/1jEKr/qvksTy/KTzthcSzGZ8m/TZdTCiD+2hG0fpq2h8hme4/zaKgDJ7gheBa4gG1nyalrCfBvsatVrqQSWRfOHMYHafsogMqaKlXm8asYyAx+3O5ctW2wimmbTMf8+ExTJgQ3/uR1f5RbtkU2z7a3aJuSz5VHg8UfQirMX4wmlrCClrThPt++RWji9gMzrNo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:31:14.7617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0701MB3838 Subject: [dpdk-dev] [PATCH 11/53] net/qede/base: add a sanity check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add a sanity check that the offset being used to access the runtime array is not greater/equal than/to RUNTIME_ARRAY_SIZE Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_init_ops.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/qede/base/ecore_init_ops.c b/drivers/net/qede/base/ecore_init_ops.c index b907a95..80a52ca 100644 --- a/drivers/net/qede/base/ecore_init_ops.c +++ b/drivers/net/qede/base/ecore_init_ops.c @@ -40,6 +40,13 @@ void ecore_init_clear_rt_data(struct ecore_hwfn *p_hwfn) void ecore_init_store_rt_reg(struct ecore_hwfn *p_hwfn, u32 rt_offset, u32 val) { + if (rt_offset >= RUNTIME_ARRAY_SIZE) { + DP_ERR(p_hwfn, + "Avoid storing %u in rt_data at index %u since RUNTIME_ARRAY_SIZE is %u!\n", + val, rt_offset, RUNTIME_ARRAY_SIZE); + return; + } + p_hwfn->rt_data.init_val[rt_offset] = val; p_hwfn->rt_data.b_valid[rt_offset] = true; } @@ -49,6 +56,14 @@ void ecore_init_store_rt_agg(struct ecore_hwfn *p_hwfn, { osal_size_t i; + if ((rt_offset + size - 1) >= RUNTIME_ARRAY_SIZE) { + DP_ERR(p_hwfn, + "Avoid storing values in rt_data at indices %u-%u since RUNTIME_ARRAY_SIZE is %u!\n", + rt_offset, (u32)(rt_offset + size - 1), + RUNTIME_ARRAY_SIZE); + return; + } + for (i = 0; i < size / sizeof(u32); i++) { p_hwfn->rt_data.init_val[rt_offset + i] = p_val[i]; p_hwfn->rt_data.b_valid[rt_offset + i] = true;