From patchwork Tue Sep 19 01:29:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28882 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 151EA1B1A8; Tue, 19 Sep 2017 03:31:24 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0061.outbound.protection.outlook.com [104.47.37.61]) by dpdk.org (Postfix) with ESMTP id 3939B1AEF0 for ; Tue, 19 Sep 2017 03:31:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DlwyKD4bSnhHpMXeB6egw1k/gnokfyFtxD0z9J2Ntmg=; b=Zc5rmWn1Ui6sEB54Wlklu0DHzyaL4mKd2bOMM5iqVLOtfgkjm3gsUmF1jo/81vHQdtCiVeaxywASJ1/NA4K0+QTKeTqhT0GJxC5PcikyBsHSjeeh91RAm6DAivXizniclu9n0O5n3xJtEjmaDvl7EYjK2nNiIv0+9zvUZhEnZ20= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by SN4PR0701MB3838.namprd07.prod.outlook.com (2603:10b6:803:4f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:31:12 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Mon, 18 Sep 2017 18:29:48 -0700 Message-Id: <1505784633-1171-9-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505784633-1171-1-git-send-email-rasesh.mody@cavium.com> References: <1505784633-1171-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: SN4PR0501CA0015.namprd05.prod.outlook.com (2603:10b6:803:40::28) To SN4PR0701MB3838.namprd07.prod.outlook.com (2603:10b6:803:4f::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de250d81-5a1e-4e17-f825-08d4fefe1d49 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN4PR0701MB3838; X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3838; 3:zBg6G+5BIU3sqI28eqKfGbkCFhpzLaiw/Xbr/viR/LhTGypm1edgTYhQptUMJuw2rJalX6VHkYt0YQNVO5QuOfu0Db7CsAOqR2M5MbowK7+Ut2WwIY5jtXVRCBtYUTloGWHvkVe/x7UgXj7yuHXjJrXCl9v9hbVQ+AMdZRu4TtG7l7iwcPoUDtSK569rdB0HYJtPBUMTwlf6bdKziEiaRyGHr/JK57T39dbgoB2tduce1wgAh0EnbalANlnX7bdm; 25:XY+FKxBTlp8f7Y8X7DQTOu2mJrT1u3g9DQyL2iv2+GCbRGr9gey4jy7VELkHP3wlcdmrQyDnxUfX5z5X5AlztBokSrrJjbJb65qQZZIESdMF4jb9GX0vROW0L1rhEWp3civxqjLkjfkl8AA7obp8WPnb5YeSqfnYK2Tip/a1Ms0cshuA1kSnLqdRFNyIHlUbChiXMCbRI/ZHHQcABdIw+1QfUP4dg5UuipG5EhOCNJtBbBjPgybsZ/UYtdin66hs1ijzNL2W8WvM5ZK9msDR5fCAs1/Oq6vm5yQWzwV8s8D/g2gQV78VRThoirD4feLA/wE6peM51se1RUloP5i5nA==; 31:M30w+J8yQEVq3T5aKfzwtM17Q0gVbiznDpPwyEnOEceLfnToGAUfMjFYTjT/La11wVh8CuqwPByQ2u84Sm7GgqR9YLqLspBZ7bSRbgWQAb/l27vKzIdp7yKCTPlI8Zt2zEiVGxgylHQbPYqW4hQWR2PG6bR8uBABRq98HGYGqMYfHZ9+A3IW0qAKc82k76nua3w/imDzcwBU0oTP966kj6AOIDmStydzQFl3tRuDba8= X-MS-TrafficTypeDiagnostic: SN4PR0701MB3838: X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3838; 20:zoRvvPxj0iNnwVDRHjA7B1tZKh+qwEZBf7jmJY3Ayjpt0RjDc4nzo1DlmDCYJEQj/TUqEoK6AdVpSA1998Nd8248Ufd4j3EmQN0XKaTzlSysNg0M/rQ2hDQ2aP7RjiqMBxI7oY2iA5ZyXftgmoLPSGyMerkhmzpkXheYqIuDmEUiG8HrfaD2Z9WX4m7qXb/U2ZRCRjSRG4IV+U36b5iOQTX69j6DVCAZneJSWLhAtmt3PKMADQUCpYoFd9W7fKODe0N2mneZDdifnhFLKisxJJvxBGA1pw5U8VeryELd1+As4nT8Hly/29d6nc96qb0UTj5+bufxF87XZSjqSH1W8ab12N1V0PrGoRNdJFzw8kQreL2kkEUsVU96oJjJ17g5n1JezOwTaR5AbKeBHdd1aBEAJHMRV7RDKhA/sLzcsxsIQ70TfQujYU2V++86jp9pzvFbY2m38Dk2n/VB/BSHnZE7ZS/NqncnD5V+wEyc3093HZ1ANwxrGQAzsaEKMTmD; 4:+eQzyHzlQeBT5cYh2QohdkLx3juCUWJxd6exc4nowe4sJlHZ6EmqkZQfe8awPyTsW78cmcCiX1LtF2I28pBFBVnSAEHRbCtSqIiK+jnsyyr/XsjzcBe+B3KhU60Joz29sMIo/17D+8/NXEK+ONyUyCeqYQf9bGF93SC3tBxTwJfb7WRAbxW7kBMKvvY+zd/MRRQqPxPar7CF3xOZ14pt1fe6f8x5DWBmcBwdUXtycZ8bs8nWeT696Xgiy342ZoSO X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN4PR0701MB3838; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN4PR0701MB3838; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(48376002)(33646002)(68736007)(316002)(21086003)(16526017)(16586007)(72206003)(36756003)(575784001)(478600001)(97736004)(86362001)(66066001)(25786009)(69596002)(47776003)(50986999)(81166006)(8936002)(50226002)(8676002)(5660300001)(7736002)(53936002)(305945005)(81156014)(55016002)(50466002)(76176999)(6116002)(3846002)(2950100002)(101416001)(4326008)(4720700003)(2906002)(107886003)(6666003)(189998001)(106356001)(5003940100001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0701MB3838; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN4PR0701MB3838; 23:bnc/WCuZ0QhtDLqoqDRfCen1uqVy/ZUfy6RgqUN?= lDZmfGsMA/GHNPNbQfGYDBKbNIpIQ5tCvLFzlrCREX6DfHuiThzTKqybxbZgbhDCVFUspSlLJP5PizqF2PgElZVJYF0jX29ce8Kos8/vlXKL/PFbqaS4UHXKwj7iVyGoatlnBAQYQieGxQGnvTIM3QRGZpaDaRGg91Yd8I1xr9182cUEdj5ny++z0zuBtr6zQ/raaIJEqjAcSkdX49RUXeyrQnXEXATPfGampTcbrUH9gAJjgQCxLYReBjxnxDCbnppU+qPwylnF/4/P0X0C1nFyuy7O2UqLSX/xpQdcABU/RhRviSoqPTJerx+MMxHidd4/61PAwdZ17jO6Mp5lp6VRto+owMPNjZ8Q6PM3cEXZ97bkUauuy9zXhplXLLMljeUPMYKgopewoG2izjR9OGBeSOGwxOR9WhnKRv1+MtPzYjMZ+1BwdUd78DsZgnmIjDV028mnqtOuzN/IPGusZ/33FGj44OGN4tbIQTj2mJWKTnSWerI3RRLCB6Rm+7w0g8fXFGj/sM3irzo5qbC7HNmWOLWtwHJiHETwFx9wLCylX8bOrvEVQZu4pCWQx9dqifKpL8RixIwH1BVU/RZ94rBpl1SEnJWK+r3c29kKYmaL1XI6fGTAoSY24+AIa59+w83Ffbg/3IaaX1y5/NCIsqduCpTp+yXi0tf5wwW+rM0s7nqNXHH42x82FtaE6OVcQTe6PPgnVmaQEwO8GnG17s2pWvWIWY9n71HkoCddpaz3JxVkLHSigFYv1eLczdW39oL/BRbZfuzRUQeLHEqlukIrvqoS2Q1uwyCdE+dFqO/9XcoTSDevHxsROKTC9ZoN+hD3xejFAaSoFqjuKMbqEoOJ5NP+XF4XakpOIB/43qaGs0Hd1dHaVs3UwQVH5a5CmNWZHy+3zrBFYi9f1TtJhcQPQPVIHJRigKyy3LubkVpFdOlDW8Uv1nXKXamVfbfO73k5txuB8mNZ2bXb9g4Clw/xhtDHH6zYfkSaU/EgonavNgrkeKSA1s4PhROyy3HAkW7aTCmtw7UQa8bW2OL4qXcxZ5kfY7/21zYi887fSN2+cihyWPSDuLBQTfFFhRzsDkeevr8siVD73dasvNUulGYVp X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3838; 6:UchTPsmzQU5H25j5uvCuwwK15qyPUocsqJXboD7MUkBgB7QFB4WIue/qiYK2mVHWj0CyVvX3cvO5IA1j/cpWHN4l6WD2cZUi2qykF7bCYzSzOhmpnziNi9tQJHLtiUvu0Q3S8uRFvzqYDi6CRKA6rdOEQ5hNoYdofGTAc/WJ0KCwhDD59Y4M15JPY9+m0c7EFbAXQUgWBtNMyCrJB4/KccBXU3BXIX00ch+BTauwYc8ckge7VdRgXrxTqPpJM0eFjwZuLbfAuea8yiLy44/bb3kUIh7OlN86QlL0lMHiRabcXjz9Fs1k5CocqgylrdOhHy7TDq5XkAldeR0CPmmwzQ==; 5:+TwjDlOmVjoV9AKO2t839YuC/q6fBCqpmgg1SYMd3vFGOmibBCZ7Jw8Yae8AtoBmLwsUuuZesEoAT9t2oCZwclrpsG0jwGhTJQ+neFanAYsPt+0tyJHuO9zH9xbagfUasvzv2PlYaS4K/Wct136I0g==; 24:y0/94EiCkm3vXLHKq1Ejf2Ew/YggpEZeizK/XObFyfIfzx4R/9AtodU5/YwfHZ8v6okxNlAoMl9SUAavN/HpYifj+4Pi1oGSVELLq5bI5+c=; 7:Cl9K3aBoKfCXFT5VQiBChJBTmPFIDhQEjXtX8tqgyrBUUp7YC8JVUahhqyk+H+BVKoXjBebmNVkwiMSpmYcLSpvZAjYpnwRCDxvn+HlYC9u1ueIYmh+tWTuTpT6pyJhbTeIPxJcS3uAYp88TJhiSq8XRGmtfYdTO9DANtiZWw0tidMZGgSHqEfrU7eKYPVUiIU43SufN4i4QnnSeKinf2oso42+tu2XIor8UQ+I5mjA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:31:12.9961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0701MB3838 Subject: [dpdk-dev] [PATCH 08/53] net/qede/base: add API to configure coalescing for VF queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add API for PF to configure coalescing for VF queues. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_iov_api.h | 21 ++++++++ drivers/net/qede/base/ecore_sriov.c | 89 +++++++++++++++++++++++++++++++++ drivers/net/qede/base/ecore_sriov.h | 3 ++ 3 files changed, 113 insertions(+) diff --git a/drivers/net/qede/base/ecore_iov_api.h b/drivers/net/qede/base/ecore_iov_api.h index 50cb3f2..4fce6b6 100644 --- a/drivers/net/qede/base/ecore_iov_api.h +++ b/drivers/net/qede/base/ecore_iov_api.h @@ -693,9 +693,30 @@ bool ecore_iov_is_vf_started(struct ecore_hwfn *p_hwfn, * @return - rate in Mbps */ int ecore_iov_get_vf_min_rate(struct ecore_hwfn *p_hwfn, int vfid); + #endif /** + * @brief ecore_pf_configure_vf_queue_coalesce - PF configure coalesce + * parameters of VFs for Rx and Tx queue. + * While the API allows setting coalescing per-qid, all queues sharing a SB + * should be in same range [i.e., either 0-0x7f, 0x80-0xff or 0x100-0x1ff] + * otherwise configuration would break. + * + * @param p_hwfn + * @param rx_coal - Rx Coalesce value in micro seconds. + * @param tx_coal - TX Coalesce value in micro seconds. + * @param vf_id + * @param qid + * + * @return int + **/ +enum _ecore_status_t +ecore_iov_pf_configure_vf_queue_coalesce(struct ecore_hwfn *p_hwfn, + u16 rx_coal, u16 tx_coal, + u16 vf_id, u16 qid); + +/** * @brief - Given a VF index, return index of next [including that] active VF. * * @param p_hwfn diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c index 1ec6451..3f500d3 100644 --- a/drivers/net/qede/base/ecore_sriov.c +++ b/drivers/net/qede/base/ecore_sriov.c @@ -3475,6 +3475,7 @@ static void ecore_iov_vf_pf_set_coalesce(struct ecore_hwfn *p_hwfn, vf->abs_vf_id, vf->vf_queues[qid].fw_rx_qid); goto out; } + vf->rx_coal = rx_coal; } /* TODO - in future, it might be possible to pass this in a per-cid @@ -3499,6 +3500,7 @@ static void ecore_iov_vf_pf_set_coalesce(struct ecore_hwfn *p_hwfn, goto out; } } + vf->tx_coal = tx_coal; } status = PFVF_STATUS_SUCCESS; @@ -3507,6 +3509,93 @@ static void ecore_iov_vf_pf_set_coalesce(struct ecore_hwfn *p_hwfn, sizeof(struct pfvf_def_resp_tlv), status); } +enum _ecore_status_t +ecore_iov_pf_configure_vf_queue_coalesce(struct ecore_hwfn *p_hwfn, + u16 rx_coal, u16 tx_coal, + u16 vf_id, u16 qid) +{ + struct ecore_queue_cid *p_cid; + struct ecore_vf_info *vf; + struct ecore_ptt *p_ptt; + int i, rc = 0; + + if (!ecore_iov_is_valid_vfid(p_hwfn, vf_id, true, true)) { + DP_NOTICE(p_hwfn, true, + "VF[%d] - Can not set coalescing: VF is not active\n", + vf_id); + return ECORE_INVAL; + } + + vf = &p_hwfn->pf_iov_info->vfs_array[vf_id]; + p_ptt = ecore_ptt_acquire(p_hwfn); + if (!p_ptt) + return ECORE_AGAIN; + + if (!ecore_iov_validate_rxq(p_hwfn, vf, qid, + ECORE_IOV_VALIDATE_Q_ENABLE) && + rx_coal) { + DP_ERR(p_hwfn, "VF[%d]: Invalid Rx queue_id = %d\n", + vf->abs_vf_id, qid); + goto out; + } + + if (!ecore_iov_validate_txq(p_hwfn, vf, qid, + ECORE_IOV_VALIDATE_Q_ENABLE) && + tx_coal) { + DP_ERR(p_hwfn, "VF[%d]: Invalid Tx queue_id = %d\n", + vf->abs_vf_id, qid); + goto out; + } + + DP_VERBOSE(p_hwfn, ECORE_MSG_IOV, + "VF[%d]: Setting coalesce for VF rx_coal = %d, tx_coal = %d at queue = %d\n", + vf->abs_vf_id, rx_coal, tx_coal, qid); + + if (rx_coal) { + p_cid = ecore_iov_get_vf_rx_queue_cid(p_hwfn, vf, + &vf->vf_queues[qid]); + + rc = ecore_set_rxq_coalesce(p_hwfn, p_ptt, rx_coal, p_cid); + if (rc != ECORE_SUCCESS) { + DP_VERBOSE(p_hwfn, ECORE_MSG_IOV, + "VF[%d]: Unable to set rx queue = %d coalesce\n", + vf->abs_vf_id, vf->vf_queues[qid].fw_rx_qid); + goto out; + } + vf->rx_coal = rx_coal; + } + + /* TODO - in future, it might be possible to pass this in a per-cid + * granularity. For now, do this for all Tx queues. + */ + if (tx_coal) { + struct ecore_vf_queue *p_queue = &vf->vf_queues[qid]; + + for (i = 0; i < MAX_QUEUES_PER_QZONE; i++) { + if (p_queue->cids[i].p_cid == OSAL_NULL) + continue; + + if (!p_queue->cids[i].b_is_tx) + continue; + + rc = ecore_set_txq_coalesce(p_hwfn, p_ptt, tx_coal, + p_queue->cids[i].p_cid); + if (rc != ECORE_SUCCESS) { + DP_VERBOSE(p_hwfn, ECORE_MSG_IOV, + "VF[%d]: Unable to set tx queue coalesce\n", + vf->abs_vf_id); + goto out; + } + } + vf->tx_coal = tx_coal; + } + +out: + ecore_ptt_release(p_hwfn, p_ptt); + + return rc; +} + static enum _ecore_status_t ecore_iov_vf_flr_poll_dorq(struct ecore_hwfn *p_hwfn, struct ecore_vf_info *p_vf, struct ecore_ptt *p_ptt) diff --git a/drivers/net/qede/base/ecore_sriov.h b/drivers/net/qede/base/ecore_sriov.h index 1750f0d..ade74c9 100644 --- a/drivers/net/qede/base/ecore_sriov.h +++ b/drivers/net/qede/base/ecore_sriov.h @@ -133,6 +133,9 @@ struct ecore_vf_info { u8 num_rxqs; u8 num_txqs; + u16 rx_coal; + u16 tx_coal; + u8 num_sbs; u8 num_mac_filters;