From patchwork Tue Sep 19 01:51:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28907 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCC291AEEB; Tue, 19 Sep 2017 03:52:05 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82]) by dpdk.org (Postfix) with ESMTP id 7F1EF968 for ; Tue, 19 Sep 2017 03:52:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=39oNQGyUOk6BRr/yoGxBMVzzCMTGS9iFD0fzc3Bmqcs=; b=nGCXKI77oeMYwmpmdsNN1knhXTyaZtGuM4UQ/npEZC6BPBBDZbgh5FrvLg4V2xA4CB8we6it+LU4Oe6nqoKbLE8rPrdws1CLmRTU2taDzomhuVm5K8dQCUt3fvnmG05MnZc3xUIoQQtv0IkQ2+dyxwk/IdlrMQz9L6OXEnqGgqw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:52:01 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Mon, 18 Sep 2017 18:51:22 -0700 Message-Id: <1505785903-1741-3-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> References: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: MWHPR14CA0048.namprd14.prod.outlook.com (2603:10b6:300:12b::34) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0319816-32b6-4605-e0eb-08d4ff01057c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 3:FT9LsDJNY15dQwNOktlL28E85xb2yt1OL/ooIN4BqbB8OyHqwQPGgt8Qw0uZJpbPyhzGCiuk9V+WvWHuun/DNm3ME+ekqHHglgp7HxCsrS4MCAual6iUZJWASLRi7zF1rA7PYMBUjzWMXmtrQfDfl+56HR8zD7lAV3/kgMWPAfK+G5SyrbJh4O7pcpudfUGwdnxwrCgXv3gI4J9MSx6u8qzCtP85Oq0BFwuMGozwTHCbU1eDc1OEwMYSKr5bCuQL; 25:8lBSpJycC2P9qaZsC0ruP/V9uhN/KcAnNZ9M87Jq+5qyU66VWz6MbbLTHceeovPS0ShAYHs15HYP2hRQSplPE6hwus8TXUs4glQ6tK4SkDHfF6Rz+eS5KX6JS8csilJjR5xDwx08mFaVFkc2EK33JpLbWu5kmwOCHOCiQNOpx8uG5hg0hiX/ig2FQUMkrTiKgW/BIJx9YuQKSP18NMxMmJEKoLgBR9HyQGXyb6hpzta7jpm3+aAzNjkBfTlgw3HWJiqwfdMwA+bd78OVJHtLfA6WFbfev8DulFK6btIG3qrjV6hTqahBmIBIKXgwI30kJFLe2A3Mk8BXUciwMU+4Yw==; 31:2bdVHI69PtDvG1en7bf+Ghxv0QZEi5WhJzwBtOlV7Ta1+xVOu3c55g76rIIHIXyJoYjJSKw6BIi3RIQl+nl11+8Lg8HfR+b5ytLWuRSsbq+4oTVIKFF0FsFcrFRJSg+aKV1kgxcB0+nOtD32pOF64kX2NN1Zg52lVUdJ5rKu0n8d/wgcGiCcvF3REIbJQsXV762Nuw+N/rU65p0xLtrMSN1fRrDCMTH1WMFtJqR7fXQ= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 20:885wtbu4Sn/KKKBb0fhkewVrsjv98fsLLQB1NmydpDkE57Lm7qerGMaqx4Ok4Kif3J+ydDEFiVAoUVGH8TEnxS+xHaGdJGTk+mz9FvWJUENn1IdVgLr3QJpYNsY1YcuLcSbOrhcZH7DiGA9eM9NR3jkcRx3lVV+aOgCX0fuQchVk+AU/3/zAKhX6U7ck8MbZiI2cSu7Bw09pBBPqhZ2VfnU39q6u/RojKEOxoUDZuPPrxwi7upqqKgeyBIBaC7r3jCuim62KdmZnfiZLVMLfvXk4JN/8RAfkAnP8M7dh/wSDXCG4ImVA3PmAcvnoqu4yGJmSAn7ZDqbLAiMMCUjse1o+p/aN5Wl3l3uuAgBwVi2zDZqRuaJEZAJ6dGG7xlFZg1GzdF2/Cla9c9CcfQfHpyJMayW1nw1TXVV6uHTNdfjQ9gKMquwVImRZPWpDM62VOlZJ/+CRqiKIEcRYSI+G51IjTlqjRB8oU5vwAdZn9guv/u/svC6696Lkn6D9yiN0; 4:tlQFQf5Qot9JfQ1C+8PFMtCiLRwkk4MKD9Cgsqcx0PZGkJGEosGwbtry45tkMBgsYRezwjCOYajRXqBM3P5mVPi00TpTfHom0ZZ/71P9WBXDjjQwrcnpM3pNaoQTXM0S06yG6GYAe8dOEhgUY61/HbE+QJdw2BPdbSOcrQ9eHCRCo2EU5FCN+ii9pL0VPjMa1Jql3MWI0SPXvyxuyb/kD6QjT038DYWDFmc9qhnKNYDrGDpmKbjB5BLMaPPy5I/X X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR0701MB3832; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(72206003)(106356001)(305945005)(105586002)(7736002)(36756003)(2950100002)(50226002)(478600001)(25786009)(6666003)(3846002)(4720700003)(55016002)(8676002)(189998001)(66066001)(5003940100001)(81166006)(81156014)(50986999)(107886003)(76176999)(316002)(5660300001)(16526017)(16586007)(47776003)(4326008)(6116002)(33646002)(21086003)(86362001)(8936002)(97736004)(68736007)(69596002)(53936002)(50466002)(2906002)(48376002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3832; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3832; 23:bpJzKniM2FLJmalhcltODHShLkxKqTQYZd+bBdS?= H73fbrTCKQPge1cTrHqGB/O0EnupRrBxGw8guj9ioHXVZAE+CqfG9YQCidmcwyrqgVloPiyC0N2SsD77Xw2qTueaTF4yqyv1pvzloWKWi61FAGmpTSfzFY5dLpsOGkbKtrRgNzgGUv5d5gK1b8SqIKwHdNSYKhqIZtJpVaiRDCMnkmzwlOKxkc5r6LWZmYCVUj9vcoTLzP2TaSdNPr6NhyxyL3f5OamtDw5a7rAWDs87SpNLwu8+duTNkFGEZVrV1xS2M2CdXOjyeJfPAUtA5axsjO0DVfHQYeqpNCWaxhM5lRVhP18BQwDmEZfDp4jmG9NAgmX5VKHhp7xl6dtBwdCyb8C6FPoG7YkmtXc42Nsl9npOObAgI1hbhERW+dwZOuUzCViTBaqd78v0nJANZFjJx3tqQHwH8GN8iWugksm+nPI40K+TjeDfrzox6gu2RdtIHbGyfzSk6+7KMFGvbviNDg9glQn9kprHaZp0Vupim10qwhZUVShyttoGCIE14DbBmQ080FF6KA72WOOz4lC21Da4/AcCnrvOfwB/iuV1QH+NIyK7Y/OROXrZD8GFDAjsMWAgIf3tbIDOfssRITmf4S3rA9/d76cS5CFf4j4fxrbiBbS6MnWuPOzWlxjYFdVtPtCgdbDWlill2T3fhlYGisRSQ/OSxOpXVd1H4awDHwr0ESRbtG3eHn6YDNlgxq4u3xL64cmddpCkQJNThl4e7IMWJ9bkgO4H0FoWMHknpYEaWTqHMGp2Fmyr7H9MTzgVXk9M8PHhmuhvvLMISCzWER14A0O79i60gOyZ24GSA+2fqTLmErbvSxraNQbPNkIT0y1pFZAWEWXQh90POXeuuW30Gr9KaIKeh6mncqSP/LadL2TqZf3Oip4Mm+6SWbpGFNviXjUfEt/enVrklRQgsbzY/yu+2N+6dFNU2RZNTt15XWJu2KKgSGutLphoGxn51oKaIWlYovbeNZvZntmWzAzwp9FnCaYio8IzQLT/T+CSlhSdOL3JslQqrl8l5RpoDG23m3NWh5WNwlm55MJjgP8P3hAVa4x+jyM6X9m+suHhHyudBpH4sKvqnVgrh9R8= X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 6:L/MF/Zmk3IfVNwRuuk4HgNzaEMMs8s2nSnVG5bsIoHE7K14NSo6l4cTOU/DUVSSfrqqNnqpKDoK0V/iwhq7btFONMh+oq7kX85jRRudDnOnh7XaFOkcB/2ndfb+8aHgHp59FZA+E3u29yj4XurfB0ocDriEwhWREJsMEYcvmaGsiZUSs6eyY1OHi6/FEQWKPyswA/tl0fbOu7PiEaD2uENXwrfNTr46ZkNb1qqkLkAKABVuV45woiQwRcSLyH+RJG/INPl4+6OSkkEgK/xIcNDfOqTbkPiDwVIkSYZqlmW4QX2ull2syxrRYzd5P47jh5aRux996qdLgxneT9NTn2Q==; 5:bZPr2dhCk3symJcVBQ4O3U4Nj9mnzo71oU94Hqh9Ypyav1VqhqhBIzBgrcdfzRYcmd37fAFgMR+KV3MBfUq7ccgWc5uV0lFHvSoh3F6tuf2gJzdhs2dJP0ODMSZ38BCnB51Z+7Bj7xkACy69m1W5nA==; 24:+V1H8RY/dKihitzGBpMSO1N3IJ4UiiRO6VKjPxOOKzyS5CqSKEQ63RpB5hT8v21ou45k++YqxNBqGOd8H4XYjmncLQJVSlpNfHxXHkHuYmA=; 7:6UKAmIQ6WaEaXnjAwqozO1Zw6x7hWjVbYQejk3huadKmJoi3dvpIOgQZFZreg8HAfP7xRUnhgpNYQeA34D9G+9A4U4F7Fq71dV57iYYJR/e3mjKBJF51oyauMN+8TQ6TE9DYbK6S0FvUm619esFnYShlAgavIZZkZL/f8F9gfZ8Gopz3Fwvasqx2xrSpTR4lyO9dcDCl9Dt7DdwxOtz5TN66KbdS9t/W5p1CyYGP3F0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:52:01.3984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Subject: [dpdk-dev] [PATCH 32/53] net/qede/base: use proper units for rate limiting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Change module parameter semantics to standard units (Rate limiting is used for DCQCN feature). Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sp_commands.c | 43 +++++++++++++++++++++++++---- drivers/net/qede/base/ecore_sp_commands.h | 8 +++--- 2 files changed, 41 insertions(+), 10 deletions(-) diff --git a/drivers/net/qede/base/ecore_sp_commands.c b/drivers/net/qede/base/ecore_sp_commands.c index d67805c..2f5d453 100644 --- a/drivers/net/qede/base/ecore_sp_commands.c +++ b/drivers/net/qede/base/ecore_sp_commands.c @@ -422,6 +422,22 @@ enum _ecore_status_t ecore_sp_pf_update_dcbx(struct ecore_hwfn *p_hwfn) return ecore_spq_post(p_hwfn, p_ent, OSAL_NULL); } +/* QM rate limiter resolution is 1.6Mbps */ +#define QM_RL_RESOLUTION(mb_val) ((mb_val) * 10 / 16) + +/* FW uses 1/64k to express gd */ +#define FW_GD_RESOLUTION(gd) (64 * 1024 / (gd)) + +u16 ecore_sp_rl_mb_to_qm(u32 mb_val) +{ + return (u16)OSAL_MIN_T(u32, (u16)(~0U), QM_RL_RESOLUTION(mb_val)); +} + +u16 ecore_sp_rl_gd_denom(u32 gd) +{ + return gd ? (u16)OSAL_MIN_T(u32, (u16)(~0U), FW_GD_RESOLUTION(gd)) : 0; +} + enum _ecore_status_t ecore_sp_rl_update(struct ecore_hwfn *p_hwfn, struct ecore_rl_update_params *params) { @@ -453,15 +469,30 @@ enum _ecore_status_t ecore_sp_rl_update(struct ecore_hwfn *p_hwfn, rl_update->rl_id_last = params->rl_id_last; rl_update->rl_dc_qcn_flg = params->rl_dc_qcn_flg; rl_update->rl_bc_rate = OSAL_CPU_TO_LE32(params->rl_bc_rate); - rl_update->rl_max_rate = OSAL_CPU_TO_LE16(params->rl_max_rate); - rl_update->rl_r_ai = OSAL_CPU_TO_LE16(params->rl_r_ai); - rl_update->rl_r_hai = OSAL_CPU_TO_LE16(params->rl_r_hai); - rl_update->dcqcn_g = OSAL_CPU_TO_LE16(params->dcqcn_g); + rl_update->rl_max_rate = + OSAL_CPU_TO_LE16(ecore_sp_rl_mb_to_qm(params->rl_max_rate)); + rl_update->rl_r_ai = + OSAL_CPU_TO_LE16(ecore_sp_rl_mb_to_qm(params->rl_r_ai)); + rl_update->rl_r_hai = + OSAL_CPU_TO_LE16(ecore_sp_rl_mb_to_qm(params->rl_r_hai)); + rl_update->dcqcn_g = + OSAL_CPU_TO_LE16(ecore_sp_rl_gd_denom(params->dcqcn_gd)); rl_update->dcqcn_k_us = OSAL_CPU_TO_LE32(params->dcqcn_k_us); - rl_update->dcqcn_timeuot_us = OSAL_CPU_TO_LE32( - params->dcqcn_timeuot_us); + rl_update->dcqcn_timeuot_us = + OSAL_CPU_TO_LE32(params->dcqcn_timeuot_us); rl_update->qcn_timeuot_us = OSAL_CPU_TO_LE32(params->qcn_timeuot_us); + DP_VERBOSE(p_hwfn, ECORE_MSG_SPQ, "rl_params: qcn_update_param_flg %x, dcqcn_update_param_flg %x, rl_init_flg %x, rl_start_flg %x, rl_stop_flg %x, rl_id_first %x, rl_id_last %x, rl_dc_qcn_flg %x, rl_bc_rate %x, rl_max_rate %x, rl_r_ai %x, rl_r_hai %x, dcqcn_g %x, dcqcn_k_us %x, dcqcn_timeuot_us %x, qcn_timeuot_us %x\n", + rl_update->qcn_update_param_flg, + rl_update->dcqcn_update_param_flg, + rl_update->rl_init_flg, rl_update->rl_start_flg, + rl_update->rl_stop_flg, rl_update->rl_id_first, + rl_update->rl_id_last, rl_update->rl_dc_qcn_flg, + rl_update->rl_bc_rate, rl_update->rl_max_rate, + rl_update->rl_r_ai, rl_update->rl_r_hai, + rl_update->dcqcn_g, rl_update->dcqcn_k_us, + rl_update->dcqcn_timeuot_us, rl_update->qcn_timeuot_us); + return ecore_spq_post(p_hwfn, p_ent, OSAL_NULL); } diff --git a/drivers/net/qede/base/ecore_sp_commands.h b/drivers/net/qede/base/ecore_sp_commands.h index 34d5a76..74f6a34 100644 --- a/drivers/net/qede/base/ecore_sp_commands.h +++ b/drivers/net/qede/base/ecore_sp_commands.h @@ -125,10 +125,10 @@ struct ecore_rl_update_params { u8 rl_id_last; u8 rl_dc_qcn_flg; /* If set, RL will used for DCQCN */ u32 rl_bc_rate; /* Byte Counter Limit */ - u16 rl_max_rate; /* Maximum rate in 1.6 Mbps resolution */ - u16 rl_r_ai; /* Active increase rate */ - u16 rl_r_hai; /* Hyper active increase rate */ - u16 dcqcn_g; /* DCQCN Alpha update gain in 1/64K resolution */ + u32 rl_max_rate; /* Maximum rate in Mbps resolution */ + u32 rl_r_ai; /* Active increase rate */ + u32 rl_r_hai; /* Hyper active increase rate */ + u32 dcqcn_gd; /* DCQCN Alpha update gain */ u32 dcqcn_k_us; /* DCQCN Alpha update interval */ u32 dcqcn_timeuot_us; u32 qcn_timeuot_us;