[dpdk-dev,v2,1/8] net/i40e: add API to convert VF MAC to VSI index

Message ID 1506342429-199695-2-git-send-email-david.hunt@intel.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Hunt, David Sept. 25, 2017, 12:27 p.m. UTC
  From: "Sexton, Rory" <rory.sexton@intel.com>

Need a way to convert a vf id to a pf id on the host so as to query the pf
for relevant statistics which are used for the frequency changes in the
vm_power_manager app. Used when profiles are passed down from the guest
to the host, allowing the host to map the vfs to pfs.

Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
Signed-off-by: Rory Sexton <rory.sexton@intel.com>
Signed-off-by: David Hunt <david.hunt@intel.com>
---
 drivers/net/i40e/rte_pmd_i40e.c | 35 +++++++++++++++++++++++++++++++++++
 drivers/net/i40e/rte_pmd_i40e.h | 13 +++++++++++++
 2 files changed, 48 insertions(+)
  

Comments

Jingjing Wu Sept. 26, 2017, 2:04 p.m. UTC | #1
> -----Original Message-----
> From: Hunt, David
> Sent: Monday, September 25, 2017 8:27 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Sexton, Rory <rory.sexton@intel.com>; Marjanovic, Nemanja
> <nemanja.marjanovic@intel.com>; Hunt, David <david.hunt@intel.com>
> Subject: [PATCH v2 1/8] net/i40e: add API to convert VF MAC to VSI index
> 
VSI index -> VF id.

> From: "Sexton, Rory" <rory.sexton@intel.com>
> 
> Need a way to convert a vf id to a pf id on the host so as to query the pf
> for relevant statistics which are used for the frequency changes in the
> vm_power_manager app. Used when profiles are passed down from the guest
> to the host, allowing the host to map the vfs to pfs.
> 
> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  drivers/net/i40e/rte_pmd_i40e.c | 35 +++++++++++++++++++++++++++++++++++
>  drivers/net/i40e/rte_pmd_i40e.h | 13 +++++++++++++
>  2 files changed, 48 insertions(+)
> 
> diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
> index f12b7f4..85b540f 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.c
> +++ b/drivers/net/i40e/rte_pmd_i40e.c
> @@ -2115,3 +2115,38 @@ int rte_pmd_i40e_ptype_mapping_replace(uint8_t port,
> 
>  	return 0;
>  }
> +
> +uint64_t
> +rte_pmd_i40e_query_vfid_by_mac(uint8_t port, uint64_t vf_mac) {
> +	struct rte_eth_dev *dev;
> +	struct ether_addr *vf_mac_addr = (struct ether_addr *)&vf_mac;
> +	struct ether_addr *mac;
> +	struct i40e_pf *pf;
> +	int i, x;
> +	struct i40e_pf_vf *vf;
> +	uint16_t vf_num;
> +
> +	RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
> +	dev = &rte_eth_devices[port];
> +
> +	if (!is_i40e_supported(dev))
> +		return -ENOTSUP;
> +
> +	pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> +	vf_num = pf->vf_num;
> +
> +	for (x = 0; x < vf_num; x++) {
> +		int mac_addr_matches = 1;
> +		vf = &pf->vfs[x];
> +		mac = &vf->mac_addr;
> +
> +		for (i = 0; i < ETHER_ADDR_LEN; i++) {
> +			if (mac->addr_bytes[i] != vf_mac_addr->addr_bytes[i])
> +				mac_addr_matches = 0;
> +		}
You can use is_same_ether_addr instead.

> +		if (mac_addr_matches)
> +			return x;
> +	}
> +
> +	return -EINVAL;
> +}
> diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h
> index 356fa89..6984105 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.h
> +++ b/drivers/net/i40e/rte_pmd_i40e.h
> @@ -637,4 +637,17 @@ int rte_pmd_i40e_ptype_mapping_replace(uint8_t port,
>  				       uint8_t mask,
>  				       uint32_t pkt_type);
> 
> +/**
> + * Translate a VF mac address into VF index in array of pf->vfs
VF id is a command concept, no need to say it is the index in pf->vfs

> + *
> + * @param port
> + *    pointer to port identifier of the device
> + * @param vf_mac
> + *    the mac address of the vf to determine index of
> + * @return
> + *    -(-22 EINVAL) the vf mac does not exist on this port
> + *    -(!-22) the index of vfid in pf->vfs


Thanks
Jingjing
  

Patch

diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index f12b7f4..85b540f 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -2115,3 +2115,38 @@  int rte_pmd_i40e_ptype_mapping_replace(uint8_t port,
 
 	return 0;
 }
+
+uint64_t
+rte_pmd_i40e_query_vfid_by_mac(uint8_t port, uint64_t vf_mac) {
+	struct rte_eth_dev *dev;
+	struct ether_addr *vf_mac_addr = (struct ether_addr *)&vf_mac;
+	struct ether_addr *mac;
+	struct i40e_pf *pf;
+	int i, x;
+	struct i40e_pf_vf *vf;
+	uint16_t vf_num;
+
+	RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+	dev = &rte_eth_devices[port];
+
+	if (!is_i40e_supported(dev))
+		return -ENOTSUP;
+
+	pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+	vf_num = pf->vf_num;
+
+	for (x = 0; x < vf_num; x++) {
+		int mac_addr_matches = 1;
+		vf = &pf->vfs[x];
+		mac = &vf->mac_addr;
+
+		for (i = 0; i < ETHER_ADDR_LEN; i++) {
+			if (mac->addr_bytes[i] != vf_mac_addr->addr_bytes[i])
+				mac_addr_matches = 0;
+		}
+		if (mac_addr_matches)
+			return x;
+	}
+
+	return -EINVAL;
+}
diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h
index 356fa89..6984105 100644
--- a/drivers/net/i40e/rte_pmd_i40e.h
+++ b/drivers/net/i40e/rte_pmd_i40e.h
@@ -637,4 +637,17 @@  int rte_pmd_i40e_ptype_mapping_replace(uint8_t port,
 				       uint8_t mask,
 				       uint32_t pkt_type);
 
+/**
+ * Translate a VF mac address into VF index in array of pf->vfs
+ *
+ * @param port
+ *    pointer to port identifier of the device
+ * @param vf_mac
+ *    the mac address of the vf to determine index of
+ * @return
+ *    -(-22 EINVAL) the vf mac does not exist on this port
+ *    -(!-22) the index of vfid in pf->vfs
+ */
+uint64_t rte_pmd_i40e_query_vfid_by_mac(uint8_t port, uint64_t vf_mac);
+
 #endif /* _PMD_I40E_H_ */