From patchwork Sat Oct 7 06:31:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 29859 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13EBB1B1EF; Sat, 7 Oct 2017 08:31:56 +0200 (CEST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0089.outbound.protection.outlook.com [104.47.41.89]) by dpdk.org (Postfix) with ESMTP id 2B7F71B198 for ; Sat, 7 Oct 2017 08:31:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Se4HdYMiDq3fEHf0GvQ/GqPHe0LqiTyp/NiL+cc838g=; b=ASXGbeY1emyVGobFbA7jwdow+shceDSzsagau048SmBy7K3STERoC8aaiwq1Fmq67EpT9uMU45eblHq+jT1WX2g0MDxUpq2+rmyPit5/XTV5udI0YEipC4asRIsg4ikY+IReDEn88uqO76Oal/X8rQXH33VEK74sdy57tPiVX8Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 7 Oct 2017 06:31:45 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Fri, 6 Oct 2017 23:31:05 -0700 Message-Id: <1507357872-26475-11-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1507357872-26475-1-git-send-email-rasesh.mody@cavium.com> References: <1507357872-26475-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: SN4PR0501CA0012.namprd05.prod.outlook.com (2603:10b6:803:40::25) To MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9b5033d6-b693-40d5-7346-08d50d4d150d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:MWHPR0701MB3833; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 3:lDeKz5uZlHDAVfxsNVc8SQSEsjSL44nipgCM/qLFzULlAGm199Rz/QyA2D9MnqRCg0IPgScq9fV+ri0fvClokSsTVhFAI1dV7WBxGkElHwAV5Nl276gFdlxrQagcbgkoEZJIswef1Bww9teWVLzZx3Gy7Hg2tkrM1q7+rISuy2K2h4bKFMNT1EKe6YcWfqsx3OTAqSNeGbzLtVEQAf+LeKo2OtO8BEFAE9Jc18Coi8gkL0QA+c65zYEe1ugx1Kdv; 25:Zv0+cCJX49j6NFojiBuVZ8nhXdSLx74hZPloPHKX8GDFVtuHkp3FQ/jaDbEMT+IJ9aweWcUhGDGc/P5A+DxoqNuc1DWOKjI30and9LWeVsCoRBKMp90hGs4sTmhlfqhKpyxwYcKE+8wpU5CzlAa+ezEsRfPySmviePu6sygtYD9COHSP3z1ALIn6GrD/Px9a4Eog1Tp1l5LzE07c7gE1i0yThoeGzmHStf6HqkgFwugGQvMaR5u7XSJWnI/4rbJ8IM5c5HIkxqIstTipBKOLonziJLws3DxUx/RL+XZr8iRy3b8fJBdsTnElpvcg+XUbafDFDphGAfmR3VD6/pq1Kg==; 31:6pj2Uwa/vWlNZuGFhH5vCPqH9BOKNawHkaUo8aM3nuAEuiV2NWSeWP2YabV5ju9BgfbSD8Vg6Jk3WSDgIImJoixnLGXD/DLbl1TGAgghQAsfhyyzb9W94EMz2feyiR6ljIbFr+XqcRN6aBE/e/6zg/BONM6IbD+6qNqTG3RWo/1i6WQdyoC+sDvwPY56DquhdAHqTVjJxbw7z+A6G4Zuuz09PKMynpktjW+oH1CDNUc= X-MS-TrafficTypeDiagnostic: MWHPR0701MB3833: X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 20:29T+3FpKGzOw2ZBRvcsWiF453tqbuAawwQdWFj6Sevp7sWS7nFFQWfNKrJIS6HS2FWzBZNQJN+p9gL6qUo23lSVOWvpxGV/XA+bCyIxWPu1BkxdQbupD+U5YaKgISnzI0zZTeBhzC4h7P1heRYyJzfwH/wGbkQRMRSygSxRFiMqQZAZkiVU2zlBVl0zjhxZeB29x5A+mbI5NDfUimI4xOu1B+vIQGHKwu0/IASdQd8TLF7FkZJQIX0ms1z5MlowVROdlAPV/dTLEhBoHKYms+SPFEHDAtSOcZ9G1c0XBu2rHl8TuNwsPt8C64yhld+OSkVvqHgYU0fSDfhDR62U39zt/q8A5ras+PdCar46rbwOVMoK5mh2yKa/e1mtf+wztnyxvVJ7liTpwJYYpOsNJjqdRGF8l1/y19E/sCYncOMe0vXIrUXEb9+Jn2TmoQGtomXk2f7rgCXebDF9bm3c9kWeVChPfrokyItZ0m+6FBU0fKzYSGOmRLkdKhwt0pJkh; 4:+B3hvxr5m0oLOyQHTXxKsibSp4Kzy5AhEeiybcNpleyFQjBBFg9mK7XfEIPN+WX8jIWqCcnZD8JbH1diZdNfSiegY7WLSwulfBoT3xB+vyU5O2drrpWyvU5GEQPl9IYpaYzxe+QFMHKQbuheBa2/N+yjlQ9/tSdGeNwhSgGiUxI+LhTgd73vNt/N3iIY0SgB93qCwfPG5yrm3i1AxIwDEzT9+xQ3GX1W5iuJaT8K6EHp1c1G3Uh1ujpu+HS49hES X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR0701MB3833; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR0701MB3833; X-Forefront-PRVS: 045315E1EE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(199003)(189002)(2906002)(6116002)(8936002)(3846002)(48376002)(68736007)(478600001)(101416001)(105586002)(50226002)(106356001)(72206003)(5660300001)(50466002)(33646002)(25786009)(4720700003)(21086003)(2950100002)(6666003)(69596002)(36756003)(76176999)(50986999)(81156014)(53936002)(107886003)(4326008)(55016002)(47776003)(66066001)(5003940100001)(81166006)(189998001)(8676002)(305945005)(97736004)(16586007)(316002)(7736002)(16526018)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3833; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3833; 23:jzTce7InpkHj5FcPu9L5Qfd2hVIpF5xG/g1Ills?= JaBl5Km8S6UiW1L9kdWDP5u9pBKC6N2aiEWYkwcux3olh8vu7b6Cz48LrHgCe4O6a9rja63xL4J78wnfyj6ERX8ruW9JuWeOll6nm8aW2DjeH/N4p0YekZF3PaT1cJmmilP5DKtrCkXBFbkfI+lvceHkOaZgBw6MLm9IsOu+85aRuDjLf2KkJaDKuU1WVCdKT2cSwbvtpvwZjt1j+nkW+Brugdxp4nSViM/Ki8CsFxU1kC+EUHPJcao9bG4j6/FbBGe7r+Lte/DCBYqxaCrqBJ3F/Hgk64kdi/rE3u7nyTNeBLGk6Jz2cnTD49E5yKxH9ajHdOofphXnGcZlyUZxvxZPcpo0jMkXerU7c6wR5EyKykdPnd3wMz/pmZDSx2vWljhx8XhFighuHVDPjAe621PQgcz8fp0hBmnYWk9sXM2/cwlP61wvFYaUeHbcn7uU9142/N7xhcZKxhkFyG1D6W1BQrUjmxwyzbRv/TLEBqZjdv8s0aE714eaSIhGutSMjN98Ie3W9SsxjLxoC8yH+0qb9qcJkFNq3+ZLnEotyzKmtJhcVnC4XsBg67HT8ovRPhGGpi+Ff+C+TvhquNzd4wz05Da9Xndx9/sIeDKJLo2QMBkSS0ZcYu83+B6O4jn4iauDPi+rDLG0EdK5gLwsmyI+JBI4m7rR+4ioPQn5cRl0Yy4kh4IJkUodf+m2WlEPrlZeigenf4ULC6kq+ZYX/XU5TwG0T2Apt/Mn566gVj5Qp32xgV66l4cryOlRAsZyx7zqQGmbwOoHS07C4gK+EkarMaM6xDO6+q9k3cRUEFVLBt8ywIx8/MX87dTllT6y7pH1tpHBXlJVXevuHWHoGHBhQO5QL+WE7eI0f24I7WFA5qRkU+PCDo4ecIreH72nQEPX/AyCjhhX1q46hokJ3jURD/bKQeAA/3tfVkBvo2ztsSyvrFRywwL50bLH2Wp4uTq/HEMZbwPxz88NcXaFRZMi8bhlxEf24ITqCR2t2qd8nODL/onDv00ED9CEfk1tsJnj9swf21DADWUF/hN9SkAh6OIbosZD27+nNPqsP8tHpNbUKJkI+1xV+STGp/F83nqo= X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 6:XoiUsxo/yczPsfl8qNlCbhDT1bCJ7vs1hQMNuK1xCV24ruNgzttNi4ahSsPHofrLsz9bklj/bEj4dxL7Ub4yC9mkREV0EjLz8dEBr40PTjHLc2uYWu0PtqndBdL6+yaCgjeFQfOHgZq0GQsDTw1p+nyru37HAvwduIjTlmCgGHa0+5RSpJutQLxjlrJ04hUJfo7KIJ0coI9tLe15cBpwiDlOf4XhldYntFS2/2Ibz00S0muU8clPGU/rL/FF3Aqq5oTE7cy4uKQOu6EjoVsJsNdenWqhoSraOzW1WfkcwwQlW7ECSlXUasYD814VojUSMtpgYNM0XqQTYwWe3MrAJQ==; 5:plKhCQa1YbcjhSXyGHYmkfeezIsVKNI60aypMUiXknWoViZclWLmnMbX7CaGXsea5kEz2QLGWswRiRuczV8IBbjxW45JrbAgsftbYG05ATTyPCnXxCBjqe0Yu0c4Kv35mWG31hJsmJckoNpZiKmpnA==; 24:tJn/UzZbGh3qKOB9PASv0oZumgiv+VPJtKKIUxtRL5ZyyA1dLnmKvYNq9hAdkXTPLSJAdKUDDTDB/Z1EUcytt/hRPNIl9jQqhK2W2Hqoc54=; 7:y9b6/hM3EUuOw7JZCGNvjFADXs5U5AZijlF4C/tfYr5ZxI9qSLseKoTqoBFs3p27G6lBVfWDEHEimsobcW4l/OVhkoyxV/ca8EnNs7hm6d1EREjhQl6p7AKtOvjpPIBTrPoPjrwZpqUiyIS1mIUi3Tibfkea0vCyHfe9Bw6g1+5UJVxobHqqWlbMVdB4kNAivkYU/FBopV8FaaD9xqx4GL6HSqOspmue92ov8oADKc8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2017 06:31:45.4326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3833 Subject: [dpdk-dev] [PATCH 10/17] net/qede/base: semantic changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" - Move define CRC8_TABLE_SIZE to header file - Move/relocate ecore_vf_start() - Other semantic changes Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 2 ++ drivers/net/qede/base/ecore_dcbx.c | 8 +++---- drivers/net/qede/base/ecore_dev.c | 34 +++++++++++++-------------- drivers/net/qede/base/ecore_init_fw_funcs.c | 1 - drivers/net/qede/base/ecore_mcp.c | 4 ++-- drivers/net/qede/base/ecore_spq.c | 4 ++-- 6 files changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore.h index dc09847..5eff6aa 100644 --- a/drivers/net/qede/base/ecore.h +++ b/drivers/net/qede/base/ecore.h @@ -871,6 +871,8 @@ struct ecore_dev { #define NUM_OF_ENG_PFS(dev) (ECORE_IS_BB(dev) ? MAX_NUM_PFS_BB \ : MAX_NUM_PFS_K2) +#define CRC8_TABLE_SIZE 256 + /** * @brief ecore_concrete_to_sw_fid - get the sw function id from * the concrete value. diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index af8a239..edb711e 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -318,14 +318,14 @@ u8 ecore_dcbx_get_dscp_value(struct ecore_hwfn *p_hwfn, u8 pri) ecore_dcbx_process_mib_info(struct ecore_hwfn *p_hwfn) { struct dcbx_app_priority_feature *p_app; - enum _ecore_status_t rc = ECORE_SUCCESS; - struct ecore_dcbx_results data = { 0 }; struct dcbx_app_priority_entry *p_tbl; + struct ecore_dcbx_results data = { 0 }; struct dcbx_ets_feature *p_ets; struct ecore_hw_info *p_info; u32 pri_tc_tbl, flags; u8 dcbx_version; int num_entries; + enum _ecore_status_t rc = ECORE_SUCCESS; flags = p_hwfn->p_dcbx_info->operational.flags; dcbx_version = GET_MFW_FIELD(flags, DCBX_CONFIG_VERSION); @@ -363,9 +363,9 @@ u8 ecore_dcbx_get_dscp_value(struct ecore_hwfn *p_hwfn, u8 pri) struct ecore_dcbx_mib_meta_data *p_data, enum ecore_mib_read_type type) { - enum _ecore_status_t rc = ECORE_SUCCESS; u32 prefix_seq_num, suffix_seq_num; int read_count = 0; + enum _ecore_status_t rc = ECORE_SUCCESS; /* The data is considered to be valid only if both sequence numbers are * the same. @@ -859,7 +859,7 @@ static enum _ecore_status_t ecore_dcbx_read_mib(struct ecore_hwfn *p_hwfn, DP_ERR(p_hwfn, "MIB read err, unknown mib type %d\n", type); } - return rc; + return ECORE_SUCCESS; } /* diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index c81048a..412af07 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -2283,19 +2283,6 @@ static void ecore_reset_mb_shadow(struct ecore_hwfn *p_hwfn, p_hwfn->mcp_info->mfw_mb_length); } -enum _ecore_status_t ecore_vf_start(struct ecore_hwfn *p_hwfn, - struct ecore_hw_init_params *p_params) -{ - if (p_params->p_tunn) { - ecore_vf_set_vf_start_tunn_update_param(p_params->p_tunn); - ecore_vf_pf_tunnel_param_update(p_hwfn, p_params->p_tunn); - } - - p_hwfn->b_int_enabled = 1; - - return ECORE_SUCCESS; -} - static void ecore_pglueb_clear_err(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) { @@ -2327,6 +2314,19 @@ static void ecore_pglueb_clear_err(struct ecore_hwfn *p_hwfn, } } +enum _ecore_status_t ecore_vf_start(struct ecore_hwfn *p_hwfn, + struct ecore_hw_init_params *p_params) +{ + if (p_params->p_tunn) { + ecore_vf_set_vf_start_tunn_update_param(p_params->p_tunn); + ecore_vf_pf_tunnel_param_update(p_hwfn, p_params->p_tunn); + } + + p_hwfn->b_int_enabled = 1; + + return ECORE_SUCCESS; +} + enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev, struct ecore_hw_init_params *p_params) { @@ -4414,11 +4414,11 @@ void ecore_chain_free(struct ecore_dev *p_dev, struct ecore_chain *p_chain) struct ecore_chain *p_chain, struct ecore_chain_ext_pbl *ext_pbl) { - void *p_virt = OSAL_NULL; - u8 *p_pbl_virt = OSAL_NULL; - void **pp_virt_addr_tbl = OSAL_NULL; - dma_addr_t p_phys = 0, p_pbl_phys = 0; u32 page_cnt = p_chain->page_cnt, size, i; + dma_addr_t p_phys = 0, p_pbl_phys = 0; + void **pp_virt_addr_tbl = OSAL_NULL; + u8 *p_pbl_virt = OSAL_NULL; + void *p_virt = OSAL_NULL; size = page_cnt * sizeof(*pp_virt_addr_tbl); pp_virt_addr_tbl = (void **)OSAL_VZALLOC(p_dev, size); diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c index a739ba8..1da80a6 100644 --- a/drivers/net/qede/base/ecore_init_fw_funcs.c +++ b/drivers/net/qede/base/ecore_init_fw_funcs.c @@ -1769,7 +1769,6 @@ u32 ecore_get_mstorm_eth_vf_prods_offset(struct ecore_hwfn *p_hwfn, #ifndef LINUX_REMOVE #define CRC8_INIT_VALUE 0xFF -#define CRC8_TABLE_SIZE 256 #endif static u8 cdu_crc8_table[CRC8_TABLE_SIZE]; diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c index 3caf08b..028fbb3 100644 --- a/drivers/net/qede/base/ecore_mcp.c +++ b/drivers/net/qede/base/ecore_mcp.c @@ -2555,9 +2555,9 @@ enum _ecore_status_t struct ecore_ptt *p_ptt, enum ecore_ov_client client) { - enum _ecore_status_t rc; u32 resp = 0, param = 0; u32 drv_mb_param; + enum _ecore_status_t rc; switch (client) { case ECORE_OV_CLIENT_DRV: @@ -2587,9 +2587,9 @@ enum _ecore_status_t struct ecore_ptt *p_ptt, enum ecore_ov_driver_state drv_state) { - enum _ecore_status_t rc; u32 resp = 0, param = 0; u32 drv_mb_param; + enum _ecore_status_t rc; switch (drv_state) { case ECORE_OV_DRIVER_STATE_NOT_LOADED: diff --git a/drivers/net/qede/base/ecore_spq.c b/drivers/net/qede/base/ecore_spq.c index 75adcda..70ffa8c 100644 --- a/drivers/net/qede/base/ecore_spq.c +++ b/drivers/net/qede/base/ecore_spq.c @@ -178,10 +178,10 @@ static enum _ecore_status_t ecore_spq_block(struct ecore_hwfn *p_hwfn, static void ecore_spq_hw_initialize(struct ecore_hwfn *p_hwfn, struct ecore_spq *p_spq) { - struct ecore_cxt_info cxt_info; struct e4_core_conn_context *p_cxt; - enum _ecore_status_t rc; + struct ecore_cxt_info cxt_info; u16 physical_q; + enum _ecore_status_t rc; cxt_info.iid = p_spq->cid;