From patchwork Sat Oct 7 06:31:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 29854 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 330AD1B19B; Sat, 7 Oct 2017 08:31:47 +0200 (CEST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0089.outbound.protection.outlook.com [104.47.41.89]) by dpdk.org (Postfix) with ESMTP id 141D6532E for ; Sat, 7 Oct 2017 08:31:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HNT6rqEspj12eSiloseGK+rYuqFBWaSS8vM+bMtZiXU=; b=Pi4ddo7+E0U1yvB7xyukB5AQEir4NxYRU00Pua95o3sFQ/qwPoq6d9boVGMJUubVmZ0Pmezc0C0vz4hlvsfdVMQQiOmSKZDPiGYx28VsbQ6OJUCceDDF9IC5bl3RmAArDtge8nvV0mWwPvEPnsNscPu3OuHTr4LCDc28HUmxImg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 7 Oct 2017 06:31:40 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Fri, 6 Oct 2017 23:31:00 -0700 Message-Id: <1507357872-26475-6-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1507357872-26475-1-git-send-email-rasesh.mody@cavium.com> References: <1507357872-26475-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: SN4PR0501CA0012.namprd05.prod.outlook.com (2603:10b6:803:40::25) To MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc9dc97c-920e-4008-30c6-08d50d4d1223 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:MWHPR0701MB3833; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 3:XrlFAbXWe1D0ddgL/WkJtmDb1d82av+9eDQ4euxnbJTokSFYo1D64lUrBQIJHJxRl0G6ySPTsB9j+CotuC3OstEh6v5NjgSgGB7Po/cIPzsSTBDYEg8Di2p88IZM52V0IKVzY2gIV69IZ5Ci7zVVkr87D1slY79Aeo5WyOV/CZCB1MaTNw6cuFbhnSS2Yzsw9z26od+vqCf0cqZKhUWdcYJjZpU8uq/9hETy+u5UDHrtmypUDqFFR6xqpqLKp560; 25:Sty4rJjCmoNn1go+0C8wSEwyBHRCKss9VF3kyqWTU+gmIRR+0pEGRDFv1h47hYf98gujtRrLbifunkRgdsGi0rXjdYysswyw56mD4cLWhN+iclySC1G/a442leUCr/0rWUcdL4u+Q7lDZYROxLpsGxKK75a043akaqIrCEZZlqfNqsvzJBFtbkI3NlkVGrlQJpUqQwJEwO3jzgoS8CJDa1wYZxTyYJi+G18r0ogFonUtwOixFV8ZWpkKVmgnkDtDEdFFUEQWdZ6SThhAfhb3c6hpdLGxoYp42HuQ+6KN2qdBP0UpHHhz2fG7+mRn51joZQisiCX/xSgADBRhYG4k7w==; 31:gIcoULv2q8padeuDZ0TMJTe5qAQcyUQ5EAIjiJqBCFQvqRWLev07nvq2dJW7Pk3Lu1i9X+EKsZD5uJij41bi6w6V/+UnDeVO3wXnU1JF7qx2eSN3iMjOvPzg0ZbGr4YxrTi6kGQJrI8rneJft/1gZLelVG2j45riMIwEWYtDs+tBwdl/tLeiX87aSjQd8jrbmOMjSg5ySfWHvYMaYmllVGTJ58Joz84FsuvFp+UdF+E= X-MS-TrafficTypeDiagnostic: MWHPR0701MB3833: X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 20:mlqqMIY7RNCGym4F9k1hclAN/hzd7MsHO/dIVcUn0Svt+WH64XFKJbP9AmirAQtm4EGWgDZr3SiKW2voF7tEBbSc1rporkh3On51CRr6kuP6NNXlC2/Tpdsyj/eRGKkkhGzpmpF3QVu6LLfoTv1k9iz5BGbMFZkM8YNuPeekeiawO6xsZnnTscudq/vwxqAHrfB78qDP7BIuHtSdb1SmVruUgxEImQALglptxP46QilsFMohihBL7b1HZqh09JUWleqPHbNuf9I39ZXqtOfzbxtVt1jogFSgacUXUBKYtM2S84hCo8aFI6QJUFnryuwZtO/UNsTaPKWo+5Nc5eIm1c9RSlKQbAIyXz/UKKblvkgkHLzb4o5RqdujVHzkgd5xRZtdwp1aDfH8rxOY6tajB4vEkf+/2dxmZ8Q01P1qUo/3nMsYLH/bxt9q0OneMVWRC2qp2AT1riwCCn4mkvMNGIed5DjStzwHufdaDpWiHsJ/2mg7RP0Mx9nRQh6TOCR9; 4:4RMjbhhi1PXjiCp+n3Do9LxVgIg55rbcDcrYjtiD8+r7OdbKLMeH+SXNiFaxwv61VjB+Dj+eCBhRfc52CrnOam/FQfOmrP2X1mVcNAP6dEkYIlgIiy4MAEqRsoysggWI6XyVzdhAfouajCPRGjOC/hC7vZstnnSERDV29qyoTRet0BRD+N9Uvthnpa0aiwyeYBoQNx7eaarJO5oH2g1bqV8q9dnpaNgfqJ3Cmj+mCshyKMPFrMn7wxKBTuUN3CEy X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR0701MB3833; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR0701MB3833; X-Forefront-PRVS: 045315E1EE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(199003)(189002)(2906002)(6116002)(8936002)(3846002)(48376002)(68736007)(478600001)(101416001)(105586002)(50226002)(106356001)(72206003)(5660300001)(50466002)(33646002)(25786009)(4720700003)(21086003)(2950100002)(6666003)(69596002)(36756003)(76176999)(50986999)(81156014)(53936002)(107886003)(4326008)(55016002)(47776003)(66066001)(5003940100001)(81166006)(189998001)(8676002)(305945005)(97736004)(16586007)(316002)(7736002)(16526018)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3833; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3833; 23:1V0qAf91W11mG80RorOIKQIIUBTNXz3sI+btLzN?= T8hNNxx9XDaO9QGU9ZT/t6exkfUFhkYtYgVQVYyPxySgKiHgo3h+uTy4Ml4iffFRpRY+E0Gh3YToi8hhKk0DZfI2ZUwlZIy/rdM1SsBF0qc0KfolExl7/jYt3URXGkgtzwRhqx6qJB/ftxCBrop9ybLlYRjWOA0balvLUvNdXTr/Dz94JMGzIPQ+FqioKql7QlOYsZb8ZSSHikz36Rbohs5qLlwg5MkZYMC7pWUwuR6wA40NhdHJQQ/ZMxvQWVvv15eWdbbJuZgF0nlg47RKH1ab4p5sykH0zxCllbO2YRBDe/66kF2GswU4krn2hRU/lHcsxSgVTdh1l7ciwzGn9mf7IzT1/azbNslRwBSRUU6GVmuCP0iphUUk+BRbf93o6tQ0Vls30rcpudXTDWMWAaVVmdUUaNihAyQ2+vJQcKhH2ftImWBbIkn8Xi03D6wSgYDbxFcbHCL9PD+uiDfyEbwVRh/9OKunt2Td8EF8AGNhaoYnAL5aFSLS2ipt7XI6rzitp1fOFklAHdC+6YrNkuXY3QoG6GfPHy8duRjMd2wxjo5s8zlgYP8Iq9grfIuDM+dvk4Lp1kENkVoYI9hzMGwhxsNiE80ohAPOTXlSqKYp63GZQFRC/LHcIniWpUtSOlgUg//3KHyYC2DvmXEsuZ8+fPeH2GF/I1Oueoz2C1VbCbpuLUNezfNrsOnv/UFVBXLaklVH4pWw5QwUZuI+qNvqopOQK5uVJxwNMslMP5JrR+qU61ElW0cdpvqfiW9eafB4uacavMbDlyQ7yeyneJM9kLtic/xu1cwvTT9mtc5soBG2g3vGCDN7nVGbJO7LJuTZsKSnW+uYxx/I7YST6y++cZUGyQMD8hFfvazUgvdatbgrtNtYiAMnTsMzn+LzQzDkM+jqhX0Y957O+cbO2lLG4R+GiDCkIxBaZeo2TPihudZMsxbmcwzszBYqrvUJuUyP9HQ28b3Vaj6fXfOBbsv78K9kdWaVs7m8HUtWQtzPqpaMJKC/3JMfHnUJhs9b6yWxb2B1NmZD4UiQZUuudti3cHSdKtfm1u+/iE6y4jYOX8pPiD1ROe/WYRMhs9+3gNoI= X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 6:s94+GGuTgBlsXM1rLcsrfWvmEi90qeEmwx7VyRQacc1MMm7ubyv+Ty72GxjAuGtPl3pFqTzebof2biAP56dacNqFrqZArscQCmyUJZhzaliUeHyp4Of4a558tE/FZXVPG1KrgqyXarjo8GnrIDFam53IRn8Fulw7rT1BvHwytIYuXuOvTw9BYVOBymU7QfSqdjCk7r4f+z1+sCJ3DLR275didTGcI+RjZGxDYOfslKLJX9S0wU59e5jvbZj5TTF0QJvuoZl7dE+C1ZSKOBlD5mg3Q7Jqm40der8/dRUcefkfPBUVj4C5PuXG7W4Xb+AQsvq+uru/4Z4zzje8AqYrSA==; 5:mib8xIOORI2MFdYIzmCM7WenMGCkjS055IhdsIb1hCMOKCCXBY++lrBXlDVhb3m8XYSptivvMq1etpRd6D2PD7kfDjjTsmU9HhjdyYwPCvfeiEwpu3x2RyhkgoBILTdBxPabYopQNyw82KGIF4RoXg==; 24:2ER7c66YIKsQIJ70VjzdQLM4KlAsnw3B9PsTG19wVT8T3H96ZuNkREf1bJ0F9P2wHjQT6O40ZR+s+ZJgMtSaqiqo9bniCkgpfLnVbRfTLLg=; 7:jVNCGxRiRcO5ECcGwPx/ZumSuTHJao8jdhPkRj1a3XEvr4AlI2B52lxsprPrP8t5p5goLjYAaBQ2F7d50+PfsywRxqn2UYnSTyJRnylcoP618IVuwz8AM9a+Ityc4XUBEIqfBzHFTQLwh0MW8Myjuk+xOURgwEurVaZZZXWvl+CJ+F8vqTJZUer+SLestyrg5kgheLnxGDBv4zvS8fvRq9nS4+dXjF1iaZ2FAIyeqcI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2017 06:31:40.5263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3833 Subject: [dpdk-dev] [PATCH 05/17] net/qede/base: add check for DMA engine state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Check DMA engine state to verify it is not called before it is initialized Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_hw.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/qede/base/ecore_hw.c b/drivers/net/qede/base/ecore_hw.c index d6217d8..bc0138f 100644 --- a/drivers/net/qede/base/ecore_hw.c +++ b/drivers/net/qede/base/ecore_hw.c @@ -789,6 +789,15 @@ static enum _ecore_status_t ecore_dmae_operation_wait(struct ecore_hwfn *p_hwfn) return ECORE_SUCCESS; } + if (!cmd) { + DP_NOTICE(p_hwfn, true, + "ecore_dmae_execute_sub_operation failed. Invalid state. source_addr 0x%lx, destination addr 0x%lx, size_in_dwords 0x%x\n", + (unsigned long)src_addr, + (unsigned long)dst_addr, + length_cur); + return ECORE_INVAL; + } + ecore_dmae_opcode(p_hwfn, (src_type == ECORE_DMAE_ADDRESS_GRC), (dst_type == ECORE_DMAE_ADDRESS_GRC), p_params);