From patchwork Sat Oct 7 06:31:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 29857 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA1E21B1B0; Sat, 7 Oct 2017 08:31:52 +0200 (CEST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0050.outbound.protection.outlook.com [104.47.41.50]) by dpdk.org (Postfix) with ESMTP id 8EEF37CBD for ; Sat, 7 Oct 2017 08:31:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PPq8wIrdXUXb5rjYc5M/HNWL4XOuz/+zNbW6EPYm0Gk=; b=MRiExRz16jYXILIyUK0gee/SV8URWXXQ1cREOljM6F7NfRubY0rtyYV20KRgG6cpVaO5tSZ+LLbOGMMLXt2mPhqg3dlO1WdX7BifO4ZV9gf6JubKaD0aDRGp6+FnEVAAkWb2PcjMnNGpXiOgBjwu1J8hsCHNQ8HbRC/C372PzIE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 7 Oct 2017 06:31:43 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Fri, 6 Oct 2017 23:31:03 -0700 Message-Id: <1507357872-26475-9-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1507357872-26475-1-git-send-email-rasesh.mody@cavium.com> References: <1507357872-26475-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: SN4PR0501CA0012.namprd05.prod.outlook.com (2603:10b6:803:40::25) To MWHPR0701MB3833.namprd07.prod.outlook.com (2603:10b6:301:7f::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b2592d8-89a6-40e4-e448-08d50d4d13ba X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:MWHPR0701MB3833; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 3:fuLCbLblUqt1xU8/Yy3/ZO/effr+yUnFAfYDqrdDayNW7fm5GMpLoF98CyQAgUxzjGXEIsLcGhbj1DHQrE3VhSXm/QkxOmfw0hVbQZUD38DoXuh4Q1RGcR+gBcO/xlnVGwLf/gw0r7J0OKSN+XzJEDlEFc6JGTmAhBvc3mjjosJ/O9ZSU0LrDInB1pCUqFENKAF2RKUZvRjewXhxtVN3OJEayQFua0sraZFyi/yzZlt0fr05P/G8AT6J5SJBE2do; 25:Mv4tmqQ1C6MmEMKOOXNFVx4QTePuW7LjrkqahC37fGcHy/ZnAPRZDl5mlmgQHehLB7nPfn/ONb1YDSAV06QXlsnNYrfcPlnbpilUWbGlhsz6xb0Y5975X4JqbvzatNHxfgFxnrJHAAgtsQqXbDSxu/LlDj71rwXfNogJuM+tEV9Bd1wS74TYLljpsyptT/aKWUKVm/Zvk9VL5hA6BxNWxtwPq/TBEQlVykgFPlrZwbzmQLSS5fU1w4QqNBaYyI9av8rSkrre8Ifywi1NXg82XIzqpqzHj9u/+cZH+eX4+Kg9XvRaak1CsFjzDPAyGVUO0UbCc5345knJ/ETqFQTjuQ==; 31:EDKTSDAHQ91hICqWlCfNXUXmlVlQDK6+f0wmEihCREGMgEfDu5rTFcAOUvtln3u7oCaqH9BwKdBdPJ2+fyeVoyS9VgpJFExDe2ESDSPmZMudSR3JyClh01jJy9ll8Ypmrjb0kaK8umn2JOtXH3hFqq5dm/Am+Wlet8HqrJf/y3RVugTxw4lKk+5PH1+8g9GKlHYD7VV5oprcgCWXtYkyAe8r00zqPziDAB7qAxvCOa0= X-MS-TrafficTypeDiagnostic: MWHPR0701MB3833: X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 20:PtrD2iL5MT9htjUPy8Pt2bj+MOwBJIgtO5h8nde9vDU8nti8+sA+uurxv6YAfi4FtLgJhpYyx5vLXqTKUL7+6Jn+qMz3ZELuXT+bIjguAl3+u+W/KVnzmWP5rX2Vw2DkEwRH409om7wwJPv2o0MRVNZXKr685xoZSTYfEPBD3CAhqdYLkh2GuU6GV28Fbgn0/vhRxEspfLBF2K1CxBGw6SqwdQmQ3e7gGBBmy3DeeRMrkLYexiW1+Ch4LqVqd9wcs1wDndqM4RQez/a5WM2XQx9XgsjPLiywKzzrlqT+13IYdtrs/lzI7FME4A0CK/IF+ekbSC4ZAewljh+KngBwQr6YMa9mwwVqOgR60vGzZJyU1Ra3ehB4x1VDF+V2uTlcAs2sUYlTa8xOejDqz/+LY9hBrCpMM3NCLdy+qWAX7Qvw7kL/cBjYskMwC6YgbTzojFjn5vf4WbUDalto6qR7QsP4hwH+8C0ftu3UIWPywXXhTDezl3EvOgDqF7rXjs7S; 4:TmWH9IELpLP1VEttULvmF3/DBDbNTKhdLMy8MFH0uhx/0Wra8P0NOBeVw02/Sd2qt2llhiIeivZTSUDDxoZ8GOYXSEPFknVuhkKakFwcSKM73mPkqdIBhZlNHDfkOXgjWouVk6z/zl+FcWH6CZuRdRQekSADazizt3pN05o9hJGliGynmFsqNXaYiAVycgRx7q9RWQm6QYuWTwuXbd2QjSNUOU/QnDoBXiKMyJ9lORcQwSnmbQxKEO0DIh7mYYRv X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR0701MB3833; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR0701MB3833; X-Forefront-PRVS: 045315E1EE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(199003)(189002)(2906002)(6116002)(8936002)(3846002)(48376002)(68736007)(478600001)(101416001)(105586002)(50226002)(106356001)(72206003)(5660300001)(50466002)(33646002)(25786009)(4720700003)(21086003)(2950100002)(6666003)(69596002)(36756003)(76176999)(50986999)(81156014)(53936002)(107886003)(4326008)(55016002)(47776003)(66066001)(5003940100001)(81166006)(189998001)(8676002)(305945005)(97736004)(16586007)(316002)(7736002)(16526018)(86362001)(575784001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3833; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3833; 23:m+TTKWz1nDAJzMmO75fOzu1+bxcz3VHJLGsouP+?= Y4Fm4SALSp6RqqDscs869KoG6C1S/v8voTWJdmhz0QNXqPixROJCdWmQt1EDTDGRYCTm6qs4S4zaxSBBBKUSXi1p27CNGQR8bjCS8Nrw59UtNIDUpEvliEPFSpwznR3kHp4HTSOgUSzwtfuEtT8zwmZ4mv7UVC15XgetzP+lUL1X9WM9z6Ps/ym9PSpvSiyRsAJkvHVN5hNsGnGPNEfow9UXzVIzlYN/uhI6Chyvi/C+DJxS6LIMGoUB1cYzQovI1zUKiJCb9EhwdcfPY/ZNK3XyXalzAZCdaamitsCcnD7GVGMKYjEP7dMF7/E/rqN6q6t+poaWjWoUhqzzU4IieBZsZLl/q32lw37Zr0sjTbCdUuDaigfhO30J/cLZjk4q0CO3M509F5P5h587lDGqaDJrOibUacejB0y9O1R++1jt9ggzBkRw9lUWP5iGZK7Pj04ucGAIC8AAsuSiGYN7gDrtaovn7iCf7tL3CiIREuXzLPtwyI+mAPOSp5VqgE9He4mdQVTDemZy/qS3GWvBuKrjhOM6uc09E8jlMjcSp7fycwl+RKLYZT2jpz70dEd9oWrLmieLclLDniyayYmn1LU/tdVMN27ECevXCwaMhoaVeGsqD6QLQWW/3yUBde4ey4GSOz3kQxF1XRSbzPVB6RUVZZIA95E0q0YBcQknYz4tEok/KhoIkd1AlMeyq39VHVhfqR11eLuk62RirVD+/E/ds/dWVwVnL30DnHOW/vGfbNjkAUYDFlLG+hcZpH4GyKhtVG1rU2q1hMih3rJRknkzUDslWsgDYialzpx3liJ4H3H3kwoZiiCFrzxdvUAZpEeA+Pl7a6tmXpT+//fBlh7lD20mEcI5mTnNak2vJg9koXxHNla+PeChxmPdF5sWt/waaCzw7isjw9vTqhGXEdiqPNXz1vsMXjYaumdmw/oGmiK7FiGUnqZynt8KG+kNsuPuWaoYlGWrRteRdbGuhQJ/hWmJUKBBflXqDxJw6lM3AjhUsUDGazzgdnAm4u1RuZdL0DptSuCiCyBhMCatal7+43d61w7e7MmwjJem+2QHSXHQcIy3W0XojDgIXX0hSguoLcTM2L8HQqdUc/roj+Hvt X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3833; 6:abjhhgIeLCrixOH1Nyj4SmC/Z+4EKzRIWvz73E2JhdfctdpkoCNAIQI4IYhfWYkjfqHgzrW5+W8qPloQeGJJpf3eg1CQTpU7y0TJ5Vn73a84s1trOXQmKLRbP/HiDUpSszGhz6yyyDttLVpzhyR2lDLhVoYtqcLIOronZx4WVVq9swfEgpRHPD8totZ84GApjh1zzc4RZmuIC174NeykRuoXXIi8k/j5Rjq9Xr9BhT6B2zG5oxi5CFgCBgk1SqXwArPTAqdFr1BogQ2yOcmWLHyUsgf7rpDVVF85VHX7oROYx2raGtMn7mBEYs+nmuKB3kyzT0PzfkJXLciIG5dyPw==; 5:VDk1D9pg0Qgr87+qnYBhIMKUVkH0TmkspFH3sBLuz6zhcWEQbVH+sUgoKgCIfFyQEs13mVzsJe7KuoX4L/jkz/6fAPSy9xLgVyF1lD0rrLrIAtdDFskk0GrnGDSgkc2d6fYyK55E1pv4Y6fVl9MRPg==; 24:87WOB04+SMejjLVlrcArwuu6GvsZZ1rS/S1TnqoFhBg1wjJU2elmHuT5I4UkLSdG2BH9pK2MrAlFB6Ow2b21Y3KHY/ApiBDUADrdEPdnwzw=; 7:KsvBldutwfJ0wdQoPjbKOABDIpT7jOK53GwobTcLMhL4s+aaYToTSPtGNQk8F/7iTnkE+SMCBhqo1LRPhi34jkN3WTAz8weJBTcYL9TKqX9WepPQ5ncLkWGZWXC6+FssPRy4hOI5n7goHKcxwncDscTaMe1Oi4ebeinqcMPC17X/z5OoSsmrTkkIibruOMD9Gm8BDWAnF30WGCBCnMXhF2ov2AjXw2IrOhO8B0K4pW0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2017 06:31:43.2138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3833 Subject: [dpdk-dev] [PATCH 08/17] net/qede/base: add/fix comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix few comments and add a new one describing SW channel implementation limitation Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c | 2 +- drivers/net/qede/base/ecore_mcp.c | 2 +- drivers/net/qede/base/ecore_sriov.h | 2 +- drivers/net/qede/base/ecore_vf.c | 8 ++++++++ 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 201b7d5..a37b7c6 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -228,7 +228,7 @@ u8 ecore_dcbx_get_dscp_value(struct ecore_hwfn *p_hwfn, u8 pri) return true; } -/* Parse app TLV's to update TC information in hw_info structure for +/* Parse app TLV's to update TC information in hw_info structure for * reconfiguring QM. Get protocol specific data for PF update ramrod command. */ static enum _ecore_status_t diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c index f09462b..50f73e5 100644 --- a/drivers/net/qede/base/ecore_mcp.c +++ b/drivers/net/qede/base/ecore_mcp.c @@ -1339,7 +1339,7 @@ static void ecore_mcp_handle_link_change(struct ecore_hwfn *p_hwfn, __ecore_configure_pf_max_bandwidth(p_hwfn, p_ptt, p_link, max_bw); - /* Mintz bandwidth configuration */ + /* Min bandwidth configuration */ __ecore_configure_pf_min_bandwidth(p_hwfn, p_ptt, p_link, min_bw); ecore_configure_vp_wfq_on_link_change(p_hwfn->p_dev, p_ptt, diff --git a/drivers/net/qede/base/ecore_sriov.h b/drivers/net/qede/base/ecore_sriov.h index 0e83f0f..850b105 100644 --- a/drivers/net/qede/base/ecore_sriov.h +++ b/drivers/net/qede/base/ecore_sriov.h @@ -264,7 +264,7 @@ void ecore_dp_tlv_list(struct ecore_hwfn *p_hwfn, * @param p_hwfn * @param disabled_vfs - bitmask of all VFs on path that were FLRed * - * @return 1 iff one of the PF's vfs got FLRed. 0 otherwise. + * @return true iff one of the PF's vfs got FLRed. false otherwise. */ bool ecore_iov_mark_vf_flr(struct ecore_hwfn *p_hwfn, u32 *disabled_vfs); diff --git a/drivers/net/qede/base/ecore_vf.c b/drivers/net/qede/base/ecore_vf.c index 9ad986c..c04fb09 100644 --- a/drivers/net/qede/base/ecore_vf.c +++ b/drivers/net/qede/base/ecore_vf.c @@ -65,6 +65,14 @@ static void ecore_vf_pf_req_end(struct ecore_hwfn *p_hwfn, OSAL_MUTEX_RELEASE(&p_hwfn->vf_iov_info->mutex); } +#ifdef CONFIG_ECORE_SW_CHANNEL +/* The SW channel implementation of Windows needs to know the 'exact' + * response size of any given message. That means that for future + * messages we'd be unable to send TLVs to PF if he'll be unable to + * answer them if the |response| != |default response|. + * We'd need to handshake in acquire capabilities for any such. + */ +#endif static enum _ecore_status_t ecore_send_msg2pf(struct ecore_hwfn *p_hwfn, u8 *done, u32 resp_size)