[dpdk-dev,1/2] net/sfc: invert positive errno used internally on return

Message ID 1507705603-7934-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Andrew Rybchenko Oct. 11, 2017, 7:06 a.m. UTC
  Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Ferruh Yigit Oct. 11, 2017, 5:53 p.m. UTC | #1
On 10/11/2017 8:06 AM, Andrew Rybchenko wrote:
> Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Series squashed into relevant commit in next-net, thanks.
  

Patch

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 5b089dc..bd09191 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -589,7 +589,8 @@  sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
 unlock:
 	rte_spinlock_unlock(&port->mac_stats_lock);
-	return ret;
+	SFC_ASSERT(ret >= 0);
+	return -ret;
 }
 
 static void